Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @definitelytyped/types-registry for ATA #33791

Closed
wants to merge 5 commits into from

Commits on Oct 3, 2019

  1. Use @definitelytyped/types-registry for ATA

    Fall back to types-registry if `npm install
    @definitelytyped/types-registry` doesn't work.
    
    Notes:
    
    1. This currently requires you to be authenticated with npm. After the
    Github package registry leaves beta, that will no longer be true.
    2. The error handling was incorrect -- it double-handled an exception and
    ignored the return code of execSyncAndLog. I corrected it so that it
    logs if either npm or GHPR fails.
    3. I haven't added tests for this change yet. I see some references to
    types-registry in the tests so I'll see if that's the right place.
    sandersn committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    69f9b6b View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2019

  1. Configuration menu
    Copy the full SHA
    71e0a6d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7370768 View commit details
    Browse the repository at this point in the history
  3. Fix lint

    sandersn committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    8b6f2a8 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2019

  1. Configuration menu
    Copy the full SHA
    ed83f77 View commit details
    Browse the repository at this point in the history