馃 User test baselines have changed for refs/heads/master #34411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
typescript-bot
force-pushed
the
user-update-Microsoft-20190902-refs/heads/master
branch
from
fe83b15
to
1e08429
Compare
|
cc @sandersn |
typescript-bot
force-pushed
the
user-update-Microsoft-20190902-refs/heads/master
branch
3 times, most recently
from
2056ce1
to
c47dfc7
Compare
typescript-bot
force-pushed
the
user-update-Microsoft-20190902-refs/heads/master
branch
from
c47dfc7
to
fb539d5
Compare
sandersn
approved these changes
Oct 15, 2019
| lib/logging/Logger.js(117,20): error TS2345: Argument of type 'string' is not assignable to parameter of type '"error" | "time" | "group" | "debug" | "log" | "info" | "warn" | "trace" | "groupCollapsed" | "groupEnd" | "profile" | "profileEnd" | "clear" | "status"'. | ||
| lib/logging/Logger.js(127,20): error TS2345: Argument of type 'string' is not assignable to parameter of type '"error" | "time" | "group" | "debug" | "log" | "info" | "warn" | "trace" | "groupCollapsed" | "groupEnd" | "profile" | "profileEnd" | "clear" | "status"'. | ||
| lib/util/registerExternalSerializer.js(253,14): error TS2339: Property 'line' does not exist on type 'Position'. | ||
| lib/util/registerExternalSerializer.js(254,14): error TS2339: Property 'column' does not exist on type 'Position'. |
There was a problem hiding this comment.
resolves to Position type, which I think is an addition to the DOM in 3.7
previously it resolved to the Position value const Position = require('acorn').Position, which was intentionally then given the type any because the webpack maintainers haven't had time to type acorn correctly.
| lib/logging/Logger.js(127,20): error TS2345: Argument of type 'string' is not assignable to parameter of type '"error" | "time" | "group" | "debug" | "log" | "info" | "warn" | "trace" | "groupCollapsed" | "groupEnd" | "profile" | "profileEnd" | "clear" | "status"'. | ||
| lib/util/registerExternalSerializer.js(253,14): error TS2339: Property 'line' does not exist on type 'Position'. | ||
| lib/util/registerExternalSerializer.js(254,14): error TS2339: Property 'column' does not exist on type 'Position'. | ||
| lib/validateSchema.js(15,11): error TS2339: Property 'children' does not exist on type 'ErrorObject'. |
There was a problem hiding this comment.
schema-utils' types appear to be wrong (or mismatching webpack's usage at least)
There was a problem hiding this comment.
The number of recent PRs fixing the TS types of schema-utils suggests that this is the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test run was triggerd by a request on #33716
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @microsoft/typescript