make globalThis have an empty declarations

[elibarzilay]

Fixes #33860 by making it an error. This is an improvement, but sounds
like it would be better to make it work later.

[elibarzilay]

@typescript-bot perf test

[elibarzilay]

@typescript-bot perf test this

[RyanCavanaugh]

@typescript-bot perf test this

[typescript-bot]

Heya @RyanCavanaugh, I've started to run the perf test suite on this PR at d259ff6. You can monitor the build here. It should now contribute to this PR's status checks.

Update: The results are in!

[RyanCavanaugh]

@weswigham what do we need to do for Eli's comments to get picked up?

[typescript-bot]

@RyanCavanaugh
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..34561

Metric	master	34561	Delta	Best	Worst
Angular - node (v10.16.3, x64)
Memory used	356,050k (± 0.03%)	356,391k (± 0.01%)	+341k (+ 0.10%)	356,281k	356,461k
Parse Time	1.61s (± 0.58%)	1.61s (± 0.48%)	+0.00s (+ 0.06%)	1.59s	1.63s
Bind Time	0.86s (± 0.70%)	0.86s (± 1.06%)	+0.00s (+ 0.47%)	0.85s	0.89s
Check Time	4.52s (± 0.59%)	4.51s (± 0.58%)	-0.01s (- 0.18%)	4.45s	4.56s
Emit Time	5.25s (± 0.79%)	5.25s (± 0.36%)	+0.00s (+ 0.06%)	5.21s	5.29s
Total Time	12.23s (± 0.52%)	12.23s (± 0.21%)	+0.00s (+ 0.01%)	12.16s	12.29s
Monaco - node (v10.16.3, x64)
Memory used	366,949k (± 0.01%)	367,007k (± 0.01%)	+58k (+ 0.02%)	366,923k	367,108k
Parse Time	1.25s (± 0.48%)	1.25s (± 0.46%)	-0.00s (- 0.16%)	1.24s	1.27s
Bind Time	0.75s (± 0.53%)	0.75s (± 0.69%)	0.00s ( 0.00%)	0.74s	0.76s
Check Time	4.65s (± 0.49%)	4.63s (± 0.65%)	-0.02s (- 0.47%)	4.57s	4.70s
Emit Time	2.95s (± 0.32%)	2.95s (± 0.78%)	+0.00s (+ 0.07%)	2.90s	3.02s
Total Time	9.60s (± 0.27%)	9.58s (± 0.52%)	-0.02s (- 0.19%)	9.50s	9.74s
TFS - node (v10.16.3, x64)
Memory used	322,536k (± 0.02%)	322,547k (± 0.02%)	+11k (+ 0.00%)	322,436k	322,808k
Parse Time	0.95s (± 0.65%)	0.95s (± 0.42%)	0.00s ( 0.00%)	0.94s	0.96s
Bind Time	0.73s (± 0.92%)	0.72s (± 1.06%)	-0.01s (- 1.51%)	0.70s	0.73s
Check Time	4.11s (± 0.33%)	4.10s (± 0.44%)	-0.00s (- 0.05%)	4.07s	4.15s
Emit Time	3.06s (± 0.59%)	3.04s (± 0.93%)	-0.02s (- 0.75%)	2.96s	3.08s
Total Time	8.85s (± 0.21%)	8.81s (± 0.48%)	-0.04s (- 0.45%)	8.70s	8.90s
Angular - node (v12.1.0, x64)
Memory used	331,668k (± 0.03%)	331,860k (± 0.06%)	+192k (+ 0.06%)	331,113k	332,084k
Parse Time	1.56s (± 0.71%)	1.55s (± 0.42%)	-0.01s (- 0.77%)	1.54s	1.56s
Bind Time	0.84s (± 0.79%)	0.84s (± 0.88%)	-0.00s (- 0.36%)	0.83s	0.86s
Check Time	4.43s (± 0.51%)	4.41s (± 0.64%)	-0.02s (- 0.47%)	4.37s	4.49s
Emit Time	5.44s (± 0.58%)	5.44s (± 0.88%)	-0.00s (- 0.00%)	5.37s	5.54s
Total Time	12.28s (± 0.37%)	12.25s (± 0.62%)	-0.04s (- 0.29%)	12.13s	12.42s
Monaco - node (v12.1.0, x64)
Memory used	346,689k (± 0.02%)	346,701k (± 0.01%)	+12k (+ 0.00%)	346,626k	346,775k
Parse Time	1.22s (± 0.55%)	1.22s (± 0.56%)	-0.00s (- 0.08%)	1.20s	1.23s
Bind Time	0.73s (± 0.51%)	0.72s (± 0.80%)	-0.00s (- 0.28%)	0.71s	0.74s
Check Time	4.48s (± 0.59%)	4.47s (± 0.65%)	-0.01s (- 0.22%)	4.41s	4.53s
Emit Time	3.00s (± 0.65%)	3.00s (± 1.25%)	-0.00s (- 0.10%)	2.92s	3.08s
Total Time	9.42s (± 0.39%)	9.41s (± 0.53%)	-0.02s (- 0.17%)	9.29s	9.51s
TFS - node (v12.1.0, x64)
Memory used	304,934k (± 0.02%)	304,898k (± 0.03%)	-36k (- 0.01%)	304,673k	305,041k
Parse Time	0.95s (± 0.79%)	0.95s (± 0.63%)	-0.00s (- 0.11%)	0.93s	0.96s
Bind Time	0.69s (± 0.94%)	0.68s (± 0.72%)	-0.00s (- 0.58%)	0.68s	0.70s
Check Time	4.04s (± 0.39%)	4.05s (± 0.51%)	+0.01s (+ 0.15%)	4.02s	4.10s
Emit Time	3.11s (± 0.86%)	3.10s (± 0.51%)	-0.01s (- 0.32%)	3.07s	3.14s
Total Time	8.78s (± 0.32%)	8.77s (± 0.32%)	-0.01s (- 0.08%)	8.71s	8.83s
Angular - node (v8.9.0, x64)
Memory used	350,837k (± 0.02%)	351,187k (± 0.02%)	+349k (+ 0.10%)	351,061k	351,309k
Parse Time	2.09s (± 0.42%)	2.09s (± 0.36%)	+0.00s (+ 0.19%)	2.08s	2.11s
Bind Time	0.89s (± 0.53%)	0.90s (± 1.03%)	+0.01s (+ 0.56%)	0.88s	0.92s
Check Time	5.25s (± 0.48%)	5.26s (± 0.41%)	+0.01s (+ 0.29%)	5.22s	5.31s
Emit Time	6.27s (± 0.84%)	6.20s (± 0.97%)	-0.06s (- 1.04%)	6.06s	6.32s
Total Time	14.50s (± 0.40%)	14.46s (± 0.52%)	-0.04s (- 0.30%)	14.26s	14.63s
Monaco - node (v8.9.0, x64)
Memory used	364,748k (± 0.01%)	364,725k (± 0.01%)	-23k (- 0.01%)	364,671k	364,806k
Parse Time	1.56s (± 0.37%)	1.56s (± 0.55%)	+0.00s (+ 0.13%)	1.54s	1.58s
Bind Time	0.92s (± 0.79%)	0.91s (± 0.44%)	-0.01s (- 0.76%)	0.90s	0.92s
Check Time	5.53s (± 0.58%)	5.51s (± 0.52%)	-0.02s (- 0.42%)	5.46s	5.60s
Emit Time	3.05s (± 0.45%)	3.06s (± 0.70%)	+0.01s (+ 0.46%)	3.02s	3.11s
Total Time	11.05s (± 0.32%)	11.04s (± 0.37%)	-0.01s (- 0.13%)	10.94s	11.13s
TFS - node (v8.9.0, x64)
Memory used	321,405k (± 0.01%)	321,432k (± 0.01%)	+27k (+ 0.01%)	321,385k	321,486k
Parse Time	1.27s (± 0.41%)	1.28s (± 0.45%)	+0.01s (+ 0.47%)	1.26s	1.29s
Bind Time	0.74s (± 0.91%)	0.73s (± 0.65%)	-0.00s (- 0.54%)	0.72s	0.74s
Check Time	4.70s (± 0.38%)	4.70s (± 0.39%)	+0.00s (+ 0.02%)	4.67s	4.75s
Emit Time	3.21s (± 0.54%)	3.20s (± 0.76%)	-0.01s (- 0.37%)	3.13s	3.25s
Total Time	9.92s (± 0.20%)	9.91s (± 0.39%)	-0.01s (- 0.10%)	9.82s	10.00s
Angular - node (v8.9.0, x86)
Memory used	199,004k (± 0.03%)	199,135k (± 0.03%)	+131k (+ 0.07%)	199,029k	199,231k
Parse Time	2.02s (± 0.62%)	2.01s (± 0.34%)	-0.01s (- 0.35%)	2.00s	2.03s
Bind Time	1.03s (± 1.14%)	1.03s (± 1.01%)	+0.00s (+ 0.29%)	1.02s	1.06s
Check Time	4.79s (± 0.51%)	4.79s (± 0.65%)	+0.01s (+ 0.10%)	4.72s	4.88s
Emit Time	6.09s (± 0.99%)	6.12s (± 1.27%)	+0.04s (+ 0.59%)	6.01s	6.31s
Total Time	13.93s (± 0.40%)	13.96s (± 0.62%)	+0.04s (+ 0.26%)	13.82s	14.18s
Monaco - node (v8.9.0, x86)
Memory used	204,190k (± 0.02%)	204,223k (± 0.02%)	+33k (+ 0.02%)	204,129k	204,299k
Parse Time	1.60s (± 0.25%)	1.61s (± 0.92%)	+0.01s (+ 0.69%)	1.59s	1.66s
Bind Time	0.74s (± 0.49%)	0.75s (± 1.00%)	+0.00s (+ 0.40%)	0.73s	0.77s
Check Time	5.37s (± 1.02%)	5.35s (± 1.16%)	-0.01s (- 0.28%)	5.12s	5.43s
Emit Time	2.91s (± 2.58%)	2.89s (± 2.32%)	-0.02s (- 0.65%)	2.81s	3.13s
Total Time	10.62s (± 0.49%)	10.60s (± 0.39%)	-0.02s (- 0.20%)	10.52s	10.68s
TFS - node (v8.9.0, x86)
Memory used	180,932k (± 0.02%)	180,947k (± 0.01%)	+16k (+ 0.01%)	180,897k	180,985k
Parse Time	1.31s (± 1.20%)	1.31s (± 0.84%)	+0.00s (+ 0.15%)	1.30s	1.35s
Bind Time	0.69s (± 0.98%)	0.69s (± 0.71%)	0.00s ( 0.00%)	0.69s	0.71s
Check Time	4.46s (± 0.45%)	4.46s (± 0.74%)	-0.00s (- 0.04%)	4.40s	4.55s
Emit Time	2.95s (± 0.59%)	2.99s (± 0.76%)	+0.03s (+ 1.12%)	2.96s	3.05s
Total Time	9.42s (± 0.39%)	9.45s (± 0.53%)	+0.03s (+ 0.35%)	9.38s	9.60s

System

Machine Name	ts-ci-ubuntu
Platform	linux 4.4.0-161-generic
Architecture	x64
Available Memory	16 GB
Available Memory	6 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v10.16.3, x64)
• node (v12.1.0, x64)
• node (v8.9.0, x64)
• node (v8.9.0, x86)

Scenarios

• Angular - node (v10.16.3, x64)
• Angular - node (v12.1.0, x64)
• Angular - node (v8.9.0, x64)
• Angular - node (v8.9.0, x86)
• Monaco - node (v10.16.3, x64)
• Monaco - node (v12.1.0, x64)
• Monaco - node (v8.9.0, x64)
• Monaco - node (v8.9.0, x86)
• TFS - node (v10.16.3, x64)
• TFS - node (v12.1.0, x64)
• TFS - node (v8.9.0, x64)
• TFS - node (v8.9.0, x86)

Benchmark	Name	Iterations
Current	34561	10
Baseline	master	10

[sandersn]

This seems reasonable as a fix, but I'd like to see whether we can stop special-casing globalThis in some places now that it has a declaration list. A good time would be when we have time to make the test program succeed instead of erroring.

The performance results seem reasonable to me, but I'd like @rbuckton to confirm.

[elibarzilay]

@typescript-bot perf test this

[rbuckton]

@typescript-bot perf test

[typescript-bot]

Heya @rbuckton, I've started to run the perf test suite on this PR at d259ff6. You can monitor the build here. It should now contribute to this PR's status checks.

Update: The results are in!

[typescript-bot]

@rbuckton
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..34561

Metric	master	34561	Delta	Best	Worst
Angular - node (v10.16.3, x64)
Memory used	355,105k (± 0.02%)	356,479k (± 0.02%)	+1,374k (+ 0.39%)	356,360k	356,647k
Parse Time	1.62s (± 0.54%)	1.62s (± 0.49%)	-0.00s (- 0.12%)	1.60s	1.64s
Bind Time	0.86s (± 0.39%)	0.86s (± 0.86%)	-0.00s (- 0.00%)	0.85s	0.88s
Check Time	4.51s (± 0.62%)	4.53s (± 0.58%)	+0.01s (+ 0.29%)	4.47s	4.59s
Emit Time	5.25s (± 0.53%)	5.30s (± 0.54%)	+0.05s (+ 0.95%)	5.25s	5.36s
Total Time	12.25s (± 0.41%)	12.31s (± 0.37%)	+0.06s (+ 0.46%)	12.24s	12.42s
Monaco - node (v10.16.3, x64)
Memory used	365,961k (± 0.01%)	366,912k (± 0.01%)	+951k (+ 0.26%)	366,817k	367,026k
Parse Time	1.26s (± 0.75%)	1.26s (± 0.54%)	+0.00s (+ 0.08%)	1.25s	1.28s
Bind Time	0.75s (± 0.77%)	0.75s (± 0.65%)	+0.00s (+ 0.53%)	0.74s	0.76s
Check Time	4.64s (± 0.58%)	4.63s (± 0.71%)	-0.01s (- 0.19%)	4.55s	4.68s
Emit Time	2.93s (± 0.97%)	2.97s (± 1.17%)	+0.03s (+ 1.09%)	2.89s	3.05s
Total Time	9.59s (± 0.66%)	9.61s (± 0.47%)	+0.02s (+ 0.24%)	9.46s	9.70s
TFS - node (v10.16.3, x64)
Memory used	321,635k (± 0.02%)	322,521k (± 0.02%)	+886k (+ 0.28%)	322,389k	322,660k
Parse Time	0.96s (± 0.81%)	0.96s (± 0.54%)	-0.00s (- 0.21%)	0.95s	0.97s
Bind Time	0.72s (± 0.72%)	0.72s (± 0.66%)	-0.00s (- 0.55%)	0.71s	0.73s
Check Time	4.10s (± 0.44%)	4.10s (± 0.58%)	0.00s ( 0.00%)	4.02s	4.13s
Emit Time	3.05s (± 0.61%)	3.03s (± 0.50%)	-0.02s (- 0.52%)	2.99s	3.06s
Total Time	8.83s (± 0.38%)	8.80s (± 0.38%)	-0.03s (- 0.29%)	8.72s	8.89s
Angular - node (v12.1.0, x64)
Memory used	330,577k (± 0.08%)	332,009k (± 0.02%)	+1,432k (+ 0.43%)	331,851k	332,139k
Parse Time	1.56s (± 0.67%)	1.56s (± 0.77%)	+0.00s (+ 0.32%)	1.54s	1.59s
Bind Time	0.84s (± 0.62%)	0.84s (± 0.86%)	+0.00s (+ 0.12%)	0.83s	0.85s
Check Time	4.44s (± 0.44%)	4.42s (± 0.54%)	-0.02s (- 0.47%)	4.36s	4.47s
Emit Time	5.43s (± 1.05%)	5.44s (± 0.52%)	+0.01s (+ 0.20%)	5.37s	5.51s
Total Time	12.27s (± 0.52%)	12.27s (± 0.41%)	-0.00s (- 0.02%)	12.12s	12.33s
Monaco - node (v12.1.0, x64)
Memory used	345,738k (± 0.01%)	346,716k (± 0.01%)	+978k (+ 0.28%)	346,634k	346,878k
Parse Time	1.23s (± 0.94%)	1.23s (± 0.95%)	+0.00s (+ 0.33%)	1.21s	1.26s
Bind Time	0.73s (± 1.02%)	0.72s (± 0.65%)	-0.01s (- 1.37%)	0.71s	0.73s
Check Time	4.48s (± 0.44%)	4.48s (± 0.66%)	-0.00s (- 0.02%)	4.42s	4.55s
Emit Time	2.99s (± 0.60%)	2.99s (± 0.56%)	-0.00s (- 0.03%)	2.95s	3.03s
Total Time	9.43s (± 0.33%)	9.42s (± 0.42%)	-0.01s (- 0.10%)	9.36s	9.51s
TFS - node (v12.1.0, x64)
Memory used	304,007k (± 0.02%)	304,926k (± 0.02%)	+919k (+ 0.30%)	304,781k	305,044k
Parse Time	0.95s (± 0.79%)	0.95s (± 0.63%)	-0.00s (- 0.11%)	0.94s	0.96s
Bind Time	0.68s (± 0.70%)	0.68s (± 0.87%)	+0.00s (+ 0.15%)	0.67s	0.70s
Check Time	4.04s (± 0.49%)	4.04s (± 0.62%)	-0.00s (- 0.05%)	3.99s	4.11s
Emit Time	3.07s (± 0.56%)	3.09s (± 0.40%)	+0.02s (+ 0.52%)	3.05s	3.11s
Total Time	8.75s (± 0.38%)	8.76s (± 0.38%)	+0.01s (+ 0.15%)	8.70s	8.82s
Angular - node (v8.9.0, x64)
Memory used	349,967k (± 0.02%)	351,185k (± 0.02%)	+1,218k (+ 0.35%)	351,076k	351,341k
Parse Time	2.10s (± 0.40%)	2.09s (± 0.21%)	-0.01s (- 0.33%)	2.08s	2.10s
Bind Time	0.90s (± 0.62%)	0.91s (± 0.84%)	+0.01s (+ 0.78%)	0.89s	0.92s
Check Time	5.24s (± 0.47%)	5.28s (± 0.72%)	+0.03s (+ 0.61%)	5.21s	5.37s
Emit Time	6.20s (± 0.81%)	6.23s (± 1.03%)	+0.02s (+ 0.40%)	6.10s	6.38s
Total Time	14.45s (± 0.36%)	14.50s (± 0.62%)	+0.06s (+ 0.39%)	14.34s	14.76s
Monaco - node (v8.9.0, x64)
Memory used	363,734k (± 0.02%)	364,731k (± 0.01%)	+998k (+ 0.27%)	364,623k	364,813k
Parse Time	1.56s (± 0.33%)	1.56s (± 0.45%)	0.00s ( 0.00%)	1.55s	1.58s
Bind Time	0.92s (± 0.40%)	0.92s (± 0.61%)	+0.00s (+ 0.22%)	0.91s	0.93s
Check Time	5.53s (± 0.36%)	5.54s (± 0.54%)	+0.01s (+ 0.18%)	5.47s	5.59s
Emit Time	3.03s (± 0.63%)	3.06s (± 0.44%)	+0.02s (+ 0.82%)	3.03s	3.09s
Total Time	11.04s (± 0.31%)	11.08s (± 0.29%)	+0.04s (+ 0.34%)	11.01s	11.14s
TFS - node (v8.9.0, x64)
Memory used	320,508k (± 0.01%)	321,415k (± 0.02%)	+908k (+ 0.28%)	321,309k	321,523k
Parse Time	1.28s (± 0.79%)	1.27s (± 0.51%)	-0.00s (- 0.31%)	1.26s	1.29s
Bind Time	0.74s (± 1.01%)	0.74s (± 0.95%)	+0.00s (+ 0.27%)	0.72s	0.75s
Check Time	4.71s (± 0.78%)	4.71s (± 0.76%)	+0.00s (+ 0.04%)	4.65s	4.79s
Emit Time	3.22s (± 0.79%)	3.23s (± 0.61%)	+0.01s (+ 0.40%)	3.18s	3.28s
Total Time	9.95s (± 0.47%)	9.95s (± 0.49%)	+0.01s (+ 0.10%)	9.83s	10.05s
Angular - node (v8.9.0, x86)
Memory used	198,643k (± 0.03%)	199,160k (± 0.03%)	+517k (+ 0.26%)	199,036k	199,337k
Parse Time	2.03s (± 1.11%)	2.01s (± 0.30%)	-0.01s (- 0.59%)	2.00s	2.03s
Bind Time	1.03s (± 1.06%)	1.03s (± 0.90%)	-0.00s (- 0.39%)	1.01s	1.05s
Check Time	4.80s (± 0.34%)	4.84s (± 0.69%)	+0.03s (+ 0.67%)	4.78s	4.91s
Emit Time	6.07s (± 2.35%)	6.08s (± 1.58%)	+0.01s (+ 0.15%)	5.86s	6.34s
Total Time	13.94s (± 0.94%)	13.96s (± 0.89%)	+0.02s (+ 0.14%)	13.68s	14.26s
Monaco - node (v8.9.0, x86)
Memory used	203,749k (± 0.02%)	204,237k (± 0.01%)	+488k (+ 0.24%)	204,160k	204,313k
Parse Time	1.61s (± 0.48%)	1.62s (± 0.82%)	+0.01s (+ 0.50%)	1.59s	1.65s
Bind Time	0.75s (± 0.53%)	0.75s (± 0.80%)	-0.01s (- 0.67%)	0.73s	0.76s
Check Time	5.39s (± 0.57%)	5.37s (± 1.16%)	-0.02s (- 0.35%)	5.14s	5.45s
Emit Time	2.89s (± 1.47%)	2.90s (± 2.06%)	+0.01s (+ 0.38%)	2.83s	3.11s
Total Time	10.64s (± 0.54%)	10.64s (± 0.50%)	-0.01s (- 0.08%)	10.56s	10.78s
TFS - node (v8.9.0, x86)
Memory used	180,544k (± 0.02%)	180,932k (± 0.02%)	+387k (+ 0.21%)	180,841k	181,004k
Parse Time	1.31s (± 0.52%)	1.31s (± 0.84%)	+0.00s (+ 0.38%)	1.29s	1.34s
Bind Time	0.70s (± 0.93%)	0.69s (± 0.80%)	-0.01s (- 0.86%)	0.68s	0.71s
Check Time	4.48s (± 0.70%)	4.49s (± 0.47%)	+0.02s (+ 0.36%)	4.45s	4.54s
Emit Time	2.95s (± 1.05%)	2.97s (± 1.01%)	+0.02s (+ 0.75%)	2.89s	3.03s
Total Time	9.43s (± 0.49%)	9.46s (± 0.34%)	+0.04s (+ 0.39%)	9.38s	9.54s

System

Machine Name	ts-ci-ubuntu
Platform	linux 4.4.0-161-generic
Architecture	x64
Available Memory	16 GB
Available Memory	6 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v10.16.3, x64)
• node (v12.1.0, x64)
• node (v8.9.0, x64)
• node (v8.9.0, x86)

Scenarios

• Angular - node (v10.16.3, x64)
• Angular - node (v12.1.0, x64)
• Angular - node (v8.9.0, x64)
• Angular - node (v8.9.0, x86)
• Monaco - node (v10.16.3, x64)
• Monaco - node (v12.1.0, x64)
• Monaco - node (v8.9.0, x64)
• Monaco - node (v8.9.0, x86)
• TFS - node (v10.16.3, x64)
• TFS - node (v12.1.0, x64)
• TFS - node (v8.9.0, x64)
• TFS - node (v8.9.0, x86)

Benchmark	Name	Iterations
Current	34561	10
Baseline	master	10