Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in assigning function with this ref to alias #34650

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Fix crash in assigning function with this ref to alias #34650

merged 1 commit into from
Oct 22, 2019

Conversation

Knagis
Copy link
Contributor

@Knagis Knagis commented Oct 22, 2019

Fixes #34647

  • There is an associated issue in the Backlog milestone (required)
  • Code is up-to-date with the master branch
  • You've successfully run gulp runtests locally
  • There are new or updated unit tests validating the change

@Knagis Knagis mentioned this pull request Oct 22, 2019
Closed
@sandersn
Copy link
Member

Nice catch, thanks @Knagis!

@sandersn sandersn merged commit 479d306 into microsoft:master Oct 22, 2019
@sandersn
Copy link
Member

@RyanCavanaugh @DanielRosenwasser here's another one that should be in 3.7.2.

@sandersn
Copy link
Member

@typescript-bot cherry pick this

@sandersn
Copy link
Member

Argghh

@typescript-bot cherry-pick this

And next time reply "I don't know how to cherry pick this"

@sandersn
Copy link
Member

@typescript-bot cherry-pick this to release-3.7

And next time reply "Where should I cherry-pick this to?"

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Oct 22, 2019
@Knagis
Cherry-pick PR microsoft#34650 into release-3.7
7215042 
Component commits:
6a6f4a6 Fix crash in assigning function with this ref to alias
@typescript-bot typescript-bot mentioned this pull request Oct 22, 2019
Merged
@typescript-bot
Copy link
Collaborator

Hey @sandersn, I've opened #34658 for you.

sandersn pushed a commit that referenced this pull request Oct 22, 2019
@typescript-bot @sandersn
Cherry-pick PR #34650 into release-3.7 (#34658)
ea71ecf 
Component commits:
6a6f4a6 Fix crash in assigning function with this ref to alias
@Knagis Knagis mentioned this pull request Nov 19, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--allowJs (3.7.0 regression): Cannot reference this when extending imported function prototype
3 participants
@Knagis @sandersn @typescript-bot