JSDoc type reference understands require with entity name #34804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, `require("x").c`. This is the value equivalent of
`import("x").a.b.c`, but the syntax tree is not as nicely designed for
this purpose.
Fixes #34802
|
note: this needs to be in 3.7 too |
weswigham
reviewed
Oct 29, 2019
| if (isVariableDeclaration(decl) && decl.initializer) { | ||
| let expr = decl.initializer; | ||
| // skip past entity names, eg `require("x").a.b.c` | ||
| while (isPropertyAccessExpression(expr)) { |
There was a problem hiding this comment.
Those work -- I added a test. I guess they use the same AST as normal property access expressions?
weswigham
approved these changes
Oct 29, 2019
sandersn
deleted the
jsdoc-type-reference-understands-require-w/entity-name
branch
|
@typescript-bot cherry-pick this to release-3.7 (Not sure this is going to work, this has been a hot spot of bug fixes.) |
|
Hey @sandersn, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.7 manually. |
sandersn
added a commit
that referenced
this pull request
Oct 29, 2019
* resolve require with entity name postfix
For example, `require("x").c`. This is the value equivalent of
`import("x").a.b.c`, but the syntax tree is not as nicely designed for
this purpose.
Fixes #34802
* Add bug number to test
* Add optional chain test
|
Thanks for trying, typescript-bot. I cherry-picked the squashed commit manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example,
require("x").c. This is the value equivalent ofimport("x").a.b.c, but the syntax tree is not as nicely designed for this purpose.Fixes #34802