Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completions for asserts and declare #36355

Merged
merged 2 commits into from Jan 22, 2020
Merged

Completions for asserts and declare #36355

merged 2 commits into from Jan 22, 2020

Conversation

sandersn
Copy link
Member

I'm not 100% sure that asserts should go into typeKeywords instead of an ad-hoc addition to KeywordCompletion.TypeKeywords in getTypescriptKeywordCompletions. But this makes the tests easier to update, which is a good sign that it's more predictable for users as well.

Fixes #35187

@sandersn sandersn merged commit c8e2f58 into master Jan 22, 2020
@sandersn sandersn deleted the completions-for-asserts-declare branch January 22, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

@sheetalkamat sheetalkamat Awaiting requested review from sheetalkamat

Assignees

@sandersn sandersn

Labels
Author: Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

asserts and declare in classes are not included in suggestions
3 participants
@sandersn @andrewbranch @typescript-bot