Remove usage of non-standardised Reflect.decorate.
#36408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Reflect.decorate` is not on a standards track and has no active proposal being championed in TC39. We have no idea if `Reflect.decorate` will get added to the language, even if it does, we have no guarantee it will be the implementation we are assuming it to be. By having this condition in the code, we are likely preventing `Reflect.decorate` from ever existing in the language, just like `Array.prototype.flatten` had to get a different name because MooTools would attempt to use it if it existed and it was not the implementation MooTools assumed it would be.
ExE-Boss
approved these changes
Feb 15, 2020
|
This will also need fixing in tslib. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflect.decorateis not on a standards track and has no active proposal being championed in TC39.We have no idea if
Reflect.decoratewill get added to the language, even if it does, we have no guarantee it will be the implementation we are assuming it to be.By having this condition in the code, we are likely preventing
Reflect.decoratefrom ever existing in the language, just likeArray.prototype.flattenhad to get a different name because MooTools would attempt to use it if it existed and it was not the implementation MooTools assumed it would be.Here is a W3C TAG finding which recommends against usage of speculative features -- https://www.w3.org/2001/tag/doc/polyfills/#don-t-use-speculative-polyfills-that-defer-to-native-implementations
Please verify that:
Backlogmilestone (required)masterbranchgulp runtestslocallyFixes #