Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extract const in jsx #37912

Merged
merged 3 commits into from
May 19, 2020
Merged

fix: extract const in jsx #37912

merged 3 commits into from
May 19, 2020

Conversation

Jack-Works
Copy link
Contributor

Before:

image

After:
image

@sandersn sandersn added this to Not started in PR Backlog Apr 21, 2020
@sandersn sandersn moved this from Not started to Needs review in PR Backlog Apr 21, 2020
@sandersn sandersn added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Apr 21, 2020
@Jack-Works
Copy link
Contributor Author

@sandersn hi it's a small fix plz have a look! 😆

andrewbranch
andrewbranch requested changes May 18, 2020
View reviewed changes
src/services/refactors/extractSymbol.ts Outdated Show resolved Hide resolved
src/services/refactors/extractSymbol.ts Outdated Show resolved Hide resolved
PR Backlog automation moved this from Needs review to Waiting on author May 18, 2020
Jack-Works and others added 2 commits May 19, 2020 11:27
@Jack-Works @andrewbranch
Update src/services/refactors/extractSymbol.ts
75fde27 
Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com>
@Jack-Works @andrewbranch
Update src/services/refactors/extractSymbol.ts
c09b684 
Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com>
PR Backlog automation moved this from Waiting on author to Needs merge May 19, 2020
@andrewbranch
Copy link
Member

Anyone else want to look before I merge?

@andrewbranch andrewbranch merged commit 7ec467e into microsoft:master May 19, 2020
PR Backlog automation moved this from Needs merge to Done May 19, 2020
cangSDARM added a commit to cangSDARM/TypeScript that referenced this pull request May 20, 2020
@cangSDARM
Merge remote-tracking branch 'upstream/master'
60ee5e8 
* upstream/master:
  Support naming tuple members (microsoft#38234)
  LEGO: check in for master to temporary branch.
  fix: extract const in jsx (microsoft#37912)
  No contextual types from circular mapped type properties (microsoft#38653)
  Ensure formatter can always get a newline character (microsoft#38579)
  Fix debug command for Node debugging
  Remove mentions of runtests-browser in CONTRIBUTING.md
  fix(33233): add outlining for comments before property access expression
  regression(38485): allow using rawText property in processing a tagged template
@Jack-Works Jack-Works deleted the fix/extract-const-in-jsx branch April 23, 2022 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

@sheetalkamat sheetalkamat sheetalkamat approved these changes

Assignees

@andrewbranch andrewbranch

Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
Archived in project
PR Backlog
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Jack-Works @andrewbranch @sheetalkamat @sandersn