Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(37703): Bad JSDoc comments leads to generate invalid declaration file #38155

Merged
merged 1 commit into from May 5, 2020

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #37703

@sirreal
Copy link

sirreal commented Apr 27, 2020

I came across #37703 recently: WordPress/gutenberg#21926

I applied the patch here to the compiler in my local project and it reported the error, apparently fixing #37703 👍

packages/url/src/add-query-args.js:22:41 - error TS1016: A required parameter cannot follow an optional parameter.

22 export function addQueryArgs( url = '', args ) {

@sandersn sandersn added this to Needs review in PR Backlog May 5, 2020
@sandersn sandersn added the For Backlog Bug PRs that fix a backlog bug label May 5, 2020
@sandersn sandersn self-requested a review May 5, 2020 17:13
PR Backlog automation moved this from Needs review to Needs merge May 5, 2020
@weswigham weswigham merged commit c219fda into microsoft:master May 5, 2020
PR Backlog automation moved this from Needs merge to Done May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
  
Done
Development

Successfully merging this pull request may close these issues.

Bad JSDoc comments leads to generate invalid declaration file
4 participants