Consistent narrowing by discriminant #38311
Merged
+471
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@typescript-bot test this |
|
Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at 88025e6. You can monitor the build here. |
|
Heya @ahejlsberg, I've started to run the perf test suite on this PR at 88025e6. You can monitor the build here. Update: The results are in! |
|
Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 88025e6. You can monitor the build here. |
|
Heya @ahejlsberg, I've started to run the extended test suite on this PR at 88025e6. You can monitor the build here. |
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
|
@ahejlsberg Here they are:Comparison Report - master..38311
System
Hosts
Scenarios
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Tests all look good (nothing but preexisting conditions). |
|
@weswigham I think it pretty much replaces the second: this is so much simpler. I don’t believe this is quite as general as the other PR aims to be, but I went through all the duplicates on the original issue and this fixes them. I think my only comment here is whether it’s worth filter the declared type for non-object types. I’m not sure this approach works if the declared type is something like The first PR you link was some tidying I haven’t updated yet (sorry). I don’t think it’s changed by this. |
RyanCavanaugh
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we fix inconsistencies in our narrowing logic for discriminated unions. Previously we required the declared type of a reference to be a union type before we'd narrow by discriminants. This meant narrowing by discriminant wouldn't work in conjunction with user defined type predicate narrowing, with the notable (and inconsistent) exception of
switchstatements. We now consistently allow narrowing by discriminant of a reference with a declared type that isn't a union but a control flow type that is (which, for example, might result from first narrowing anunknownto a union type using a user defined type predicate and then narrowing the union type by a discriminant).Fixes #30557.
Fixes #36777.