Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression(38485): Unable to specify rawText when programmatically creating tagged template literals #38500

Merged
merged 1 commit into from
May 19, 2020

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #38485

@a-tarasyuk
Copy link
Contributor Author

сс @DanielRosenwasser @rbuckton

@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-3.9

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 12, 2020

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-3.9 on this PR at ee3f2ce. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I've opened #38506 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request May 12, 2020
Component commits:
ee3f2ce regression(38485): allow using rawText property in processing a tagged template
Copy link
Contributor

@Kingwl Kingwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DanielRosenwasser
Copy link
Member

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 14, 2020

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at ee3f2ce. You can monitor the build here.

@DanielRosenwasser
Copy link
Member

@petebacondarwin a build should be available in a bit - can you verify that it works for you?

@petebacondarwin
Copy link
Contributor

Will do. Thanks!

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 14, 2020

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/73938/artifacts?artifactName=tgz&fileId=448F72D04EC0F5F692CE5D20138BF654FD76224192855005E3050150AD16EDFC02&fileName=/typescript-4.0.0-insiders.20200514.tgz"
    }
}

and then running npm install.


There is also a playground for this build.

@petebacondarwin
Copy link
Contributor

Testing now

@petebacondarwin
Copy link
Contributor

That works for me! Thanks for dealing with this so quickly.

@sandersn sandersn added this to Not started in PR Backlog May 19, 2020
@DanielRosenwasser DanielRosenwasser merged commit 46f100f into microsoft:master May 19, 2020
PR Backlog automation moved this from Not started to Done May 19, 2020
DanielRosenwasser added a commit that referenced this pull request May 19, 2020
🤖 Pick PR #38500 (regression(38485): Unable to specif...) into release-3.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
PR Backlog
  
Done
Development

Successfully merging this pull request may close these issues.

3.9.1-rc regression: Unable to specify rawText when programmatically creating tagged template literals
5 participants