Resolve only relative references in open files on syntax server

[sheetalkamat]

Resolve only relative module references in the open files

[sheetalkamat]

@typescript-bot pack this

[typescript-bot]

Heya @sheetalkamat, I've started to run the tarball bundle task on this PR at 56fb305. You can monitor the build here.

[DanielRosenwasser]

Looks like there's no packed build because of quote preference changes in a fourslash test.

Click for log

  71790 passing (8m)
  1 failing

  1) 
       
         fourslash tests
           tests/cases/fourslash/codeFixClassImplementInterfaceAutoImports.ts
             fourslash test codeFixClassImplementInterfaceAutoImports.ts runs correctly:
     Error: At line 1, col 0: Actual range text doesn't match expected text.

Expected:
import { Base } from './interface';
import A from './types1';
import { B, C, D } from './types2';

export class C implements Base {
    a: Readonly<A> & { kind: "a"; };
    b<T extends B = B>(p1: C): D<C> {
        throw new Error('Method not implemented.');
    }
}

Actual:
import { Base } from './interface';
import A from './types1';
import { B, C, D } from './types2';

export class C implements Base {
    a: Readonly<A> & { kind: 'a'; };
    b<T extends B = B>(p1: C): D<C> {
        throw new Error('Method not implemented.');
    }
}
      at TestState.raiseError (src/harness/fourslashImpl.ts:525:19)
      at TestState.verifyTextMatches (src/harness/fourslashImpl.ts:2659:22)
      at Object.runFourSlashTest (src/harness/fourslashImpl.ts:3712:9)
      at Context.<anonymous> (src/testRunner/fourslashRunner.ts:57:43)
      at processImmediate (internal/timers.js:456:21)

[sheetalkamat]

@typescript-bot pack this

[typescript-bot]

Heya @sheetalkamat, I've started to run the tarball bundle task on this PR at db10229. You can monitor the build here.

[typescript-bot]

Hey @sheetalkamat, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/79103/artifacts?artifactName=tgz&fileId=C530B3CA0A000595EA0BE821554CD29D734277E601853EF651F4909FCB1BC0C902&fileName=/typescript-4.0.0-insiders.20200707.tgz"
    }
}

and then running npm install.

[typescript-bot]

Hey @sheetalkamat, something went wrong when looking for the build artifact. (You can check the log here).

[sheetalkamat]

@andrewbranch can you please review again. I had to add another commit to ensure we aren't included triple slash reference tree (but including them only from open file) since we removed noResolve.

@DanielRosenwasser @RyanCavanaugh what is your take on this. do we want to get this in?

[DanielRosenwasser]

Yes, I think we want to get this in, but I have kind of been worrying about two scenarios:

1. How well does this work when a file has 100+ imports? It's an edge-case, but it's something we should consider.
2. Is there a way to remove pressure from the project system over time and go back to the single-file view of the world? Once the semantic server is loaded, we probably can unload some memory.

[andrewbranch]

Latest change makes sense to me 👍

[andrewbranch]

❤️

[sheetalkamat]

1. How well does this work when a file has 100+ imports? It's an edge-case, but it's something we should consider.

Should we cap this to say resolving 10 module names per file or something. But i am not sure if anyone uses those many relative imports in the file. Dont have data to cap on number of say that we should handle it.

2. Is there a way to remove pressure from the project system over time and go back to the single-file view of the world? Once the semantic server is loaded, we probably can unload some memory.

Do you think we should only use single file as open file (file thats last opened or asked to update project based on semantic operation requested). I did consider this but that just means we wont reuse the program as often if say user navigates to new file using go to def and hovers over certain item and goes back as an example. The current one keeps program updates to minimal and keeps on reusing things till it can.. leading to less program updates and more info. I am open to suggestion though.

[DanielRosenwasser]

Should we cap this to say resolving 10 module names per file or something

Let's do it in a later pass, I'd like to try to get this in the next nightly so that we can get feedback as soon as we can.

The current one keeps program updates to minimal and keeps on reusing things till it can

Yeah, that's a good point. If this can unblock those strenuous cross-project program loads, I think the responsiveness will make up for it.

[sheetalkamat]

Ok then merging.