fix: host.isKnownTypesPackageName maybe undefined #42050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The problem is that isKnownTypesPackageName of the host is optional, but in this case it is simply mandatory. After modification, I tried it locally and it work |
edsrzf
approved these changes
Dec 19, 2020
| @@ -52,6 +52,6 @@ namespace ts.codefix { | |||
| function getTypesPackageNameToInstall(packageName: string, host: LanguageServiceHost, diagCode: number): string | undefined { | |||
| return diagCode === errorCodeCannotFindModule | |||
| ? (JsTyping.nodeCoreModules.has(packageName) ? "@types/node" : undefined) | |||
| : (host.isKnownTypesPackageName!(packageName) ? getTypesPackageName(packageName) : undefined); // TODO: GH#18217 | |||
| : (host.isKnownTypesPackageName?.(packageName) ? getTypesPackageName(packageName) : undefined); // TODO: GH#18217 | |||
There was a problem hiding this comment.
The comment referring to #18217 can be removed now since the non-null assertion is gone.
Suggested change
| : (host.isKnownTypesPackageName?.(packageName) ? getTypesPackageName(packageName) : undefined); // TODO: GH#18217 | |
| : (host.isKnownTypesPackageName?.(packageName) ? getTypesPackageName(packageName) : undefined); |
There was a problem hiding this comment.
Thanks for your suggestion. Done
chenjigeng
force-pushed
the
fix/isKnownTypesPackageName-undefined
branch
from
6c8e7b2
to
c02335e
Compare
|
@RyanCavanaugh @sandersn Could you please help CR this |
sandersn
approved these changes
Dec 30, 2020
Zzzen
pushed a commit
to Zzzen/TypeScript
that referenced
this pull request
Jan 16, 2021
* fix: host.isKnownTypesPackageName maybe undefined * feat: remove GH#18217 comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41962