Feat/quick fix for types #42126

chenjigeng · 2020-12-27T10:35:41Z

It's easy to fix the code below.

before:

declare let a: numbers;
declare let b: Numbers;
declare let c: objects;
declare let d: Objects;
declare let e: RegEx;

namespace yadda {
  export type Thing = string;
}
let f: yaddas.Thing;

after:

declare let a: Number;
declare let b: Number;
declare let c: Object;
declare let d: Object;
declare let e: RegExp;

namespace yadda {
  export type Thing = string;
}
let f: yadda.Thing;

@DanielRosenwasser please help see this

sandersn

It's impressive how much those two lines of code are doing. However, I only want to offer the codefix for the case where the did-you-mean applies and is offered. That means adding did-you-mean errors for Cannot_find_name_0 and hooking them up properly to type resolution.

chenjigeng · 2021-01-09T03:43:21Z

I think what you said is reasonable, I can have a try

…namespace_0

…st when resolve type

… feat/quick-fix-for-types

chenjigeng · 2021-01-10T09:26:05Z

It has been modified. If you are free, please help to check it @sandersn

sandersn

Sorry for the long wait. I have two suggestions:

Unconditionally issue suggestions in resolveName if errors are requested.
Make sure that string is suggested before String, as well as for the other primitive types.

I realise I dropped the ball on this, so if you don't have time or energy to finish this PR, I can take over.

sandersn · 2021-09-29T23:25:47Z

tests/cases/fourslash/codeFixSpellingCaseSensitive4.ts

+    fixId: "fixSpelling",
+    fixAllDescription: "Fix all detected spelling errors",
+    newFileContent:
+`declare let a: Number;


Strange that this doesn't correct to number after #39060. Good to look at for future work.

sandersn · 2021-09-29T23:27:23Z

tests/baselines/reference/jsdocPropertyTagInvalid.errors.txt

@@ -1,12 +1,13 @@
-/a.js(3,15): error TS2304: Cannot find name 'sting'.
+/a.js(3,15): error TS2552: Cannot find name 'sting'. Did you mean 'String'?


hmm, this also needs to suggest string not String. We might need to improve the suggestion code, perhaps with a special case for string/number/boolean/object (and any others?).

Looks like string/number/boolean/object/bigint etc are missing from the list of global suggestions.
Edit: That's because the intrinsic types are resolved via direct lookup and don't have symbols.

sandersn · 2021-09-29T23:35:50Z

src/compiler/checker.ts

@@ -3080,7 +3080,7 @@ namespace ts {
        /**
         * Resolves a qualified name and any involved aliases.
         */
-        function resolveEntityName(name: EntityNameOrEntityNameExpression, meaning: SymbolFlags, ignoreErrors?: boolean, dontResolveAlias?: boolean, location?: Node): Symbol | undefined {
+        function resolveEntityName(name: EntityNameOrEntityNameExpression, meaning: SymbolFlags, ignoreErrors?: boolean, dontResolveAlias?: boolean, location?: Node, needSuggestedNameNotFoundMessage?: boolean): Symbol | undefined {


what happens if you don't add needSuggestedNameNotFoundMessage and always request suggestions? It only makes a difference for resolveName calls that pass the combination nameNotFoundMessage = undefined and issueSuggestions = true. I'll go see if any calls like that exist.

Edit: I checked. The only new places that would issue suggestions is resolution for globals and JSX built-in symbols, only if they already request errors. This is fine. You can delete needSuggestedNameNotFoundMessage and issueSuggestions and unconditionally issue suggestions in resolveName if message is defined.

sandersn · 2021-09-29T23:37:43Z

src/compiler/checker.ts

+                        suggestedNameNotFoundMessage = Diagnostics.Cannot_find_name_0_Did_you_mean_1;
+                    }
+                }
+                symbol = getMergedSymbol(resolveName(location || name, name.escapedText, meaning, ignoreErrors || symbolFromJSPrototype ? undefined : message, name, /*isUse*/ true, false, suggestedNameNotFoundMessage));


resolveName now takes a boolean issueSuggestions instead of a message. I think it's probably fine to move your new code to choose the message inside resolveName.

sandersn · 2021-09-30T18:04:17Z

Update: I tried unconditionally suggesting errors and it works fine. I pushed the change with changed baselines to the branch always-suggest-spelling-correction

Even for types. Based on #42126, but without the namespace-specific error message.

chenjigeng · 2021-10-01T06:51:51Z

@sandersn If you have time, please help me to complete this PR, I have been busy recently

Instead of altering wrappers to look like primitives.

chenjigeng added 2 commits December 27, 2020 18:33

feat: add quick fix for types

95747c7

feat: add test case for quick fix of types

43e1efc

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Dec 27, 2020

sandersn added this to Not started in PR Backlog Jan 9, 2021

PR Backlog automation moved this from Not started to Waiting on author Jan 9, 2021

sandersn requested changes Jan 9, 2021

View reviewed changes

chenjigeng added 7 commits January 9, 2021 16:55

feat: add did-you-mean error when Cannot_find_name_0 and Cannot_find_…

5e466c4

…namespace_0

feat: add Cannot_find_namespace_0_Did_you_mean_1 error and only sugge…

07c8699

…st when resolve type

feat: update baselines

8d139eb

Merge branch 'master' of https://github.com/microsoft/TypeScript into…

c3cba22

… feat/quick-fix-for-types

feat: update baselines

3bf6db4

feat: update baselines

a5fb520

chore: fix style problem

824ddb3

sandersn moved this from Waiting on author to Needs review in PR Backlog Jan 16, 2021

sandersn requested changes Sep 29, 2021

View reviewed changes

PR Backlog automation moved this from Waiting on reviewers to Waiting on author Sep 29, 2021

sandersn added a commit that referenced this pull request Sep 30, 2021

Always suggest spelling corrections

a734b84

Even for types. Based on #42126, but without the namespace-specific error message.

sandersn added 6 commits October 1, 2021 11:48

Always suggest spelling corrections

3ea06e6

Merge branch 'main' into feat/quick-fix-for-types

f6af95c

suggest primitives instead of their wrappers

e66bdaa

Add primitives to suggestions

1382f92

Instead of altering wrappers to look like primitives.

add semicolons

799ab9b

revert unneeded change

e5be34f

sandersn approved these changes Oct 5, 2021

View reviewed changes

PR Backlog automation moved this from Waiting on author to Needs merge Oct 5, 2021

sandersn merged commit d60747f into microsoft:main Oct 5, 2021

PR Backlog automation moved this from Needs merge to Done Oct 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/quick fix for types #42126

Feat/quick fix for types #42126

chenjigeng commented Dec 27, 2020 •

edited

sandersn left a comment

chenjigeng commented Jan 9, 2021 •

edited

chenjigeng commented Jan 10, 2021

sandersn left a comment

sandersn Sep 29, 2021

sandersn Sep 29, 2021

sandersn Sep 30, 2021 •

edited

sandersn Sep 29, 2021

sandersn Sep 29, 2021

sandersn commented Sep 30, 2021 •

edited

chenjigeng commented Oct 1, 2021

		@@ -1,12 +1,13 @@
		/a.js(3,15): error TS2304: Cannot find name 'sting'.
		/a.js(3,15): error TS2552: Cannot find name 'sting'. Did you mean 'String'?

Feat/quick fix for types #42126

Feat/quick fix for types #42126

Conversation

chenjigeng commented Dec 27, 2020 • edited

sandersn left a comment

Choose a reason for hiding this comment

chenjigeng commented Jan 9, 2021 • edited

chenjigeng commented Jan 10, 2021

sandersn left a comment

Choose a reason for hiding this comment

sandersn Sep 29, 2021

Choose a reason for hiding this comment

sandersn Sep 29, 2021

Choose a reason for hiding this comment

sandersn Sep 30, 2021 • edited

Choose a reason for hiding this comment

sandersn Sep 29, 2021

Choose a reason for hiding this comment

sandersn Sep 29, 2021

Choose a reason for hiding this comment

sandersn commented Sep 30, 2021 • edited

chenjigeng commented Oct 1, 2021

chenjigeng commented Dec 27, 2020 •

edited

chenjigeng commented Jan 9, 2021 •

edited

sandersn Sep 30, 2021 •

edited

sandersn commented Sep 30, 2021 •

edited