Add undefined to Symbol.valueDeclaration #43033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm going to merge with master to avoid clashing with the declaration fix.
Also add undefined to a number of utility functions that have always accepted it, but never added it to their type.
typescript-bot
added
Author: Team
For Uncommitted Bug
| @@ -4107,7 +4107,7 @@ declare namespace ts { | |||
| function idText(identifierOrPrivateName: Identifier | PrivateIdentifier): string; | |||
| function symbolName(symbol: Symbol): string; | |||
| function getNameOfJSDocTypedef(declaration: JSDocTypedefTag): Identifier | PrivateIdentifier | undefined; | |||
| function getNameOfDeclaration(declaration: Declaration | Expression): DeclarationName | undefined; | |||
| function getNameOfDeclaration(declaration: Declaration | Expression | undefined): DeclarationName | undefined; | |||
There was a problem hiding this comment.
Not sure how I feel about changing the public API on these, but maybe it's fine.
There was a problem hiding this comment.
I think it's fine: they just make the function easier to call, and they're on functions that already return undefined or boolean, which implies (correctly) that they pass through undefined if you call them.
Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
andrewbranch
approved these changes
Mar 2, 2021
sheetalkamat
approved these changes
Mar 2, 2021
weswigham
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add undefined to a number of utility functions that have always accepted it, but never added it to their type.