Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --metadataDecorator option #43542

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add --metadataDecorator option #43542

wants to merge 2 commits into from

Conversation

rbuckton
Copy link
Member

@rbuckton rbuckton commented Apr 6, 2021

Adds two options:

  • --metadataDecorator <name> — Provides a user-defined entity name to use in place of the __metadata decorator.
    • NOTE: Requires --experimentalDecorators and --emitDecoratorMetadata.
  • --metadataDecoratorImportSource <string> — Provides the name of a package from which to import the decorator above. If not specified, the name provided to --metadataDecorator is assumed to either be global or have already been imported.
    • NOTE: Requires --experimentalDecorators, --emitDecoratorMetadata, and --metadataDecorator.

Fixes #43463

# Conflicts:
#	src/compiler/diagnosticMessages.json
@sandersn sandersn added this to Not started in PR Backlog Apr 14, 2021
@sandersn sandersn moved this from Not started to Needs review in PR Backlog Apr 16, 2021
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want this, or was our conclusion that you should just use an SES-safe tslib fork and importHelpers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
  
Waiting on reviewers
Development

Successfully merging this pull request may close these issues.

SES compatibility for '--emitDecoratorMetadata'
5 participants