Enforce keyword order between override and static/async

[andrewbranch]

The order is static override async.

Fixes #43606

[andrewbranch]

Some tests were already using override static. I have literally no opinion on this, aside from that we should enforce an order, since pretty much everything else has an order enforced.

[Kingwl]

The current check of modifier order is painful. Are there any possible to map modifiers into some priority. And we just check the order of priority value.

[andrewbranch]

I agree @Kingwl, looking at that function, it’s begging to be refactored into something more declarative. Personally I would love to see something like that implemented.

[DanielRosenwasser]

@dsherret

[DanielRosenwasser]

@nicolo-ribaudo

[nicolo-ribaudo]

Thanks for the heads up @DanielRosenwasser!

[nicolo-ribaudo]

Should there also be an order for abstract/override?

https://www.typescriptlang.org/play?ts=4.3.0-dev.20210426#code/IYIwzgLgTsDGEAJYBthjAgQmgpgYVXQQG8AoBBUSGeBAWwEYAKASgC4FqBLAOwHMA3OUrhocRHQBMrDt35CAvqVJUxtFGgwBZAJ4FNAVgQ4AHhBw8AJhmxh8hDGQoB7AG44oULpZwjq4+mZ2TmheQWFVGkQ3Dy8femlguXClIA

[andrewbranch]

Yes 🤦

[Kingwl]

🤦