Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable events on web server #45313

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Conversation

mjbvz
Copy link
Contributor

@mjbvz mjbvz commented Aug 3, 2021

Fixes #45293

Screen Shot 2021-08-03 at 2 14 36 PM

This enables syntax error reporting on the web

@typescript-bot
Copy link
Collaborator

The TypeScript team hasn't accepted the linked issue #45293. If you can get it accepted, this PR will have a better chance of being reviewed.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 3, 2021
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

If Sheetal were here, I'm sure she'd ask for a test. Having said that, I'm pretty sure this was only disabled because it seemed unnecessary. If it's easy, it might be nice to assert that there's no event port.

@mjbvz
Copy link
Contributor Author

mjbvz commented Aug 5, 2021

@amcasey Would we be able to get this in for 4.4? That would simplify life for us when building VS Code for web

@amcasey
Copy link
Member

amcasey commented Aug 5, 2021

I think getting it into 4.4 makes sense. @DanielRosenwasser, @RyanCavanaugh ?

@DanielRosenwasser DanielRosenwasser merged commit c0796c1 into microsoft:main Aug 5, 2021
BobobUnicorn pushed a commit to BobobUnicorn/TypeScript that referenced this pull request Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable syntax error reporting on web TS Server
4 participants