Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only provide hints for simple literals when 'literals' is specified. #45557

Merged
merged 2 commits into from Aug 23, 2021

Conversation

@DanielRosenwasser
Copy link
Member

@DanielRosenwasser DanielRosenwasser commented Aug 23, 2021

No description provided.

//// foo(/*d*/() => 1);
//// foo(/*e*/function () { return 1 });
//// foo(/*f*/{});
//// foo(/*g*/{ a: 1 });
//// foo(/*h*/[]);
//// foo(/*i*/[1]);
Copy link
Member Author

@DanielRosenwasser DanielRosenwasser Aug 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inlayHintsShouldWork35 covers the all case.

Loading

mjbvz
mjbvz approved these changes Aug 23, 2021
Copy link
Contributor

@mjbvz mjbvz left a comment

Thanks for the quick turn around!

Loading

@DanielRosenwasser DanielRosenwasser merged commit 59b8bef into main Aug 23, 2021
8 of 10 checks passed
Loading
@DanielRosenwasser DanielRosenwasser deleted the simpleLiteralsAreLiterals branch Aug 23, 2021
DanielRosenwasser added a commit that referenced this issue Aug 23, 2021
…45557)

* Only provide hints for simple literals when 'literals' is specified.

* Update fourslash tests.
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 4.4.2 milestone Aug 23, 2021
BobobUnicorn added a commit to BobobUnicorn/TypeScript that referenced this issue Oct 24, 2021
…icrosoft#45557)

* Only provide hints for simple literals when 'literals' is specified.

* Update fourslash tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants