Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite recursion in control flow analyzer inlining logic #45845

Merged
merged 2 commits into from Sep 13, 2021
Merged

Fix infinite recursion in control flow analyzer inlining logic #45845

merged 2 commits into from Sep 13, 2021

Conversation

ahejlsberg
Copy link
Member

Fixes #45830.

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Sep 12, 2021
@ahejlsberg
Copy link
Member Author

@DanielRosenwasser @andrewbranch If we do another 4.4 point release we should pull this one in.

@ahejlsberg ahejlsberg merged commit 5b84512 into main Sep 13, 2021
@ahejlsberg ahejlsberg deleted the fix45830 branch September 13, 2021 18:02
@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-4.4

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 13, 2021 •
edited

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.4 on this PR at e021dba. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request Sep 13, 2021
Closed
@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I've opened #45855 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Sep 13, 2021
@ahejlsberg
Cherry-pick PR microsoft#45845 into release-4.4
0074332 
Component commits:
93cac10 Move inlineLevel counter to main type checker scope

e021dba Add regression test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees

@ahejlsberg ahejlsberg

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
4 participants
@ahejlsberg @DanielRosenwasser @typescript-bot @andrewbranch