Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for type parameters on original type when getting type argument completions #46614

Merged
merged 3 commits into from Nov 1, 2021

Conversation

@DanielRosenwasser
Copy link
Member

@DanielRosenwasser DanielRosenwasser commented Nov 1, 2021

Fixes #32874

@DanielRosenwasser DanielRosenwasser merged commit 6d33d87 into main Nov 1, 2021
6 of 9 checks passed
@DanielRosenwasser DanielRosenwasser deleted the stringLiteralTypeArgCompletionFix branch Nov 1, 2021
@DanielRosenwasser
Copy link
Member Author

@DanielRosenwasser DanielRosenwasser commented Nov 3, 2021

@typescript-bot cherry-pick this to release-4.5

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Nov 3, 2021

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.5 on this PR at e7c8095. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Nov 3, 2021

Hey @DanielRosenwasser, I've opened #46675 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this issue Nov 3, 2021
Component commits:
e77514a Add failing test.

3c0d51b Check for type parameters on the original type when asking for the type argument constraint.

e7c8095 Update tests/cases/fourslash/stringLiteralTypeCompletionsInTypeArgForNonGeneric1.ts
DanielRosenwasser added a commit that referenced this issue Nov 3, 2021
Component commits:
e77514a Add failing test.

3c0d51b Check for type parameters on the original type when asking for the type argument constraint.

e7c8095 Update tests/cases/fourslash/stringLiteralTypeCompletionsInTypeArgForNonGeneric1.ts

Co-authored-by: Daniel Rosenwasser <drosen@microsoft.com>
mprobst added a commit to mprobst/TypeScript that referenced this issue Jan 10, 2022
… completions (microsoft#46614)

* Add failing test.

* Check for type parameters on the original type when asking for the type argument constraint.

* Update tests/cases/fourslash/stringLiteralTypeCompletionsInTypeArgForNonGeneric1.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants