Duplicate GDPR fragment from VS Code repo

[amcasey]

...because the tool doesn't handle cross-repro references.

Follow up to #46585.

[typescript-bot]

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary

[andrewbranch]

Should we not just remove it from VS Code then?

[amcasey]

@andrewbranch Most of the uses are there.

[andrewbranch]

I don't know enough about the system to understand why that matters.

[amcasey]

I don't know enough about the system to understand why that matters.

I'm not sure I understand your question, so I'll just answer broadly. Basically, there's an include mechanism for these GDPR comments, but you can't include something from another repo. Since both repos refer to the same fragment, both repos have to declare it.

Why have a reusable fragment for a single property? I'm pretty sure there used to be multiple and, I assume, there might be multiple in the future.

[andrewbranch]

Since both repos refer to the same fragment, both repos have to declare it.

This is what I assumed but wasn't sure of. I don't know what code patterns trigger the tooling in a way that requires the comment to be present, so I wasn't confident that both repos actually needed it. Intuitively, I would have expected that only VS Code needs any of these comments, since that's the place where this data actually gets sent to telemetry.