Properly union inferred template literal string types #46782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
ahejlsberg
requested review from
andrewbranch,
DanielRosenwasser and
RyanCavanaugh
RyanCavanaugh
approved these changes
Dec 4, 2021
weswigham
approved these changes
Dec 4, 2021
There was a problem hiding this comment.
A test for the StringMapping case also added seems relevant, but I can't even figure out how you'd use Uppercase in a nongeneric type and not have it evaporate (and thus see it in this code path), since, apparently Uppercase<`a${string}`> is `a${string}` right now (which seems like we could do better - something analogous to pattern types like `A${Uppercase<string>}` is what I'd want to see).
|
@weswigham I added a couple of additional tests that include the |
mprobst
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
* Template literals and string mappings have 'string' as base type * Add regression test * Add tests for generic template literals * One more test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46768.