Use webworker typings for webServer.ts #46944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
|
@DanielRosenwasser This is a code quality / debt issue. Should I still open an issue for it? |
|
I can't exactly tell what went wrong with the build; however, I'm going to assume it's an issue of conflicts between Node.js and the web APIs, right? |
Updates `webServer.ts` to include the webworker typings. This means we don't have to redeclare the web globals we use in this file
mjbvz
force-pushed
the
use-webworker-typings
branch
from
fc0bb73
to
d377afa
Compare
|
I think I branched off a bad commit before. Rebased and now everything looks good |
sandersn
approved these changes
Jan 29, 2022
|
Just in case, let's hold this until after 4.6 RC ships. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
webServer.tsto include the webworker typings. This means we don't have to redeclare the web globals we use in this file