Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(47296): Folding for multi-line statements when wrapped in parenthesis #47307

Merged
merged 1 commit into from
Feb 22, 2022
Merged

fix(47296): Folding for multi-line statements when wrapped in parenthesis #47307

merged 1 commit into from
Feb 22, 2022

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #47296

@sandersn sandersn added this to Not started in PR Backlog via automation Jan 31, 2022
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Feb 16, 2022
@sandersn sandersn assigned sandersn and unassigned sandersn Feb 16, 2022
@typescript-bot
Copy link
Collaborator

The TypeScript team hasn't accepted the linked issue #47296. If you can get it accepted, this PR will have a better chance of being reviewed.

@typescript-bot
Copy link
Collaborator

The TypeScript team hasn't accepted the linked issue #47296. If you can get it accepted, this PR will have a better chance of being reviewed.

2 similar comments
@typescript-bot
Copy link
Collaborator

The TypeScript team hasn't accepted the linked issue #47296. If you can get it accepted, this PR will have a better chance of being reviewed.

@typescript-bot
Copy link
Collaborator

The TypeScript team hasn't accepted the linked issue #47296. If you can get it accepted, this PR will have a better chance of being reviewed.

@sandersn
Copy link
Member

I'd prefer to have the bug approved before reviewing a PR.

@sandersn sandersn moved this from Not started to Waiting on author in PR Backlog Feb 16, 2022
@andrewbranch
Copy link
Member

I vote yes on this 👍

@gabritto
Copy link
Member

I also think we should do it, I've personally wanted this before (and now I learned it has a name)

@sandersn sandersn moved this from Waiting on author to Waiting on reviewers in PR Backlog Feb 19, 2022
andrewbranch
andrewbranch approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielRosenwasser any objections?

PR Backlog automation moved this from Waiting on reviewers to Needs merge Feb 22, 2022
@DanielRosenwasser DanielRosenwasser merged commit aa920c0 into microsoft:main Feb 22, 2022
PR Backlog automation moved this from Needs merge to Done Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

@gabritto gabritto Awaiting requested review from gabritto

Assignees

@gabritto gabritto

Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Folding for multi-line statements when wrapped in parenthesis
6 participants
@a-tarasyuk @typescript-bot @sandersn @andrewbranch @gabritto @DanielRosenwasser