Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow exports map entries to point at .ts source files #48563

Merged
merged 5 commits into from
Jun 15, 2022

Conversation

weswigham
Copy link
Member

Fixes #48369

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 4, 2022
@DanielRosenwasser
Copy link
Member

Seems like questionable functionality to be honest... I'm not sure why we would want to do this yet.

@sandersn sandersn added this to Not started in PR Backlog Apr 21, 2022
@sandersn sandersn moved this from Not started to Waiting on author in PR Backlog Apr 21, 2022
@sandersn
Copy link
Member

sandersn commented Jun 1, 2022

Is this worth taking? Will it be someday? Otherwise I'd like to close it to reduce the number of open PRs.

@weswigham
Copy link
Member Author

weswigham commented Jun 15, 2022

I snuck this into main in #47925 (input files are .ts files!), so should already be fixed in 4.7. Once the merged and up-do-date test addition comes back green, I'll merge the test.

@weswigham weswigham merged commit ccd8b1d into microsoft:main Jun 15, 2022
PR Backlog automation moved this from Waiting on author to Done Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Archived in project
PR Backlog
  
Done
Development

Successfully merging this pull request may close these issues.

Supports exports pointing to a TypeScript file, which keeps consistent with main
4 participants