Sync and bump release 4.7 to RC #49007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Some refactoring for baselining for easy update * Set modified time in baseline * Some renames per feedback
…48589) * Permit type alias variance annotations only for certain object types * Accept new baselines
* Some refactoring of baselines * Some refactoring of baselines
…bstitutions are consistently read (#48558) * Ensure late painted statements are only transformed once, so inner substitutions are consistently read * PR suggestion * Fix lint
* do not flag index signatures as a control flow container * add tests and baselines
Also baseline buildinfo so its easier to detect mistakes
* preserve this when extracting functions * rename IsThisReferringToFunction to UsesThisInFunction * refactor * update tests
LEGO: Merge pull request 48612
12 -> 14 (we have odd test errors on 12 that aren't worth debugging)
12 -> 14
Update node versions
12 -> 14
12 -> 14
…union with `undefined` (#48605) * Reuse type nodes from optional parameters and properties even when not written as a union with `undefined` * Remove newly unneeded NodeBuilderFlag * Update public API * Update baselines from main
LEGO: Merge pull request 48621
LEGO: Merge pull request 48633
…48939) * Allow type keywords with the same names as other completions * Only add type keywords that are the same as other completions in type locations
…t of an arrow function" (#48940)
* Skip ambient modules in globalThis
Previously, globalThis mistakenly included ambient modules, even though
these are not values:
```ts
declare module "ambientModule" {
export type typ = 1
export var val: typ
}
type Oops = (typeof globalThis)[\"ambientModule\"]
```
This PR adds ambient modules to the kinds of things that are skipped
when constructing `globalThis`' properties, along with block-scoped
variables.
* Skip only modules with every declaration ambient
The modules are required to have at least one declaration so that our
treatment of `globalThis` stays the same, and
`globalThis.globalThis.globalThis` remains legal.
* No error on toplevel return in JS Turns out it's only an error in modules. It's possible to keep this error on the list of "OK for JS" errors and make the checker code stop issuing it for JS scripts only. However, I don't think the error is valuable enough to do that. Fixes #48224 * Restore 'return' statement. * Update Baselines and/or Applied Lint Fixes * Re-add missing baselines * No error in toplevel script files Only issue "no top-level return" error for modules, not scripts, regardless of whether it's TS or JS. * Keep Disallowing return in ambient locations * Allow toplevel return only in non-ESM JS files * Add test of toplevel return in JS script * Revert "Add test of toplevel return in JS script" This reverts commit 2a6dec4. * Revert "Allow toplevel return only in non-ESM JS files" This reverts commit 6291ae3. * Revert "Keep Disallowing return in ambient locations" This reverts commit 714ea8e. * Revert "No error in toplevel script files" This reverts commit 2056e13. * restore orphaned baseline Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com> Co-authored-by: TypeScript Bot <typescriptbot@microsoft.com>
…47925) * Allow export map entries to remap back to input files for a program * Fix file casing issues on windows * Implement abiguity error, doesnt quite work * Refine selection logic in error case to use getCommonSourceDirectory, add more tests
* Add `Intl.Segmenter` type * Update baseline * Fix useless generics * Fix indent size * Fix `ResolvedSegmenterOptions`
* Flag resolution mode assertions in non-nightly builds * Add checker check
|
Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary |
|
This should be merged, not squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.