Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Use NonNullable<T> in more scenarios" #49381

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Revert "Use NonNullable<T> in more scenarios" #49381

wants to merge 1 commit into from

Conversation

DanielRosenwasser
Copy link
Member

Reverts #49330 as an experiment.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 3, 2022
@DanielRosenwasser
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 3, 2022 •
edited

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at ef4f419. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..49381

Metric main 49381 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 357,842k (± 0.02%) 357,764k (± 0.02%) -78k (- 0.02%) 357,606k 357,930k
Parse Time 2.07s (± 0.29%) 2.07s (± 0.66%) +0.01s (+ 0.34%) 2.05s 2.10s
Bind Time 0.86s (± 0.64%) 0.86s (± 0.69%) +0.00s (+ 0.23%) 0.85s 0.88s
Check Time 5.89s (± 0.23%) 5.83s (± 0.34%) -0.06s (- 0.99%) 5.77s 5.87s
Emit Time 6.08s (± 0.65%) 6.06s (± 0.74%) -0.02s (- 0.28%) 6.02s 6.23s
Total Time 14.90s (± 0.32%) 14.83s (± 0.46%) -0.07s (- 0.46%) 14.72s 15.08s
Compiler-Unions - node (v10.16.3, x64)
Memory used 206,443k (± 0.02%) 206,517k (± 0.35%) +74k (+ 0.04%) 205,973k 209,408k
Parse Time 0.84s (± 0.62%) 0.84s (± 0.48%) -0.00s (- 0.00%) 0.83s 0.85s
Bind Time 0.52s (± 1.12%) 0.52s (± 0.92%) 0.00s ( 0.00%) 0.51s 0.53s
Check Time 8.07s (± 0.90%) 7.89s (± 0.40%) -0.18s (- 2.19%) 7.84s 7.97s
Emit Time 2.51s (± 1.74%) 2.48s (± 1.12%) -0.03s (- 1.35%) 2.44s 2.55s
Total Time 11.93s (± 0.92%) 11.73s (± 0.44%) -0.21s (- 1.74%) 11.65s 11.84s
Monaco - node (v10.16.3, x64)
Memory used 343,865k (± 0.02%) 343,858k (± 0.02%) -7k (- 0.00%) 343,771k 344,028k
Parse Time 1.58s (± 0.76%) 1.59s (± 0.36%) +0.01s (+ 0.63%) 1.58s 1.60s
Bind Time 0.75s (± 0.66%) 0.76s (± 0.45%) +0.00s (+ 0.26%) 0.75s 0.76s
Check Time 5.87s (± 0.44%) 5.80s (± 0.48%) -0.06s (- 1.07%) 5.74s 5.86s
Emit Time 3.25s (± 0.72%) 3.24s (± 1.12%) -0.01s (- 0.22%) 3.18s 3.33s
Total Time 11.45s (± 0.32%) 11.39s (± 0.51%) -0.06s (- 0.51%) 11.25s 11.49s
TFS - node (v10.16.3, x64)
Memory used 305,526k (± 0.03%) 305,496k (± 0.02%) -31k (- 0.01%) 305,365k 305,654k
Parse Time 1.29s (± 0.40%) 1.29s (± 0.26%) +0.00s (+ 0.08%) 1.28s 1.30s
Bind Time 0.71s (± 0.51%) 0.71s (± 0.52%) +0.00s (+ 0.14%) 0.71s 0.72s
Check Time 5.33s (± 0.41%) 5.25s (± 0.59%) -0.07s (- 1.37%) 5.19s 5.32s
Emit Time 3.44s (± 0.87%) 3.45s (± 1.17%) +0.01s (+ 0.32%) 3.33s 3.51s
Total Time 10.77s (± 0.37%) 10.71s (± 0.53%) -0.06s (- 0.52%) 10.58s 10.84s
material-ui - node (v10.16.3, x64)
Memory used 469,122k (± 0.02%) 468,994k (± 0.02%) -128k (- 0.03%) 468,867k 469,212k
Parse Time 1.83s (± 0.42%) 1.83s (± 0.34%) +0.00s (+ 0.11%) 1.82s 1.84s
Bind Time 0.68s (± 0.82%) 0.68s (± 0.73%) -0.00s (- 0.29%) 0.67s 0.69s
Check Time 14.34s (± 0.32%) 14.35s (± 0.47%) +0.01s (+ 0.04%) 14.21s 14.48s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.85s (± 0.29%) 16.86s (± 0.42%) +0.01s (+ 0.04%) 16.70s 17.00s
xstate - node (v10.16.3, x64)
Memory used 573,688k (± 0.02%) 573,667k (± 0.02%) -22k (- 0.00%) 573,409k 573,937k
Parse Time 2.59s (± 0.51%) 2.60s (± 0.35%) +0.01s (+ 0.23%) 2.58s 2.62s
Bind Time 1.01s (± 1.06%) 1.01s (± 0.69%) 0.00s ( 0.00%) 1.00s 1.03s
Check Time 1.53s (± 0.51%) 1.52s (± 0.70%) -0.01s (- 0.46%) 1.51s 1.55s
Emit Time 0.07s (± 3.14%) 0.07s (± 3.14%) 0.00s ( 0.00%) 0.07s 0.08s
Total Time 5.21s (± 0.37%) 5.20s (± 0.31%) -0.00s (- 0.08%) 5.17s 5.24s
Angular - node (v12.1.0, x64)
Memory used 335,544k (± 0.03%) 335,551k (± 0.02%) +7k (+ 0.00%) 335,385k 335,713k
Parse Time 2.06s (± 0.54%) 2.08s (± 0.78%) +0.02s (+ 0.73%) 2.06s 2.12s
Bind Time 0.83s (± 0.80%) 0.83s (± 0.67%) +0.00s (+ 0.24%) 0.82s 0.85s
Check Time 5.69s (± 0.32%) 5.67s (± 0.38%) -0.03s (- 0.46%) 5.63s 5.71s
Emit Time 6.35s (± 0.87%) 6.36s (± 0.79%) +0.01s (+ 0.16%) 6.25s 6.49s
Total Time 14.93s (± 0.38%) 14.93s (± 0.34%) 0.00s ( 0.00%) 14.84s 15.04s
Compiler-Unions - node (v12.1.0, x64)
Memory used 194,111k (± 0.10%) 193,830k (± 0.03%) -281k (- 0.14%) 193,708k 193,968k
Parse Time 0.83s (± 1.04%) 0.84s (± 1.15%) +0.01s (+ 0.84%) 0.82s 0.86s
Bind Time 0.53s (± 0.89%) 0.53s (± 1.55%) +0.00s (+ 0.75%) 0.52s 0.56s
Check Time 7.49s (± 0.54%) 7.47s (± 0.72%) -0.02s (- 0.21%) 7.34s 7.63s
Emit Time 2.54s (± 1.25%) 2.52s (± 0.82%) -0.02s (- 0.87%) 2.47s 2.56s
Total Time 11.38s (± 0.53%) 11.36s (± 0.69%) -0.02s (- 0.21%) 11.16s 11.57s
Monaco - node (v12.1.0, x64)
Memory used 326,941k (± 0.02%) 326,911k (± 0.02%) -30k (- 0.01%) 326,762k 327,132k
Parse Time 1.55s (± 0.47%) 1.56s (± 0.49%) +0.00s (+ 0.26%) 1.54s 1.57s
Bind Time 0.74s (± 1.00%) 0.74s (± 0.63%) 0.00s ( 0.00%) 0.73s 0.75s
Check Time 5.69s (± 0.28%) 5.63s (± 0.53%) -0.07s (- 1.14%) 5.58s 5.71s
Emit Time 3.26s (± 0.55%) 3.27s (± 0.54%) +0.01s (+ 0.18%) 3.24s 3.32s
Total Time 11.25s (± 0.25%) 11.19s (± 0.29%) -0.06s (- 0.53%) 11.13s 11.26s
TFS - node (v12.1.0, x64)
Memory used 290,146k (± 0.03%) 290,134k (± 0.02%) -12k (- 0.00%) 290,010k 290,273k
Parse Time 1.30s (± 0.58%) 1.31s (± 0.61%) +0.01s (+ 0.93%) 1.29s 1.32s
Bind Time 0.73s (± 1.16%) 0.73s (± 0.76%) -0.00s (- 0.14%) 0.72s 0.74s
Check Time 5.29s (± 0.42%) 5.21s (± 0.55%) -0.08s (- 1.53%) 5.14s 5.28s
Emit Time 3.53s (± 0.92%) 3.56s (± 0.65%) +0.03s (+ 0.77%) 3.51s 3.61s
Total Time 10.84s (± 0.34%) 10.80s (± 0.37%) -0.05s (- 0.42%) 10.71s 10.89s
material-ui - node (v12.1.0, x64)
Memory used 447,689k (± 0.10%) 447,905k (± 0.06%) +216k (+ 0.05%) 446,877k 448,163k
Parse Time 1.84s (± 0.42%) 1.84s (± 0.66%) -0.00s (- 0.11%) 1.81s 1.87s
Bind Time 0.65s (± 0.72%) 0.65s (± 0.85%) +0.00s (+ 0.31%) 0.64s 0.67s
Check Time 13.11s (± 0.99%) 13.01s (± 0.72%) -0.10s (- 0.79%) 12.85s 13.27s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.60s (± 0.87%) 15.50s (± 0.66%) -0.10s (- 0.66%) 15.33s 15.78s
xstate - node (v12.1.0, x64)
Memory used 545,577k (± 1.75%) 548,845k (± 1.99%) +3,268k (+ 0.60%) 538,980k 571,468k
Parse Time 2.53s (± 0.50%) 2.55s (± 0.63%) +0.01s (+ 0.55%) 2.52s 2.59s
Bind Time 1.02s (± 0.69%) 1.02s (± 1.02%) -0.00s (- 0.10%) 1.00s 1.04s
Check Time 1.48s (± 0.61%) 1.48s (± 0.64%) -0.00s (- 0.27%) 1.46s 1.50s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.10s (± 0.44%) 5.11s (± 0.37%) +0.01s (+ 0.12%) 5.07s 5.17s
Angular - node (v14.15.1, x64)
Memory used 333,860k (± 0.01%) 333,793k (± 0.01%) -67k (- 0.02%) 333,716k 333,847k
Parse Time 2.04s (± 0.72%) 2.04s (± 0.41%) -0.00s (- 0.05%) 2.02s 2.06s
Bind Time 0.87s (± 0.60%) 0.87s (± 0.42%) -0.00s (- 0.35%) 0.86s 0.87s
Check Time 5.70s (± 0.37%) 5.66s (± 0.52%) -0.04s (- 0.70%) 5.61s 5.73s
Emit Time 6.38s (± 0.74%) 6.37s (± 0.65%) -0.01s (- 0.22%) 6.31s 6.49s
Total Time 14.99s (± 0.52%) 14.94s (± 0.44%) -0.06s (- 0.38%) 14.83s 15.14s
Compiler-Unions - node (v14.15.1, x64)
Memory used 193,054k (± 0.37%) 192,861k (± 0.38%) -193k (- 0.10%) 192,435k 195,845k
Parse Time 0.85s (± 0.66%) 0.85s (± 0.56%) +0.00s (+ 0.59%) 0.85s 0.87s
Bind Time 0.56s (± 0.72%) 0.57s (± 0.84%) +0.01s (+ 1.43%) 0.56s 0.58s
Check Time 7.61s (± 0.60%) 7.53s (± 0.63%) -0.08s (- 1.01%) 7.43s 7.65s
Emit Time 2.51s (± 0.77%) 2.51s (± 0.40%) -0.01s (- 0.24%) 2.49s 2.53s
Total Time 11.53s (± 0.51%) 11.45s (± 0.50%) -0.07s (- 0.62%) 11.33s 11.59s
Monaco - node (v14.15.1, x64)
Memory used 325,710k (± 0.01%) 325,661k (± 0.00%) -49k (- 0.02%) 325,637k 325,684k
Parse Time 1.57s (± 0.75%) 1.58s (± 0.74%) +0.01s (+ 0.51%) 1.55s 1.60s
Bind Time 0.77s (± 0.44%) 0.78s (± 0.86%) +0.00s (+ 0.52%) 0.77s 0.80s
Check Time 5.58s (± 0.29%) 5.54s (± 0.61%) -0.04s (- 0.70%) 5.45s 5.61s
Emit Time 3.34s (± 0.53%) 3.34s (± 0.95%) -0.00s (- 0.06%) 3.28s 3.43s
Total Time 11.27s (± 0.19%) 11.24s (± 0.53%) -0.03s (- 0.24%) 11.07s 11.38s
TFS - node (v14.15.1, x64)
Memory used 289,136k (± 0.01%) 289,130k (± 0.01%) -6k (- 0.00%) 289,098k 289,176k
Parse Time 1.36s (± 0.86%) 1.37s (± 1.35%) +0.01s (+ 1.03%) 1.35s 1.43s
Bind Time 0.72s (± 1.01%) 0.73s (± 1.57%) +0.01s (+ 0.83%) 0.71s 0.77s
Check Time 5.27s (± 0.41%) 5.20s (± 0.47%) -0.06s (- 1.20%) 5.15s 5.26s
Emit Time 3.56s (± 2.34%) 3.54s (± 2.13%) -0.02s (- 0.70%) 3.41s 3.68s
Total Time 10.91s (± 0.75%) 10.84s (± 0.75%) -0.07s (- 0.61%) 10.68s 11.00s
material-ui - node (v14.15.1, x64)
Memory used 446,358k (± 0.00%) 446,297k (± 0.01%) -61k (- 0.01%) 446,223k 446,346k
Parse Time 1.87s (± 0.36%) 1.88s (± 0.72%) +0.01s (+ 0.64%) 1.85s 1.90s
Bind Time 0.69s (± 0.71%) 0.70s (± 0.83%) +0.00s (+ 0.43%) 0.69s 0.71s
Check Time 13.11s (± 0.51%) 13.11s (± 0.58%) +0.00s (+ 0.00%) 12.93s 13.23s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.67s (± 0.42%) 15.69s (± 0.56%) +0.02s (+ 0.12%) 15.51s 15.85s
xstate - node (v14.15.1, x64)
Memory used 536,963k (± 0.01%) 536,995k (± 0.00%) +32k (+ 0.01%) 536,964k 537,030k
Parse Time 2.57s (± 0.50%) 2.59s (± 0.57%) +0.01s (+ 0.54%) 2.56s 2.62s
Bind Time 1.14s (± 1.09%) 1.15s (± 0.72%) +0.01s (+ 0.79%) 1.13s 1.17s
Check Time 1.52s (± 0.39%) 1.53s (± 0.54%) +0.00s (+ 0.13%) 1.51s 1.55s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.31s (± 0.22%) 5.33s (± 0.31%) +0.02s (+ 0.38%) 5.31s 5.38s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v10.16.3, x64)
  • xstate - node (v12.1.0, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 49381 10
Baseline main 10

Developer Information:

Download Benchmark

@DanielRosenwasser
Copy link
Member Author

@typescript-bot perf test faster

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 3, 2022 •
edited

Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at ef4f419. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..49381

Metric main 49381 Delta Best Worst
Angular - node (v14.15.1, x64)
Memory used 333,860k (± 0.01%) 333,804k (± 0.01%) -56k (- 0.02%) 333,743k 333,842k
Parse Time 2.04s (± 0.72%) 2.04s (± 0.32%) -0.00s (- 0.20%) 2.02s 2.05s
Bind Time 0.87s (± 0.60%) 0.87s (± 0.57%) -0.00s (- 0.35%) 0.86s 0.88s
Check Time 5.70s (± 0.37%) 5.64s (± 0.46%) -0.06s (- 1.07%) 5.58s 5.70s
Emit Time 6.38s (± 0.74%) 6.40s (± 0.71%) +0.01s (+ 0.19%) 6.33s 6.53s
Total Time 14.99s (± 0.52%) 14.93s (± 0.43%) -0.06s (- 0.39%) 14.82s 15.09s
Compiler-Unions - node (v14.15.1, x64)
Memory used 193,054k (± 0.37%) 192,420k (± 0.13%) -634k (- 0.33%) 191,444k 192,587k
Parse Time 0.85s (± 0.66%) 0.84s (± 0.59%) -0.00s (- 0.35%) 0.84s 0.86s
Bind Time 0.56s (± 0.72%) 0.56s (± 0.99%) +0.00s (+ 0.54%) 0.55s 0.57s
Check Time 7.61s (± 0.60%) 7.58s (± 0.76%) -0.03s (- 0.41%) 7.45s 7.68s
Emit Time 2.51s (± 0.77%) 2.54s (± 1.33%) +0.03s (+ 1.07%) 2.49s 2.66s
Total Time 11.53s (± 0.51%) 11.52s (± 0.56%) -0.00s (- 0.01%) 11.39s 11.64s
Monaco - node (v14.15.1, x64)
Memory used 325,710k (± 0.01%) 325,659k (± 0.00%) -51k (- 0.02%) 325,635k 325,693k
Parse Time 1.57s (± 0.75%) 1.58s (± 0.57%) +0.00s (+ 0.25%) 1.56s 1.60s
Bind Time 0.77s (± 0.44%) 0.77s (± 0.52%) -0.00s (- 0.52%) 0.76s 0.78s
Check Time 5.58s (± 0.29%) 5.52s (± 0.31%) -0.06s (- 1.09%) 5.48s 5.56s
Emit Time 3.34s (± 0.53%) 3.34s (± 1.03%) -0.00s (- 0.09%) 3.30s 3.46s
Total Time 11.27s (± 0.19%) 11.20s (± 0.37%) -0.06s (- 0.56%) 11.11s 11.33s
TFS - node (v14.15.1, x64)
Memory used 289,136k (± 0.01%) 289,119k (± 0.01%) -18k (- 0.01%) 289,059k 289,165k
Parse Time 1.36s (± 0.86%) 1.35s (± 1.13%) -0.01s (- 0.66%) 1.31s 1.38s
Bind Time 0.72s (± 1.01%) 0.72s (± 0.72%) -0.00s (- 0.14%) 0.71s 0.74s
Check Time 5.27s (± 0.41%) 5.20s (± 0.48%) -0.07s (- 1.33%) 5.15s 5.24s
Emit Time 3.56s (± 2.34%) 3.54s (± 2.27%) -0.02s (- 0.65%) 3.41s 3.68s
Total Time 10.91s (± 0.75%) 10.81s (± 0.82%) -0.10s (- 0.93%) 10.66s 11.00s
material-ui - node (v14.15.1, x64)
Memory used 446,358k (± 0.00%) 446,288k (± 0.01%) -70k (- 0.02%) 446,249k 446,339k
Parse Time 1.87s (± 0.36%) 1.88s (± 0.79%) +0.01s (+ 0.75%) 1.85s 1.93s
Bind Time 0.69s (± 0.71%) 0.70s (± 0.64%) +0.00s (+ 0.58%) 0.69s 0.71s
Check Time 13.11s (± 0.51%) 13.14s (± 0.45%) +0.03s (+ 0.23%) 13.02s 13.30s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.67s (± 0.42%) 15.72s (± 0.42%) +0.05s (+ 0.32%) 15.57s 15.87s
xstate - node (v14.15.1, x64)
Memory used 536,963k (± 0.01%) 536,993k (± 0.01%) +30k (+ 0.01%) 536,851k 537,046k
Parse Time 2.57s (± 0.50%) 2.59s (± 0.59%) +0.01s (+ 0.51%) 2.56s 2.63s
Bind Time 1.14s (± 1.09%) 1.14s (± 0.72%) +0.01s (+ 0.62%) 1.13s 1.17s
Check Time 1.52s (± 0.39%) 1.53s (± 0.54%) +0.00s (+ 0.13%) 1.51s 1.55s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.31s (± 0.22%) 5.33s (± 0.50%) +0.02s (+ 0.40%) 5.30s 5.42s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 49381 10
Baseline main 10

Developer Information:

Download Benchmark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@DanielRosenwasser DanielRosenwasser

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DanielRosenwasser @typescript-bot