Add path completions for package.json exports with wildcards #49644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
andrewbranch
commented
Jun 22, 2022
weswigham
requested changes
Jun 27, 2022
src/services/stringCompletions.ts
Outdated
| return arrayFrom(result.values()); | ||
| } | ||
|
|
||
| function getPatternFromFirstMatchingCondition(target: unknown, conditions: readonly string[]): [string] | undefined { |
There was a problem hiding this comment.
Doesn't this need changes to support fetching pattern results from nested conditions?
There was a problem hiding this comment.
Indeed, I forgot about this. Updated, thanks 👍
|
@typescript-bot run dt Checking whether I fixed the conflicting eslint configs in on-demand DT |
|
@typescript-bot run dt Second attempt to fix the conflicting eslint configs. |
|
@typescript-bot run dt Third attempt to fix the conflicting eslint configs. |
weswigham
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48652
Builds on the work done in #49154