Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The error "Object is possibly null or undefined" is ambiguous. #49797

Merged
merged 14 commits into from Sep 15, 2022
Merged

The error "Object is possibly null or undefined" is ambiguous. #49797

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f7d0f12
added object name to TS2571, 2531, 2532 and 2533
norech Jul 5, 2022
738cf09
updated localized diagnostic messages
norech Jul 5, 2022
2e7018f
updated baseline to fit diagnostic message change
norech Jul 5, 2022
cb371bd
Merge branch 'microsoft:main' into norech/issue_8274
norech Jul 6, 2022
30149f1
Revert "updated localized diagnostic messages"
norech Jul 28, 2022
7b299f2
specialized the error to EntityNameExpression
norech Jul 28, 2022
071e221
updated baseline to fit new changes
norech Jul 28, 2022
973f9ef
added multiline undefined access test
norech Sep 1, 2022
cbfc493
added TS18049 - value cannot be used here
norech Sep 1, 2022
47123ed
adjusted baseline
norech Sep 1, 2022
4e55075
corrected a small linting issue
norech Sep 1, 2022
318544f
Merge branch 'main' into norech/issue_8274
norech Sep 15, 2022
f1d0696
Merge branch 'main' into norech/issue_8274
sandersn Sep 15, 2022
e1ab8f4
Update error numbers after merge from main
sandersn Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 26 additions & 0 deletions src/compiler/checker.ts
View file
Open in desktop
Expand Up @@ -28948,6 +28948,18 @@ m2: ${(this.mapper2 as unknown as DebugTypeMapper).__debugToString().split("\n")
}

function reportObjectPossiblyNullOrUndefinedError(node: Node, facts: TypeFacts) {
if (isEntityNameExpression(node)) {
const nodeText = entityNameToString(node);
norech marked this conversation as resolved.
Show resolved Hide resolved
if (nodeText.length < 100) {
error(node, facts & TypeFacts.IsUndefined ? facts & TypeFacts.IsNull ?
Diagnostics._0_is_possibly_null_or_undefined :
Diagnostics._0_is_possibly_undefined :
Diagnostics._0_is_possibly_null,
nodeText
);
return;
}
}
error(node, facts & TypeFacts.IsUndefined ? facts & TypeFacts.IsNull ?
Diagnostics.Object_is_possibly_null_or_undefined :
Diagnostics.Object_is_possibly_undefined :
Expand All @@ -28969,6 +28981,13 @@ m2: ${(this.mapper2 as unknown as DebugTypeMapper).__debugToString().split("\n")
reportError: (node: Node, facts: TypeFacts) => void
): Type {
if (strictNullChecks && type.flags & TypeFlags.Unknown) {
if (isEntityNameExpression(node)) {
const nodeText = entityNameToString(node);
if (nodeText.length < 100) {
error(node, Diagnostics._0_is_of_type_unknown, nodeText);
return errorType;
}
}
error(node, Diagnostics.Object_is_of_type_unknown);
return errorType;
}
Expand All @@ -28988,6 +29007,13 @@ m2: ${(this.mapper2 as unknown as DebugTypeMapper).__debugToString().split("\n")
function checkNonNullNonVoidType(type: Type, node: Node): Type {
const nonNullType = checkNonNullType(type, node);
if (nonNullType.flags & TypeFlags.Void) {
if (isEntityNameExpression(node)) {
const nodeText = entityNameToString(node);
if (nodeText.length < 100) {
error(node, Diagnostics._0_is_possibly_undefined, nodeText);
return nonNullType;
}
}
error(node, Diagnostics.Object_is_possibly_undefined);
}
return nonNullType;
Expand Down
16 changes: 16 additions & 0 deletions src/compiler/diagnosticMessages.json
View file
Open in desktop
Expand Up @@ -7421,5 +7421,21 @@
"'{0}' is automatically exported here.": {
"category": "Message",
"code": 18044
},
"'{0}' is of type 'unknown'.": {
"category": "Error",
"code": 18045
},
"'{0}' is possibly 'null'.": {
"category": "Error",
"code": 18046
},
"'{0}' is possibly 'undefined'.": {
"category": "Error",
"code": 18047
},
"'{0}' is possibly 'null' or 'undefined'.": {
"category": "Error",
"code": 18048
}
}
160 changes: 80 additions & 80 deletions tests/baselines/reference/arithmeticOperatorWithOnlyNullValueOrUndefinedValue.errors.txt
View file
Open in desktop

Large diffs are not rendered by default.

480 changes: 240 additions & 240 deletions tests/baselines/reference/arithmeticOperatorWithUndefinedValueAndInvalidOperands.errors.txt
View file
Open in desktop

Large diffs are not rendered by default.

320 changes: 160 additions & 160 deletions tests/baselines/reference/arithmeticOperatorWithUndefinedValueAndValidOperands.errors.txt
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions tests/baselines/reference/binaryArithmatic2.errors.txt
View file
Open in desktop
@@ -1,7 +1,7 @@
tests/cases/compiler/binaryArithmatic2.ts(1,13): error TS2532: Object is possibly 'undefined'.
tests/cases/compiler/binaryArithmatic2.ts(1,13): error TS18047: 'undefined' is possibly 'undefined'.
norech marked this conversation as resolved.
Show resolved Hide resolved


==== tests/cases/compiler/binaryArithmatic2.ts (1 errors) ====
var v = 4 | undefined;
~~~~~~~~~
!!! error TS2532: Object is possibly 'undefined'.
!!! error TS18047: 'undefined' is possibly 'undefined'.
8 changes: 4 additions & 4 deletions tests/baselines/reference/binaryArithmatic3.errors.txt
View file
Open in desktop
@@ -1,10 +1,10 @@
tests/cases/compiler/binaryArithmatic3.ts(1,9): error TS2532: Object is possibly 'undefined'.
tests/cases/compiler/binaryArithmatic3.ts(1,21): error TS2532: Object is possibly 'undefined'.
tests/cases/compiler/binaryArithmatic3.ts(1,9): error TS18047: 'undefined' is possibly 'undefined'.
tests/cases/compiler/binaryArithmatic3.ts(1,21): error TS18047: 'undefined' is possibly 'undefined'.


==== tests/cases/compiler/binaryArithmatic3.ts (2 errors) ====
var v = undefined | undefined;
~~~~~~~~~
!!! error TS2532: Object is possibly 'undefined'.
!!! error TS18047: 'undefined' is possibly 'undefined'.
~~~~~~~~~
!!! error TS2532: Object is possibly 'undefined'.
!!! error TS18047: 'undefined' is possibly 'undefined'.
4 changes: 2 additions & 2 deletions tests/baselines/reference/bitwiseNotOperatorWithAnyOtherType.errors.txt
View file
Open in desktop
@@ -1,4 +1,4 @@
tests/cases/conformance/expressions/unaryOperators/bitwiseNotOperator/bitwiseNotOperatorWithAnyOtherType.ts(34,24): error TS2532: Object is possibly 'undefined'.
tests/cases/conformance/expressions/unaryOperators/bitwiseNotOperator/bitwiseNotOperatorWithAnyOtherType.ts(34,24): error TS18047: 'undefined' is possibly 'undefined'.
tests/cases/conformance/expressions/unaryOperators/bitwiseNotOperator/bitwiseNotOperatorWithAnyOtherType.ts(35,24): error TS2531: Object is possibly 'null'.
tests/cases/conformance/expressions/unaryOperators/bitwiseNotOperator/bitwiseNotOperatorWithAnyOtherType.ts(46,26): error TS2365: Operator '+' cannot be applied to types 'null' and 'undefined'.
tests/cases/conformance/expressions/unaryOperators/bitwiseNotOperator/bitwiseNotOperatorWithAnyOtherType.ts(47,26): error TS2365: Operator '+' cannot be applied to types 'null' and 'null'.
Expand Down Expand Up @@ -41,7 +41,7 @@ tests/cases/conformance/expressions/unaryOperators/bitwiseNotOperator/bitwiseNot
// any type literal
var ResultIsNumber6 = ~undefined;
~~~~~~~~~
!!! error TS2532: Object is possibly 'undefined'.
!!! error TS18047: 'undefined' is possibly 'undefined'.
var ResultIsNumber7 = ~null;
~~~~
!!! error TS2531: Object is possibly 'null'.
Expand Down
4 changes: 2 additions & 2 deletions tests/baselines/reference/circularOptionalityRemoval.errors.txt
View file
Open in desktop
@@ -1,6 +1,6 @@
tests/cases/compiler/circularOptionalityRemoval.ts(2,14): error TS2502: 'x' is referenced directly or indirectly in its own type annotation.
tests/cases/compiler/circularOptionalityRemoval.ts(2,38): error TS2372: Parameter 'x' cannot reference itself.
tests/cases/compiler/circularOptionalityRemoval.ts(2,38): error TS2532: Object is possibly 'undefined'.
tests/cases/compiler/circularOptionalityRemoval.ts(2,38): error TS18047: 'x' is possibly 'undefined'.
tests/cases/compiler/circularOptionalityRemoval.ts(2,46): error TS2372: Parameter 'x' cannot reference itself.
tests/cases/compiler/circularOptionalityRemoval.ts(5,14): error TS1015: Parameter cannot have question mark and initializer.
tests/cases/compiler/circularOptionalityRemoval.ts(5,14): error TS2502: 'x' is referenced directly or indirectly in its own type annotation.
Expand All @@ -16,7 +16,7 @@ tests/cases/compiler/circularOptionalityRemoval.ts(5,54): error TS2372: Paramete
~
!!! error TS2372: Parameter 'x' cannot reference itself.
~
!!! error TS2532: Object is possibly 'undefined'.
!!! error TS18047: 'x' is possibly 'undefined'.
~
!!! error TS2372: Parameter 'x' cannot reference itself.

Expand Down
32 changes: 16 additions & 16 deletions tests/baselines/reference/comparisonOperatorWithIdenticalPrimitiveType.errors.txt
View file
Open in desktop
@@ -1,19 +1,19 @@
tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithIdenticalPrimitiveType.ts(15,11): error TS2531: Object is possibly 'null'.
tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithIdenticalPrimitiveType.ts(15,18): error TS2531: Object is possibly 'null'.
tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithIdenticalPrimitiveType.ts(16,11): error TS2532: Object is possibly 'undefined'.
tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithIdenticalPrimitiveType.ts(16,23): error TS2532: Object is possibly 'undefined'.
tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithIdenticalPrimitiveType.ts(16,11): error TS18047: 'undefined' is possibly 'undefined'.
tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithIdenticalPrimitiveType.ts(16,23): error TS18047: 'undefined' is possibly 'undefined'.
tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithIdenticalPrimitiveType.ts(24,11): error TS2531: Object is possibly 'null'.
tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithIdenticalPrimitiveType.ts(24,18): error TS2531: Object is possibly 'null'.
tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithIdenticalPrimitiveType.ts(25,11): error TS2532: Object is possibly 'undefined'.
tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithIdenticalPrimitiveType.ts(25,23): error TS2532: Object is possibly 'undefined'.
tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithIdenticalPrimitiveType.ts(25,11): error TS18047: 'undefined' is possibly 'undefined'.
tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithIdenticalPrimitiveType.ts(25,23): error TS18047: 'undefined' is possibly 'undefined'.
tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithIdenticalPrimitiveType.ts(33,11): error TS2531: Object is possibly 'null'.
tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithIdenticalPrimitiveType.ts(33,19): error TS2531: Object is possibly 'null'.
tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithIdenticalPrimitiveType.ts(34,11): error TS2532: Object is possibly 'undefined'.
tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithIdenticalPrimitiveType.ts(34,24): error TS2532: Object is possibly 'undefined'.
tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithIdenticalPrimitiveType.ts(34,11): error TS18047: 'undefined' is possibly 'undefined'.
tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithIdenticalPrimitiveType.ts(34,24): error TS18047: 'undefined' is possibly 'undefined'.
tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithIdenticalPrimitiveType.ts(42,11): error TS2531: Object is possibly 'null'.
tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithIdenticalPrimitiveType.ts(42,19): error TS2531: Object is possibly 'null'.
tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithIdenticalPrimitiveType.ts(43,11): error TS2532: Object is possibly 'undefined'.
tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithIdenticalPrimitiveType.ts(43,24): error TS2532: Object is possibly 'undefined'.
tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithIdenticalPrimitiveType.ts(43,11): error TS18047: 'undefined' is possibly 'undefined'.
tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithIdenticalPrimitiveType.ts(43,24): error TS18047: 'undefined' is possibly 'undefined'.


==== tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithIdenticalPrimitiveType.ts (16 errors) ====
Expand All @@ -38,9 +38,9 @@ tests/cases/conformance/expressions/binaryOperators/comparisonOperator/compariso
!!! error TS2531: Object is possibly 'null'.
var ra7 = undefined < undefined;
~~~~~~~~~
!!! error TS2532: Object is possibly 'undefined'.
!!! error TS18047: 'undefined' is possibly 'undefined'.
~~~~~~~~~
!!! error TS2532: Object is possibly 'undefined'.
!!! error TS18047: 'undefined' is possibly 'undefined'.

// operator >
var rb1 = a > a;
Expand All @@ -55,9 +55,9 @@ tests/cases/conformance/expressions/binaryOperators/comparisonOperator/compariso
!!! error TS2531: Object is possibly 'null'.
var rb7 = undefined > undefined;
~~~~~~~~~
!!! error TS2532: Object is possibly 'undefined'.
!!! error TS18047: 'undefined' is possibly 'undefined'.
~~~~~~~~~
!!! error TS2532: Object is possibly 'undefined'.
!!! error TS18047: 'undefined' is possibly 'undefined'.

// operator <=
var rc1 = a <= a;
Expand All @@ -72,9 +72,9 @@ tests/cases/conformance/expressions/binaryOperators/comparisonOperator/compariso
!!! error TS2531: Object is possibly 'null'.
var rc7 = undefined <= undefined;
~~~~~~~~~
!!! error TS2532: Object is possibly 'undefined'.
!!! error TS18047: 'undefined' is possibly 'undefined'.
~~~~~~~~~
!!! error TS2532: Object is possibly 'undefined'.
!!! error TS18047: 'undefined' is possibly 'undefined'.

// operator >=
var rd1 = a >= a;
Expand All @@ -89,9 +89,9 @@ tests/cases/conformance/expressions/binaryOperators/comparisonOperator/compariso
!!! error TS2531: Object is possibly 'null'.
var rd7 = undefined >= undefined;
~~~~~~~~~
!!! error TS2532: Object is possibly 'undefined'.
!!! error TS18047: 'undefined' is possibly 'undefined'.
~~~~~~~~~
!!! error TS2532: Object is possibly 'undefined'.
!!! error TS18047: 'undefined' is possibly 'undefined'.

// operator ==
var re1 = a == a;
Expand Down
12 changes: 6 additions & 6 deletions tests/baselines/reference/compoundArithmeticAssignmentLHSCanBeAssigned.errors.txt
View file
Open in desktop
@@ -1,9 +1,9 @@
tests/cases/conformance/expressions/assignmentOperator/compoundArithmeticAssignmentLHSCanBeAssigned.ts(11,7): error TS2531: Object is possibly 'null'.
tests/cases/conformance/expressions/assignmentOperator/compoundArithmeticAssignmentLHSCanBeAssigned.ts(12,7): error TS2532: Object is possibly 'undefined'.
tests/cases/conformance/expressions/assignmentOperator/compoundArithmeticAssignmentLHSCanBeAssigned.ts(12,7): error TS18047: 'undefined' is possibly 'undefined'.
tests/cases/conformance/expressions/assignmentOperator/compoundArithmeticAssignmentLHSCanBeAssigned.ts(18,7): error TS2531: Object is possibly 'null'.
tests/cases/conformance/expressions/assignmentOperator/compoundArithmeticAssignmentLHSCanBeAssigned.ts(19,7): error TS2532: Object is possibly 'undefined'.
tests/cases/conformance/expressions/assignmentOperator/compoundArithmeticAssignmentLHSCanBeAssigned.ts(19,7): error TS18047: 'undefined' is possibly 'undefined'.
tests/cases/conformance/expressions/assignmentOperator/compoundArithmeticAssignmentLHSCanBeAssigned.ts(25,7): error TS2531: Object is possibly 'null'.
tests/cases/conformance/expressions/assignmentOperator/compoundArithmeticAssignmentLHSCanBeAssigned.ts(26,7): error TS2532: Object is possibly 'undefined'.
tests/cases/conformance/expressions/assignmentOperator/compoundArithmeticAssignmentLHSCanBeAssigned.ts(26,7): error TS18047: 'undefined' is possibly 'undefined'.


==== tests/cases/conformance/expressions/assignmentOperator/compoundArithmeticAssignmentLHSCanBeAssigned.ts (6 errors) ====
Expand All @@ -22,7 +22,7 @@ tests/cases/conformance/expressions/assignmentOperator/compoundArithmeticAssignm
!!! error TS2531: Object is possibly 'null'.
x1 *= undefined;
~~~~~~~~~
!!! error TS2532: Object is possibly 'undefined'.
!!! error TS18047: 'undefined' is possibly 'undefined'.

var x2: number;
x2 *= a;
Expand All @@ -33,7 +33,7 @@ tests/cases/conformance/expressions/assignmentOperator/compoundArithmeticAssignm
!!! error TS2531: Object is possibly 'null'.
x2 *= undefined;
~~~~~~~~~
!!! error TS2532: Object is possibly 'undefined'.
!!! error TS18047: 'undefined' is possibly 'undefined'.

var x3: E;
x3 *= a;
Expand All @@ -44,4 +44,4 @@ tests/cases/conformance/expressions/assignmentOperator/compoundArithmeticAssignm
!!! error TS2531: Object is possibly 'null'.
x3 *= undefined;
~~~~~~~~~
!!! error TS2532: Object is possibly 'undefined'.
!!! error TS18047: 'undefined' is possibly 'undefined'.