Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol.species should on constructor, not instance #50167

Closed
wants to merge 14 commits into from

Conversation

LongTengDao
Copy link
Contributor

@LongTengDao LongTengDao commented Aug 3, 2022

Fixes #50168

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 3, 2022
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

readonly [Symbol.toStringTag]: "SharedArrayBuffer";
}

interface SharedArrayBufferConstructor {
readonly prototype: SharedArrayBuffer;
new (byteLength: number): SharedArrayBuffer;
readonly [Symbol.species]: SharedArrayBuffer;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this also be SharedArrayBufferConstructor?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielRosenwasser Oh... Thank you!

@typescript-bot typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Aug 12, 2022
@sandersn sandersn added this to Not started in PR Backlog Aug 17, 2022
@sandersn sandersn moved this from Not started to Waiting on reviewers in PR Backlog Aug 17, 2022
PR Backlog automation moved this from Waiting on reviewers to Needs merge Aug 17, 2022
Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opening this up and Node.js and trying it at the console, I think this looks right.

Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you need to accept the baselines so tests pass first.

PR Backlog automation moved this from Needs merge to Waiting on author Aug 18, 2022
@LongTengDao
Copy link
Contributor Author

@DanielRosenwasser Thank you! I merged latest main from this repo, there is still error. Maybe I mistake your words "accept the baselines"? (I saw the error output has word "baseline" in the path, maybe "baseline" means other thing in this project?)

@jakebailey
Copy link
Member

See: https://github.com/microsoft/TypeScript/blob/main/CONTRIBUTING.md#managing-the-baselines

@LongTengDao
Copy link
Contributor Author

After study, I think I can't handle the error information above, sorry!

@jakebailey
Copy link
Member

jakebailey commented Aug 24, 2022

If you're not sure what to do, all that needs to be done is to run npx gulp baseline-accept, then commit the changed files.

@sandersn
Copy link
Member

sandersn commented Mar 9, 2023

Do you want to keep working on this? Otherwise I'd like to close it to reduce the number of open PRs.

@LongTengDao
Copy link
Contributor Author

Do you want to keep working on this? Otherwise I'd like to close it to reduce the number of open PRs.

Sorry, I can't...

PR Backlog automation moved this from Waiting on author to Done Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
  
Done
Development

Successfully merging this pull request may close these issues.

Symbol.species should in constructor, not instance
5 participants