Disable JS size limit by default #50202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VS and VS Code both ship 64-bit node at this point, so the JS size limit seems artificial now.
typescript-bot
added
Author: Team
For Uncommitted Bug
|
@DanielRosenwasser pointed out that this might mask some configuration errors, but I think we can use better heuristics than total JS size to detect those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that VS and VS Code both ship with 64-bit node, it seems a little arbitrary.
You can still enable it with
disableSizeLimit: falsebut it's not obvious why someone would want to do that explicitly. We kept the option mostly so that specifying it wouldn't be an error.