Elide line:col info in "!!! related" errors when from default lib.d.ts files #52330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
jakebailey
commented
Jan 20, 2023
|
The error diffs on #52328 are already pretty small. But long-term this is a good idea. |
|
Yeah, I expected them to be huge and I thought my browser was just lagging when I clicked on it... nope, it was actually that short! |
sheetalkamat
approved these changes
Jan 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted on #52317 (comment), this PR removes line:col information from the
!!! relatedlines in our error baseline when the relation info comes from a default lib file.Any time our libs are changed, loads of baselines change because position info differs; these "related" errors are the source of the bulk of them.
There are still a few baselines leftover that I'm not fixing in this PR; there are only 5 such examples in our repo, 4 of which are errors in tests with
@skipDefaultLibCheck: false, the other being a tag in a completion baseline that links to a position in a lib file.