New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infer type parameters only from applicable contextual types #52622
Conversation
I failed the self-check without failing the test suite for the second time. 🍻 for the life achievements |
@typescript-bot test this |
Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 1583f7c. You can monitor the build here. Update: The results are in! |
Heya @jakebailey, I've started to run the extended test suite on this PR at 1583f7c. You can monitor the build here. |
Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 1583f7c. You can monitor the build here. Update: The results are in! |
Heya @jakebailey, I've started to run the diff-based user code test suite (tsserver) on this PR at 1583f7c. You can monitor the build here. Update: The results are in! |
Heya @jakebailey, I've started to run the perf test suite on this PR at 1583f7c. You can monitor the build here. Update: The results are in! |
Heya @jakebailey, I've started to run the diff-based top-repos suite (tsserver) on this PR at 1583f7c. You can monitor the build here. Update: The results are in! |
Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 1583f7c. You can monitor the build here. |
@jakebailey Here are the results of running the user test suite comparing Something interesting changed - please have a look. Details
|
@jakebailey Here are the results of running the user test suite comparing Everything looks good! |
Heya @jakebailey, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here. |
@jakebailey Here are the results of running the top-repos suite comparing Everything looks good! |
@jakebailey Here they are:
CompilerComparison Report - main..52622
System
Hosts
Scenarios
TSServerComparison Report - main..52622
System
Hosts
Scenarios
StartupComparison Report - main..52622
System
Hosts
Scenarios
Developer Information: |
@jakebailey Here are the results of running the top-repos suite comparing Something interesting changed - please have a look. Details
|
Check time performance and baselines don't seem to look good, unfortunately. |
@jakebailey I've pushed out a change - there is something funky in its 2 baseline changes but for now, I'd like to just learn its perf characteristics. Would you mind re-running the perf test suite? |
@typescript-bot perf test this |
Heya @jakebailey, I've started to run the perf test suite on this PR at e244365. You can monitor the build here. Update: The results are in! |
@jakebailey Here they are:
CompilerComparison Report - main..52622
System
Hosts
Scenarios
TSServerComparison Report - main..52622
System
Hosts
Scenarios
StartupComparison Report - main..52622
System
Hosts
Scenarios
Developer Information: |
fixes #50719