Skip parsing JSDoc when not needed #52921

jakebailey · 2023-02-22T21:48:43Z

This is #52466 plus more changes, since I think we want to try and get this in for 5.0 if possible.

~~Needs a test, which we can achieve thanks to the compilerOptions use here.~~

For #52959

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>

jakebailey · 2023-02-22T21:49:16Z

@typescript-bot perf test this

typescript-bot · 2023-02-22T21:49:17Z

Heya @jakebailey, I've started to run the perf test suite on this PR at 131a170. You can monitor the build here.

jakebailey · 2023-02-22T22:17:26Z

This PR is still wrong, fixing but I have to run.

jakebailey · 2023-02-22T23:04:49Z

@typescript-bot perf test this faster

typescript-bot · 2023-02-22T23:04:52Z

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at 3af4435. You can monitor the build here.

Update: The results are in!

src/harness/fakesHosts.ts

jakebailey · 2023-02-22T23:14:12Z

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot pack this

typescript-bot · 2023-02-22T23:14:15Z

Heya @jakebailey, I've started to run the diff-based top-repos suite (tsserver) on this PR at 3af4435. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-02-22T23:14:15Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 3af4435. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-02-22T23:14:15Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 3af4435. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-02-22T23:14:15Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 3af4435. You can monitor the build here.

typescript-bot · 2023-02-22T23:14:15Z

Heya @jakebailey, I've started to run the extended test suite on this PR at 3af4435. You can monitor the build here.

typescript-bot · 2023-02-22T23:14:15Z

Heya @jakebailey, I've started to run the diff-based user code test suite (tsserver) on this PR at 3af4435. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-02-22T23:16:20Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/147249/artifacts?artifactName=tgz&fileId=77F313F5F22E76C89FEA5F5A963AEF8EB942DE8EF20F507A82129360DDE8992502&fileName=/typescript-5.0.0-insiders.20230222.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.0.0-pr-52921-12".;

src/compiler/scanner.ts

typescript-bot · 2023-02-22T23:21:28Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..52921

_Metric	_main	₅₂₉₂₁	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{358,876k (± 0.00%)}	_{350,121k (± 0.01%)}	_{-8,755k (- 2.44%)}	_350,091k	_350,151k	_{p=0.005 n=6}
_{Parse Time}	_{3.72s (± 0.53%)}	_{3.38s (± 0.85%)}	_{🟩-0.34s (- 9.09%)}	_3.33s	_3.41s	_{p=0.005 n=6}
_{Bind Time}	_{1.19s (± 0.92%)}	_{1.17s (± 0.47%)}	_{-0.01s (- 1.26%)}	_1.17s	_1.18s	_{p=0.015 n=6}
_{Check Time}	_{9.46s (± 0.33%)}	_{9.38s (± 0.24%)}	_{-0.07s (- 0.76%)}	_9.36s	_9.41s	_{p=0.008 n=6}
_{Emit Time}	_{7.94s (± 0.97%)}	_{8.17s (± 0.59%)}	_{+0.23s (+ 2.85%)}	_8.11s	_8.24s	_{p=0.005 n=6}
_{Total Time}	_{22.32s (± 0.43%)}	_{22.12s (± 0.38%)}	_{-0.20s (- 0.90%)}	_21.99s	_22.20s	_{p=0.006 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{191,955k (± 0.71%)}	_{189,912k (± 0.75%)}	_{-2,043k (- 1.06%)}	_189,271k	_192,834k	_{p=0.045 n=6}
_{Parse Time}	_{1.57s (± 0.87%)}	_{1.45s (± 1.43%)}	_{🟩-0.13s (- 8.05%)}	_1.41s	_1.47s	_{p=0.005 n=6}
_{Bind Time}	_{0.82s (± 0.50%)}	_{0.83s (± 0.62%)}	_{+0.01s (+ 1.02%)}	_0.82s	_0.83s	_{p=0.022 n=6}
_{Check Time}	_{10.11s (± 0.27%)}	_{9.96s (± 0.80%)}	_{-0.15s (- 1.47%)}	_9.91s	_10.12s	_{p=0.029 n=6}
_{Emit Time}	_{3.00s (± 1.01%)}	_{3.06s (± 1.32%)}	_{+0.06s (+ 1.83%)}	_3.01s	_3.12s	_{p=0.030 n=6}
_{Total Time}	_{15.50s (± 0.34%)}	_{15.29s (± 0.54%)}	_{-0.21s (- 1.37%)}	_15.20s	_15.44s	_{p=0.008 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{343,080k (± 0.00%)}	_{341,785k (± 0.00%)}	_{-1,295k (- 0.38%)}	_341,765k	_341,799k	_{p=0.005 n=6}
_{Parse Time}	_{2.80s (± 0.32%)}	_{2.73s (± 0.78%)}	_{-0.07s (- 2.56%)}	_2.70s	_2.75s	_{p=0.005 n=6}
_{Bind Time}	_{1.08s (± 0.50%)}	_{1.09s (± 1.26%)}	_~	_1.08s	_1.12s	_{p=0.138 n=6}
_{Check Time}	_{7.70s (± 0.42%)}	_{7.64s (± 0.51%)}	_{-0.07s (- 0.87%)}	_7.60s	_7.70s	_{p=0.030 n=6}
_{Emit Time}	_{4.44s (± 0.63%)}	_{4.46s (± 1.13%)}	_~	_4.43s	_4.56s	_{p=0.570 n=6}
_{Total Time}	_{16.02s (± 0.32%)}	_{15.92s (± 0.57%)}	_~	_15.86s	_16.10s	_{p=0.064 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,214k (± 0.01%)}	_{299,300k (± 0.01%)}	_{+86k (+ 0.03%)}	_299,284k	_299,323k	_{p=0.005 n=6}
_{Parse Time}	_{2.18s (± 0.69%)}	_{2.18s (± 0.37%)}	_~	_2.17s	_2.19s	_{p=0.498 n=6}
_{Bind Time}	_{1.23s (± 1.22%)}	_{0.98s (± 0.64%)}	_{🟩-0.25s (-20.54%)}	_0.97s	_0.99s	_{p=0.004 n=6}
_{Check Time}	_{7.18s (± 0.53%)}	_{7.48s (± 0.37%)}	_{+0.30s (+ 4.18%)}	_7.45s	_7.51s	_{p=0.005 n=6}
_{Emit Time}	_{4.37s (± 0.77%)}	_{4.33s (± 0.78%)}	_~	_4.28s	_4.37s	_{p=0.124 n=6}
_{Total Time}	_{14.96s (± 0.41%)}	_{14.97s (± 0.21%)}	_~	_14.94s	_15.02s	_{p=0.936 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{475,754k (± 0.01%)}	_{467,805k (± 0.01%)}	_{-7,949k (- 1.67%)}	_467,751k	_467,847k	_{p=0.005 n=6}
_{Parse Time}	_{3.33s (± 0.41%)}	_{2.89s (± 0.72%)}	_{🟩-0.45s (-13.45%)}	_2.86s	_2.91s	_{p=0.005 n=6}
_{Bind Time}	_{0.96s (± 0.42%)}	_{1.11s (± 0.88%)}	_{+0.15s (+15.60%)}	_1.10s	_1.13s	_{p=0.003 n=6}
_{Check Time}	_{18.14s (± 0.83%)}	_{18.10s (± 1.01%)}	_~	_17.92s	_18.44s	_{p=0.521 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.44s (± 0.61%)}	_{22.10s (± 0.84%)}	_{-0.34s (- 1.53%)}	_21.93s	_22.45s	_{p=0.031 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{545,746k (± 0.02%)}	_{518,091k (± 0.03%)}	_{🟩-27,655k (- 5.07%)}	_517,983k	_518,345k	_{p=0.005 n=6}
_{Parse Time}	_{4.25s (± 0.33%)}	_{3.77s (± 0.34%)}	_{🟩-0.48s (-11.29%)}	_3.75s	_3.78s	_{p=0.005 n=6}
_{Bind Time}	_{1.74s (± 0.43%)}	_{1.66s (± 0.45%)}	_{🟩-0.08s (- 4.78%)}	_1.65s	_1.67s	_{p=0.004 n=6}
_{Check Time}	_{3.00s (± 0.54%)}	_{3.19s (± 0.26%)}	_{+0.20s (+ 6.62%)}	_3.18s	_3.20s	_{p=0.004 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{9.08s (± 0.31%)}	_{8.71s (± 0.20%)}	_{🟩-0.37s (- 4.02%)}	_8.69s	_8.74s	_{p=0.005 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₉₂₁	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-02-22T23:25:23Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/52921/merge:

Something interesting changed - please have a look.

Details

webpack

tsconfig.json

[NEW] error TS2339: Property 'stage' does not exist on type 'Module'.
- lib/ChunkGraph.js#L1231

tsconfig.types.json

[NEW] error TS2339: Property 'stage' does not exist on type 'Module'.
- lib/ChunkGraph.js#L1231
[NEW] error TS7006: Parameter 'module' implicitly has an 'any' type.
- lib/ChunkGraph.js#L1712
- lib/ModuleGraph.js#L811
[NEW] error TS7006: Parameter 'chunk' implicitly has an 'any' type.
- lib/ChunkGraph.js#L1762
[NEW] error TS7006: Parameter 'options' implicitly has an 'any' type.
- lib/MainTemplate.js#L279
[NEW] error TS2345: Argument of type 'null' is not assignable to parameter of type 'Error | undefined'.
- lib/schemes/HttpUriPlugin.js#L428
- lib/schemes/HttpUriPlugin.js#L439
[MISSING] error TS2345: Argument of type 'Comparator<RuntimeModule>' is not assignable to parameter of type 'Comparator<Module>'.
- lib/ChunkGraph.js#L1226
[MISSING] error TS2322: Type 'number | undefined' is not assignable to type 'string | number'.
- lib/ChunkGraph.js#L1231
[MISSING] error TS2322: Type 'string | number | null' is not assignable to type 'string | number'.
- lib/Compilation.js#L388
[MISSING] error TS2322: Type 'string | undefined' is not assignable to type 'string'.
- lib/Compilation.js#L398
- lib/Compilation.js#L405
[MISSING] error TS2345: Argument of type '(callback: (arg0: (Error | null) | undefined, arg1: Lockfile | undefined) => void) => void' is not assignable to parameter of type '(arg0: (arg0?: Error | undefined, arg1?: Lockfile | undefined) => void) => void'.
- lib/schemes/HttpUriPlugin.js#L405
[MISSING] error TS18048: 'lockfile' is possibly 'undefined'.
- lib/schemes/HttpUriPlugin.js#L773

typescript-bot · 2023-02-22T23:31:20Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/52921/merge:

Something interesting changed - please have a look.

Details

webpack

⚠️ Note that built had errors ⚠️

Req #2032 - completionEntryDetails
    at Object.getImportCompletionAction (/typescript-main/built/local/tsserver.js:141638:11)
    at getCompletionEntryCodeActionsAndSourceDisplay (/typescript-main/built/local/tsserver.js:149781:62)
    at Object.getCompletionEntryDetails (/typescript-main/built/local/tsserver.js:149666:46)
    at Object.getCompletionEntryDetails2 [as getCompletionEntryDetails] (/typescript-main/built/local/tsserver.js:135555:35)
    at /typescript-main/built/local/tsserver.js:179168:43
    at mapDefined (/typescript-main/built/local/tsserver.js:2627:22)
    at IOSession.getCompletionEntryDetails (/typescript-main/built/local/tsserver.js:179166:20)
    at completionEntryDetails (/typescript-main/built/local/tsserver.js:177512:43)
    at /typescript-main/built/local/tsserver.js:179856:69
    at IOSession.executeWithRequestId (/typescript-main/built/local/tsserver.js:179848:14)
    at IOSession.executeCommand (/typescript-main/built/local/tsserver.js:179856:29)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:179898:51)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:181442:14)

🎉 New server no longer has errors 🎉

jakebailey · 2023-02-22T23:41:18Z

Um, hm. Those errors are interesting because they imply that I'm still doing something wrong here.

src/compiler/watchPublic.ts

src/compiler/parser.ts

jakebailey · 2023-09-13T20:29:55Z

@fisker @sosukesuzuki you might be interested in this one. I'm not sure if prettier or typescript-estree actually use the .jsdoc properties / JSDoc nodes, but if they don't, then this should result in a significant speedup on files that contain JSDoc so long as this new parser option is plumbed.

Actually, thinking about it, external users may not even need @see or @link; would it make sense to modify this API such that it's possible to say "I don't care about JSDoc at all" and just enable semantic JSDoc tags inside of tsc?

(It's kinda now or never, given the PR currently has a boolean which explicitly calls out semantic JSDoc tags.)

jakebailey · 2023-09-13T20:38:52Z

In fact, one may not even need the tags at all even outside of TS files, e.g. formatting JS files...

jakebailey · 2023-09-13T22:02:32Z

Actually to start, I'm just going to make this API internal as-is (because we want this in tsc now), and then send a follow-up change for comment to make this more configurable.

jakebailey · 2023-09-13T22:12:26Z

@typescript-bot perf test this faster
@typescript-bot perf test this bun

typescript-bot · 2023-09-13T22:12:28Z

Heya @jakebailey, I've started to run the tsc-only perf test suite on this PR at b287a9f. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-13T22:12:28Z

Heya @jakebailey, I've started to run the bun perf test suite on this PR at b287a9f. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-13T22:27:22Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{300,543k (± 0.01%)}	_{294,074k (± 0.01%)}	_{-6,469k (- 2.15%)}	_294,052k	_294,101k	_{p=0.005 n=6}
_{Parse Time}	_{3.01s (± 0.18%)}	_{2.83s (± 0.14%)}	_{🟩-0.18s (- 5.88%)}	_2.82s	_2.83s	_{p=0.003 n=6}
_{Bind Time}	_{0.93s (± 0.00%)}	_{0.92s (± 0.60%)}	_{-0.02s (- 1.61%)}	_0.91s	_0.92s	_{p=0.002 n=6}
_{Check Time}	_{9.35s (± 0.21%)}	_{9.27s (± 0.38%)}	_{-0.09s (- 0.93%)}	_9.21s	_9.30s	_{p=0.005 n=6}
_{Emit Time}	_{7.63s (± 0.30%)}	_{7.44s (± 0.29%)}	_{-0.19s (- 2.53%)}	_7.41s	_7.47s	_{p=0.005 n=6}
_{Total Time}	_{20.92s (± 0.18%)}	_{20.44s (± 0.22%)}	_{-0.48s (- 2.29%)}	_20.38s	_20.50s	_{p=0.005 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{194,625k (± 0.53%)}	_{192,285k (± 0.02%)}	_{-2,341k (- 1.20%)}	_192,231k	_192,315k	_{p=0.005 n=6}
_{Parse Time}	_{1.58s (± 0.00%)}	_{1.46s (± 0.00%)}	_{🟩-0.12s (- 7.59%)}	_1.46s	_1.46s	_{p=0.001 n=6}
_{Bind Time}	_{0.79s (± 0.65%)}	_{0.79s (± 0.00%)}	_~	_0.79s	_0.79s	_{p=0.174 n=6}
_{Check Time}	_{9.95s (± 0.35%)}	_{9.88s (± 0.39%)}	_{-0.07s (- 0.70%)}	_9.80s	_9.90s	_{p=0.007 n=6}
_{Emit Time}	_{2.74s (± 0.19%)}	_{2.75s (± 0.37%)}	_{+0.02s (+ 0.61%)}	_2.74s	_2.77s	_{p=0.009 n=6}
_{Total Time}	_{15.06s (± 0.22%)}	_{14.89s (± 0.33%)}	_{-0.17s (- 1.16%)}	_14.79s	_14.92s	_{p=0.005 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{347,291k (± 0.01%)}	_{346,369k (± 0.00%)}	_{-922k (- 0.27%)}	_346,353k	_346,375k	_{p=0.005 n=6}
_{Parse Time}	_{2.69s (± 0.15%)}	_{2.64s (± 0.39%)}	_{-0.04s (- 1.67%)}	_2.63s	_2.66s	_{p=0.003 n=6}
_{Bind Time}	_{0.99s (± 0.00%)}	_{0.99s (± 0.00%)}	_~	_0.99s	_0.99s	_{p=1.000 n=6}
_{Check Time}	_{7.96s (± 0.23%)}	_{7.89s (± 0.28%)}	_{-0.08s (- 0.96%)}	_7.86s	_7.92s	_{p=0.005 n=6}
_{Emit Time}	_{4.25s (± 0.25%)}	_{4.27s (± 0.28%)}	_~	_4.25s	_4.28s	_{p=0.138 n=6}
_{Total Time}	_{15.90s (± 0.17%)}	_{15.79s (± 0.19%)}	_{-0.11s (- 0.66%)}	_15.74s	_15.82s	_{p=0.005 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{301,404k (± 0.01%)}	_{301,621k (± 0.00%)}	_{+217k (+ 0.07%)}	_301,614k	_301,626k	_{p=0.005 n=6}
_{Parse Time}	_{2.17s (± 0.82%)}	_{2.16s (± 1.12%)}	_~	_2.13s	_2.20s	_{p=0.220 n=6}
_{Bind Time}	_{1.12s (± 1.35%)}	_{0.90s (± 0.57%)}	_{🟩-0.21s (-19.10%)}	_0.90s	_0.91s	_{p=0.004 n=6}
_{Check Time}	_{7.23s (± 0.33%)}	_{7.45s (± 0.28%)}	_{+0.22s (+ 3.09%)}	_7.43s	_7.48s	_{p=0.005 n=6}
_{Emit Time}	_{3.98s (± 0.26%)}	_{3.96s (± 0.14%)}	_{-0.02s (- 0.46%)}	_3.96s	_3.97s	_{p=0.008 n=6}
_{Total Time}	_{14.50s (± 0.27%)}	_{14.47s (± 0.15%)}	_~	_14.45s	_14.50s	_{p=0.294 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{479,884k (± 0.00%)}	_{469,676k (± 0.01%)}	_{-10,208k (- 2.13%)}	_469,560k	_469,737k	_{p=0.005 n=6}
_{Parse Time}	_{3.15s (± 0.20%)}	_{2.76s (± 0.15%)}	_{🟩-0.39s (-12.33%)}	_2.76s	_2.77s	_{p=0.003 n=6}
_{Bind Time}	_{0.91s (± 0.00%)}	_{1.05s (± 0.49%)}	_{+0.14s (+15.75%)}	_1.05s	_1.06s	_{p=0.002 n=6}
_{Check Time}	_{17.85s (± 0.35%)}	_{17.80s (± 0.25%)}	_~	_17.76s	_17.87s	_{p=0.128 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.90s (± 0.27%)}	_{21.61s (± 0.24%)}	_{-0.29s (- 1.32%)}	_21.57s	_21.70s	_{p=0.005 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{542,865k (± 0.01%)}	_{509,327k (± 0.02%)}	_{🟩-33,538k (- 6.18%)}	_509,239k	_509,478k	_{p=0.005 n=6}
_{Parse Time}	_{3.69s (± 0.23%)}	_{3.39s (± 0.15%)}	_{🟩-0.29s (- 7.91%)}	_3.39s	_3.40s	_{p=0.004 n=6}
_{Bind Time}	_{1.46s (± 0.28%)}	_{1.64s (± 0.00%)}	_{+0.18s (+12.20%)}	_1.64s	_1.64s	_{p=0.002 n=6}
_{Check Time}	_{3.17s (± 0.37%)}	_{3.14s (± 0.52%)}	_{-0.02s (- 0.74%)}	_3.13s	_3.17s	_{p=0.035 n=6}
_{Emit Time}	_{0.08s (± 6.19%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=0.174 n=6}
_{Total Time}	_{8.39s (± 0.14%)}	_{8.27s (± 0.20%)}	_{-0.12s (- 1.47%)}	_8.25s	_8.29s	_{p=0.005 n=6}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-09-13T22:57:02Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - bun (v1.0.0, x64)}
_{Memory used}	_{321,868k (± 0.11%)}	_{316,799k (± 0.17%)}	_{-5,069k (- 1.57%)}	_315,340k	_318,366k	_{p=0.000 n=12}
_{Parse Time}	_{2.34s (± 0.52%)}	_{2.30s (± 0.39%)}	_{-0.03s (- 1.39%)}	_2.28s	_2.33s	_{p=0.000 n=12}
_{Bind Time}	_{0.91s (± 1.59%)}	_{0.90s (± 2.18%)}	_~	_0.83s	_0.95s	_{p=0.747 n=12}
_{Check Time}	_{8.09s (± 0.50%)}	_{7.96s (± 0.34%)}	_{-0.13s (- 1.62%)}	_7.89s	_8.04s	_{p=0.000 n=12}
_{Emit Time}	_{6.42s (± 0.52%)}	_{6.40s (± 0.28%)}	_~	_6.36s	_6.47s	_{p=0.295 n=12}
_{Total Time}	_{17.76s (± 0.28%)}	_{17.57s (± 0.26%)}	_{-0.19s (- 1.08%)}	_17.49s	_17.73s	_{p=0.000 n=12}
_{Compiler-Unions - bun (v1.0.0, x64)}
_{Memory used}	_{255,023k (± 0.31%)}	_{245,488k (± 1.01%)}	_{🟩-9,535k (- 3.74%)}	_236,221k	_248,298k	_{p=0.000 n=12}
_{Parse Time}	_{1.25s (± 0.40%)}	_{1.13s (± 1.31%)}	_{🟩-0.13s (-10.16%)}	_1.11s	_1.19s	_{p=0.000 n=12}
_{Bind Time}	_{0.84s (± 1.17%)}	_{0.83s (± 0.96%)}	_~	_0.81s	_0.85s	_{p=0.082 n=12}
_{Check Time}	_{8.92s (± 0.44%)}	_{8.79s (± 0.33%)}	_{-0.13s (- 1.46%)}	_8.72s	_8.89s	_{p=0.000 n=12}
_{Emit Time}	_{2.81s (± 0.55%)}	_{2.79s (± 0.79%)}	_~	_2.75s	_2.87s	_{p=0.307 n=12}
_{Total Time}	_{13.82s (± 0.31%)}	_{13.55s (± 0.29%)}	_{-0.27s (- 1.99%)}	_13.46s	_13.63s	_{p=0.000 n=12}
_{Monaco - bun (v1.0.0, x64)}
_{Memory used}	_{369,676k (± 0.09%)}	_{378,830k (± 0.18%)}	_{+9,153k (+ 2.48%)}	_376,910k	_379,942k	_{p=0.000 n=12}
_{Parse Time}	_{2.04s (± 0.20%)}	_{1.98s (± 0.77%)}	_{🟩-0.06s (- 3.14%)}	_1.95s	_2.02s	_{p=0.000 n=12}
_{Bind Time}	_{1.10s (± 0.98%)}	_{0.96s (± 2.05%)}	_{🟩-0.14s (-12.50%)}	_0.90s	_1.01s	_{p=0.000 n=12}
_{Check Time}	_{7.20s (± 0.25%)}	_{7.39s (± 0.32%)}	_{+0.19s (+ 2.66%)}	_7.31s	_7.43s	_{p=0.000 n=12}
_{Emit Time}	_{3.73s (± 0.50%)}	_{3.73s (± 0.49%)}	_~	_3.69s	_3.78s	_{p=0.953 n=12}
_{Total Time}	_{14.07s (± 0.20%)}	_{14.06s (± 0.22%)}	_~	_13.97s	_14.13s	_{p=0.562 n=12}
_{TFS - bun (v1.0.0, x64)}
_{Memory used}	_{317,716k (± 0.19%)}	_{317,316k (± 0.18%)}	_~	_315,395k	_318,424k	_{p=0.470 n=12}
_{Parse Time}	_{1.79s (± 0.45%)}	_{1.76s (± 0.85%)}	_{-0.03s (- 1.63%)}	_1.73s	_1.81s	_{p=0.004 n=12}
_{Bind Time}	_{0.99s (± 2.03%)}	_{1.00s (± 1.15%)}	_~	_0.98s	_1.03s	_{p=0.229 n=12}
_{Check Time}	_{6.62s (± 0.37%)}	_{6.60s (± 0.27%)}	_~	_6.55s	_6.65s	_{p=0.338 n=12}
_{Emit Time}	_{3.45s (± 0.52%)}	_{3.46s (± 0.67%)}	_~	_3.41s	_3.54s	_{p=0.384 n=12}
_{Total Time}	_{12.85s (± 0.30%)}	_{12.83s (± 0.26%)}	_~	_12.75s	_12.91s	_{p=0.524 n=12}
_{material-ui - bun (v1.0.0, x64)}
_{Memory used}	_{531,912k (± 0.36%)}	_{492,259k (± 2.05%)}	_{🟩-39,653k (- 7.45%)}	_475,278k	_511,028k	_{p=0.000 n=12}
_{Parse Time}	_{2.49s (± 0.44%)}	_{2.24s (± 0.24%)}	_{🟩-0.25s (-10.17%)}	_2.23s	_2.25s	_{p=0.000 n=12}
_{Bind Time}	_{0.71s (± 0.59%)}	_{0.74s (± 3.20%)}	_~	_0.69s	_0.79s	_{p=0.402 n=12}
_{Check Time}	_{15.86s (± 0.35%)}	_{15.76s (± 0.38%)}	_{-0.10s (- 0.63%)}	_15.57s	_15.89s	_{p=0.026 n=12}
_{Emit Time}	_{0.00s (±217.90%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=0.359 n=12}
_{Total Time}	_{19.07s (± 0.30%)}	_{18.75s (± 0.29%)}	_{-0.33s (- 1.72%)}	_18.58s	_18.90s	_{p=0.000 n=12}
_{xstate - bun (v1.0.0, x64)}
_{Memory used}	_{489,211k (± 4.78%)}	_{410,056k (± 5.97%)}	_{🟩-79,155k (-16.18%)}	_380,851k	_464,238k	_{p=0.001 n=12}
_{Parse Time}	_{3.61s (± 0.47%)}	_{3.25s (± 0.26%)}	_{🟩-0.36s (-10.08%)}	_3.24s	_3.28s	_{p=0.000 n=12}
_{Bind Time}	_{1.39s (± 0.81%)}	_{1.26s (± 0.86%)}	_{🟩-0.13s (- 9.24%)}	_1.22s	_1.28s	_{p=0.000 n=12}
_{Check Time}	_{3.57s (± 0.54%)}	_{3.59s (± 0.20%)}	_~	_3.57s	_3.61s	_{p=0.066 n=12}
_{Emit Time}	_{0.22s (± 5.59%)}	_{0.21s (± 2.29%)}	_{🟩-0.01s (- 5.68%)}	_0.20s	_0.22s	_{p=0.044 n=12}
_{Total Time}	_{8.79s (± 0.22%)}	_{8.32s (± 0.23%)}	_{🟩-0.48s (- 5.43%)}	_8.26s	_8.37s	_{p=0.000 n=12}

System info unknown

Hosts

bun (v1.0.0, x64)

Scenarios

Angular - bun (v1.0.0, x64)
Compiler-Unions - bun (v1.0.0, x64)
Monaco - bun (v1.0.0, x64)
TFS - bun (v1.0.0, x64)
material-ui - bun (v1.0.0, x64)
xstate - bun (v1.0.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₁₂
_Baseline	_baseline	₁₂

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - bun (v1.0.0, x64)}
_{Execution time}	_{428.94ms (± 0.09%)}	_{428.70ms (± 0.08%)}	_{-0.24ms (- 0.06%)}	_427.55ms	_436.45ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - bun (v1.0.0, x64)}
_{Execution time}	_{666.67ms (± 0.14%)}	_{665.13ms (± 0.15%)}	_{-1.54ms (- 0.23%)}	_663.29ms	_683.23ms	_{p=0.000 n=600}
_{typescript-startup - bun (v1.0.0, x64)}
_{Execution time}	_{667.75ms (± 0.13%)}	_{665.86ms (± 0.12%)}	_{-1.88ms (- 0.28%)}	_664.00ms	_679.75ms	_{p=0.000 n=600}

System info unknown

Hosts

bun (v1.0.0, x64)

Scenarios

tsc-startup - bun (v1.0.0, x64)
tsserverlibrary-startup - bun (v1.0.0, x64)
typescript-startup - bun (v1.0.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey · 2023-09-13T23:03:59Z

Follow-up is #55739.

bradzacher · 2023-09-13T23:16:44Z

would it make sense to modify this API such that it's possible to say "I don't care about JSDoc at all"

Yes. TS-ESTree does not use the JSDoc property at all - we do absolutely no touching of JSDoc. We do touch the comment contents so we can transform the AST node, but that is just via the source code text.

I don't believe any part of our ecosystem touches JSDoc - as we've seen even the JSDoc plugin doesn't as it uses its own separate JSDoc parser.

We'd see pretty decent wins across the ecosystem by being able to completely skip the JSDoc parsing!

jakebailey · 2023-09-13T23:20:52Z

I think my main concern is that people will want to read out the .jsDoc properties by asking typescript-eslint for the original AST nodes (e.g. #55139), and then find that the info was never populated, or similar. I also wanted to try and make .jsDoc lazy and only create it when accessed (since we have the text anyway), but since JSDoc is bound by the binder, you can't really do that.

But #55739 is probably a better place to keep talking about the bulk hammer of letting people disable it.

fisker · 2023-09-14T01:22:31Z

I'm not sure if prettier or typescript-estree actually use the .jsdoc properties / JSDoc nodes

Prettier uses the AST provied by @typescript-eslint/parser, since bradzacher already answered that TS-ESTree does not use the JSDoc property at all, so Prettier doesn't need it either.

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com> Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>

jakebailey and others added 3 commits February 22, 2023 12:02

Pull in most of Nathan's change with tweaks

481a7dd

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>

Move to the scanner

170042c

And ending

131a170

typescript-bot assigned jakebailey Feb 22, 2023

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Feb 22, 2023

Get tests working

3af4435

jakebailey commented Feb 22, 2023

View reviewed changes

src/harness/fakesHosts.ts Outdated Show resolved Hide resolved

Remove commented out code

ed54d9f

jakebailey commented Feb 22, 2023

View reviewed changes

src/compiler/scanner.ts Outdated Show resolved Hide resolved

jakebailey added 2 commits February 22, 2023 15:41

Amend test

85b29d7

Don't use regex

6930f47

jakebailey force-pushed the skip-jsdoc branch from f99893e to 6930f47 Compare February 22, 2023 23:41

jakebailey requested review from DanielRosenwasser and andrewbranch September 13, 2023 02:04

sheetalkamat approved these changes Sep 13, 2023

View reviewed changes

andrewbranch reviewed Sep 13, 2023

View reviewed changes

src/compiler/watchPublic.ts Outdated Show resolved Hide resolved

src/compiler/parser.ts Outdated Show resolved Hide resolved

Rename flag to skipNonSemanticJSDoc and skipNonSemanticJSDocParsing

1d38012

sandersn approved these changes Sep 13, 2023

View reviewed changes

andrewbranch approved these changes Sep 13, 2023

View reviewed changes

jakebailey changed the title ~~Skip parsing JSDoc in .ts files~~ Skip parsing JSDoc in .ts files when not needed by caller Sep 13, 2023

jakebailey changed the title ~~Skip parsing JSDoc in .ts files when not needed by caller~~ Skip parsing JSDoc when not needed Sep 13, 2023

Remove new option from public API for now

b287a9f

sheetalkamat approved these changes Sep 13, 2023

View reviewed changes

jakebailey merged commit c0b39c6 into microsoft:main Sep 13, 2023
19 checks passed

jakebailey deleted the skip-jsdoc branch September 13, 2023 22:58

jakebailey mentioned this pull request Sep 13, 2023

Make JSDoc skipping public, plus more configurable #55739

Merged

jakebailey mentioned this pull request Sep 13, 2023

Investigate making JSDoc parsing lazier and more optimal #52959

Closed

DanielRosenwasser mentioned this pull request Sep 15, 2023

Design Meeting Notes, 9/15/2023 #55754

Closed

snovader pushed a commit to mestro-se/TypeScript that referenced this pull request Sep 23, 2023

Skip parsing JSDoc when not needed (microsoft#52921)

64d643d

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com> Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>

Kit-p mentioned this pull request Oct 24, 2023

Upgrade typescript dependency version xenova/transformers.js#368

Merged

Skip parsing JSDoc when not needed #52921

Skip parsing JSDoc when not needed #52921

Conversation

jakebailey commented Feb 22, 2023 • edited

jakebailey commented Feb 22, 2023

typescript-bot commented Feb 22, 2023 • edited

jakebailey commented Feb 22, 2023

jakebailey commented Feb 22, 2023

typescript-bot commented Feb 22, 2023 • edited

jakebailey commented Feb 22, 2023

typescript-bot commented Feb 22, 2023 • edited

typescript-bot commented Feb 22, 2023 • edited

typescript-bot commented Feb 22, 2023 • edited

typescript-bot commented Feb 22, 2023 • edited

typescript-bot commented Feb 22, 2023 • edited

typescript-bot commented Feb 22, 2023 • edited

typescript-bot commented Feb 22, 2023 • edited

typescript-bot commented Feb 22, 2023

typescript-bot commented Feb 22, 2023

webpack

tsconfig.json

tsconfig.types.json

typescript-bot commented Feb 22, 2023

webpack

jakebailey commented Feb 22, 2023

jakebailey commented Sep 13, 2023 • edited

jakebailey commented Sep 13, 2023

jakebailey commented Sep 13, 2023 • edited

jakebailey commented Sep 13, 2023

typescript-bot commented Sep 13, 2023 • edited

typescript-bot commented Sep 13, 2023 • edited

typescript-bot commented Sep 13, 2023

Compiler

typescript-bot commented Sep 13, 2023

Compiler

Startup

jakebailey commented Sep 13, 2023

bradzacher commented Sep 13, 2023

jakebailey commented Sep 13, 2023

fisker commented Sep 14, 2023

jakebailey commented Feb 22, 2023 •

edited

typescript-bot commented Feb 22, 2023 •

edited

typescript-bot commented Feb 22, 2023 •

edited

typescript-bot commented Feb 22, 2023 •

edited

typescript-bot commented Feb 22, 2023 •

edited

typescript-bot commented Feb 22, 2023 •

edited

typescript-bot commented Feb 22, 2023 •

edited

typescript-bot commented Feb 22, 2023 •

edited

typescript-bot commented Feb 22, 2023 •

edited

typescript-bot commented Feb 22, 2023 •

edited

jakebailey commented Sep 13, 2023 •

edited

jakebailey commented Sep 13, 2023 •

edited

typescript-bot commented Sep 13, 2023 •

edited

typescript-bot commented Sep 13, 2023 •

edited