New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade glob to v8 to fix build #53015
Conversation
@@ -69,7 +69,7 @@ | |||
"eslint-plugin-simple-import-sort": "^10.0.0", | |||
"fast-xml-parser": "^4.0.11", | |||
"fs-extra": "^9.1.0", | |||
"glob": "latest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! ❤️ I was once traveling through the git history back and I wasn't able to build the old commit because this wasn't pinned.
You still have a couple of other dependencies that are not pinned so this could still happen in the future with any of them. What do you think about pinning all of them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'll probably do this. I already send PRs to update deps in the repo when something major is released so I'm not concerned about not moving forward.
That being said, the bisect script I use (which I'll post when I'm not replying on my phone...) detects when something like this is broken and can skip the commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the script I use with git bisect run
:
#!/bin/zsh
COMMAND=gulp
if [ -f Herebyfile.mjs ]; then
COMMAND=hereby
fi
# Make sure that tests are going to run at all
$COMMAND runtests -t "notarealtest" --no-typecheck --no-lint &> /dev/null || npm ci &> /dev/null
$COMMAND runtests -t "notarealtest" --no-typecheck --no-lint &> /dev/null || exit 125
$COMMAND runtests -t "testme" --no-lint --no-typecheck &> /dev/null && exit 0 || exit 1
That being said, if you're going way way back in time, try out npm install --before
; you can give it a date and it will give you the dependencies as of that date. It works most of the time.
Inspired by microsoft#53015 (comment) Signed-off-by: pan93412 <pan93412@gmail.com>
This just broke on main because we don't have it pinned. The package has removed some APIs and no longer supports Node 14.