Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tests and fixes issues by verifying incremental project updates are handling language service ref counting correctly #54504

Merged
merged 4 commits into from
Jun 6, 2023

Conversation

sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Jun 2, 2023

  • e228e1b Whenever LS updates the program, we are ensuring the expected ref counting based on source files in all projects matches with what's currently in the document registry. While looking into Handle already released source files that dont match scriptKind #54401 I realized that there are more scenarios where language ref counting is not correct and identified more as well when creating this test framework.
  • 533145d This fixes issue where documents were not released from cache whenever clearing semantic cache, which meant we held onto documents even though we don't need them
  • ff40714 implied node format change was causing to increase the language service ref count to increment incorrectly and incorrect module resolution reuse.
  • baf872c ensures that project always correctly represents the program state same as that of LS so that its reflected correctly for all purposes.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 2, 2023
@sheetalkamat sheetalkamat merged commit 3c4c060 into main Jun 6, 2023
17 checks passed
@sheetalkamat sheetalkamat deleted the refCountTesting branch June 6, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants