-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch for issue #32951 #54621
Patch for issue #32951 #54621
Conversation
relaxed interface to fit with javascript behaviour
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't add a type parameter, just change the relevant occurrences of string
.
The issue only mentions number
, not boolean
- please don't make unrequested changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the generic addition, this change is incorrect. When values are iterated, they are always stringified. The only type that should be modified is for values that are allowed to be set.
I think that the change should actually happen on TypeScript-DOM-lib-generator. |
This change is in a non- |
But the correct fix and its relevant changes would be to generated files which originate from the generator. |
@RyanCavanaugh @jakebailey @DanielRosenwasser Thanks for reviewing
That's what I thought at the beginning when I realised that the affected lib.dom.d.ts is not here.
I am sorry for confusing, but the engines also transforms boolean to string "true"/"false" out of the box so I would suggest to update the original issue to handle all subject with the correct resolution. I am going to use |
relaxed interface to fit with javascript behaviour
Fixes microsoft/TypeScript-DOM-lib-generator#1568