Do not mark indexed access object type comparisons as unreliable. #54781

DanielRosenwasser · 2023-06-26T17:15:33Z

Reverts the checker change in #52106.

See #54754 for a hopefully better long-term fix.

Reopens #52096.

DanielRosenwasser · 2023-06-26T17:17:08Z

@typescript-bot pack this
@typescript-bot test this
@typescript-bot test top280
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this

typescript-bot · 2023-06-26T17:17:10Z

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite on this PR at 8d94382. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-26T17:17:10Z

Heya @DanielRosenwasser, I've started to run the parallelized Definitely Typed test suite on this PR at 8d94382. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-26T17:17:10Z

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at 8d94382. You can monitor the build here.

typescript-bot · 2023-06-26T17:17:10Z

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at 8d94382. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-26T17:17:10Z

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 8d94382. You can monitor the build here.

typescript-bot · 2023-06-26T17:17:10Z

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite (tsserver) on this PR at 8d94382. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-26T17:17:10Z

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite on this PR at 8d94382. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-26T17:17:11Z

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite (tsserver) on this PR at 8d94382. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-26T17:19:23Z

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/155637/artifacts?artifactName=tgz&fileId=04DE374095785839F62F13D7F462400B471B8FC647A291E41CD31D23BFD6186002&fileName=/typescript-5.2.0-insiders.20230626.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.2.0-pr-54781-9".;

jakebailey · 2023-06-26T17:23:12Z

@JoshuaKGoldberg Any chance you could throw the above package ("typescript": "npm:@typescript-deploys/pr-build@5.2.0-pr-54781-9") into the ts-eslint CI to see if it passes again?

typescript-bot · 2023-06-26T17:40:51Z

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/54781/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

[NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-54781/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-54781/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-54781/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-54781/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-54781/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-54781/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-54781/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-54781/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-54781/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-54781/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-54781/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-54781/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-54781/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-54781/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-54781/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
[MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

typescript-bot · 2023-06-26T17:57:05Z

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/54781/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"

Otherwise...

Everything looks good!

typescript-bot · 2023-06-26T18:51:40Z

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..54781

_Metric	_main	₅₄₇₈₁	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{366,615k (± 0.01%)}	_{366,606k (± 0.01%)}	_~	_366,580k	_366,640k	_{p=0.872 n=6}
_{Parse Time}	_{3.42s (± 0.54%)}	_{3.42s (± 0.50%)}	_~	_3.40s	_3.44s	_{p=0.871 n=6}
_{Bind Time}	_{1.13s (± 0.49%)}	_{1.12s (± 0.00%)}	_~	_1.12s	_1.12s	_{p=0.071 n=6}
_{Check Time}	_{8.88s (± 0.39%)}	_{8.81s (± 0.22%)}	_{-0.07s (- 0.73%)}	_8.79s	_8.83s	_{p=0.020 n=6}
_{Emit Time}	_{7.48s (± 0.49%)}	_{7.46s (± 0.14%)}	_~	_7.44s	_7.47s	_{p=0.256 n=6}
_{Total Time}	_{20.90s (± 0.29%)}	_{20.81s (± 0.15%)}	_{-0.09s (- 0.45%)}	_20.76s	_20.84s	_{p=0.024 n=6}
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{191,920k (± 1.21%)}	_{190,968k (± 0.03%)}	_~	_190,902k	_191,060k	_{p=0.423 n=6}
_{Parse Time}	_{1.49s (± 1.61%)}	_{1.50s (± 0.50%)}	_~	_1.49s	_1.51s	_{p=0.209 n=6}
_{Bind Time}	_{0.77s (± 0.97%)}	_{0.77s (± 1.35%)}	_~	_0.75s	_0.78s	_{p=0.437 n=6}
_{Check Time}	_{9.46s (± 0.60%)}	_{9.47s (± 0.69%)}	_~	_9.38s	_9.57s	_{p=0.810 n=6}
_{Emit Time}	_{2.76s (± 1.01%)}	_{2.76s (± 0.94%)}	_~	_2.73s	_2.80s	_{p=1.000 n=6}
_{Total Time}	_{14.47s (± 0.49%)}	_{14.49s (± 0.50%)}	_~	_14.39s	_14.57s	_{p=0.688 n=6}
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{346,800k (± 0.01%)}	_{346,795k (± 0.01%)}	_~	_346,750k	_346,858k	_{p=0.809 n=6}
_{Parse Time}	_{2.58s (± 0.84%)}	_{2.59s (± 0.88%)}	_~	_2.56s	_2.62s	_{p=0.331 n=6}
_{Bind Time}	_{1.00s (± 0.54%)}	_{1.01s (± 0.51%)}	_~	_1.00s	_1.01s	_{p=0.640 n=6}
_{Check Time}	_{7.18s (± 0.64%)}	_{7.19s (± 0.37%)}	_~	_7.15s	_7.22s	_{p=0.936 n=6}
_{Emit Time}	_{4.27s (± 0.53%)}	_{4.24s (± 0.79%)}	_~	_4.19s	_4.28s	_{p=0.169 n=6}
_{Total Time}	_{15.03s (± 0.34%)}	_{15.03s (± 0.42%)}	_~	_14.96s	_15.12s	_{p=0.936 n=6}
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{300,884k (± 0.01%)}	_{300,879k (± 0.01%)}	_~	_300,839k	_300,896k	_{p=0.873 n=6}
_{Parse Time}	_{2.07s (± 0.85%)}	_{2.06s (± 0.67%)}	_~	_2.04s	_2.08s	_{p=0.222 n=6}
_{Bind Time}	_{1.14s (± 0.45%)}	_{1.14s (± 0.92%)}	_~	_1.12s	_1.15s	_{p=0.142 n=6}
_{Check Time}	_{6.66s (± 0.64%)}	_{6.64s (± 0.13%)}	_~	_6.63s	_6.65s	_{p=0.374 n=6}
_{Emit Time}	_{3.87s (± 0.71%)}	_{3.85s (± 0.35%)}	_~	_3.83s	_3.87s	_{p=0.370 n=6}
_{Total Time}	_{13.73s (± 0.40%)}	_{13.69s (± 0.19%)}	_~	_13.65s	_13.72s	_{p=0.124 n=6}
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{482,317k (± 0.01%)}	_{482,334k (± 0.01%)}	_~	_482,248k	_482,408k	_{p=0.575 n=6}
_{Parse Time}	_{3.12s (± 0.66%)}	_{3.12s (± 0.39%)}	_~	_3.10s	_3.13s	_{p=0.743 n=6}
_{Bind Time}	_{0.92s (± 1.44%)}	_{0.92s (± 1.13%)}	_~	_0.91s	_0.93s	_{p=0.523 n=6}
_{Check Time}	_{16.94s (± 0.57%)}	_{16.98s (± 0.51%)}	_~	_16.89s	_17.12s	_{p=0.422 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.99s (± 0.47%)}	_{21.01s (± 0.44%)}	_~	_20.92s	_21.16s	_{p=0.810 n=6}
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{564,257k (± 0.04%)}	_{563,586k (± 0.03%)}	_{-671k (- 0.12%)}	_563,413k	_563,774k	_{p=0.005 n=6}
_{Parse Time}	_{3.82s (± 0.63%)}	_{3.83s (± 0.51%)}	_~	_3.80s	_3.86s	_{p=0.193 n=6}
_{Bind Time}	_{1.64s (± 0.32%)}	_{1.63s (± 0.33%)}	_~	_1.63s	_1.64s	_{p=0.798 n=6}
_{Check Time}	_{2.79s (± 0.37%)}	_{2.80s (± 0.54%)}	_~	_2.79s	_2.83s	_{p=0.210 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{8.33s (± 0.28%)}	_{8.36s (± 0.27%)}	_~	_8.33s	_8.40s	_{p=0.075 n=6}
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{366,009k (± 0.01%)}	_{366,016k (± 0.01%)}	_~	_365,996k	_366,049k	_{p=0.630 n=6}
_{Parse Time}	_{3.57s (± 0.52%)}	_{3.58s (± 0.60%)}	_~	_3.54s	_3.60s	_{p=0.739 n=6}
_{Bind Time}	_{1.18s (± 0.54%)}	_{1.18s (± 0.35%)}	_~	_1.18s	_1.19s	_{p=0.673 n=6}
_{Check Time}	_{9.69s (± 0.55%)}	_{9.63s (± 0.28%)}	_~	_9.59s	_9.66s	_{p=0.064 n=6}
_{Emit Time}	_{8.04s (± 0.68%)}	_{7.98s (± 0.30%)}	_~	_7.95s	_8.02s	_{p=0.064 n=6}
_{Total Time}	_{22.48s (± 0.36%)}	_{22.36s (± 0.28%)}	_{-0.11s (- 0.50%)}	_22.28s	_22.44s	_{p=0.030 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,833k (± 0.02%)}	_{192,817k (± 0.04%)}	_~	_192,699k	_192,902k	_{p=0.936 n=6}
_{Parse Time}	_{1.58s (± 1.48%)}	_{1.58s (± 1.72%)}	_~	_1.55s	_1.61s	_{p=0.935 n=6}
_{Bind Time}	_{0.83s (± 0.62%)}	_{0.82s (± 0.92%)}	_~	_0.81s	_0.83s	_{p=0.247 n=6}
_{Check Time}	_{10.16s (± 1.00%)}	_{10.12s (± 0.60%)}	_~	_10.07s	_10.23s	_{p=0.688 n=6}
_{Emit Time}	_{3.03s (± 1.09%)}	_{3.04s (± 1.19%)}	_~	_3.00s	_3.09s	_{p=1.000 n=6}
_{Total Time}	_{15.60s (± 0.58%)}	_{15.55s (± 0.40%)}	_~	_15.49s	_15.63s	_{p=0.520 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{346,057k (± 0.00%)}	_{346,065k (± 0.01%)}	_~	_346,035k	_346,089k	_{p=0.521 n=6}
_{Parse Time}	_{2.74s (± 0.83%)}	_{2.73s (± 0.43%)}	_~	_2.71s	_2.74s	_{p=0.462 n=6}
_{Bind Time}	_{1.09s (± 0.50%)}	_{1.09s (± 0.47%)}	_{-0.01s (- 0.76%)}	_1.08s	_1.09s	_{p=0.038 n=6}
_{Check Time}	_{7.90s (± 0.60%)}	_{7.87s (± 0.46%)}	_~	_7.82s	_7.91s	_{p=0.469 n=6}
_{Emit Time}	_{4.49s (± 0.43%)}	_{4.46s (± 0.31%)}	_{-0.02s (- 0.56%)}	_4.45s	_4.48s	_{p=0.043 n=6}
_{Total Time}	_{16.22s (± 0.50%)}	_{16.15s (± 0.31%)}	_~	_16.09s	_16.20s	_{p=0.199 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,216k (± 0.01%)}	_{300,204k (± 0.01%)}	_~	_300,183k	_300,232k	_{p=0.297 n=6}
_{Parse Time}	_{2.17s (± 0.50%)}	_{2.17s (± 0.68%)}	_~	_2.15s	_2.19s	_{p=0.805 n=6}
_{Bind Time}	_{1.25s (± 0.33%)}	_{1.24s (± 1.10%)}	_~	_1.22s	_1.26s	_{p=0.078 n=6}
_{Check Time}	_{7.34s (± 0.37%)}	_{7.32s (± 0.51%)}	_~	_7.29s	_7.39s	_{p=0.517 n=6}
_{Emit Time}	_{4.34s (± 0.68%)}	_{4.35s (± 1.05%)}	_~	_4.31s	_4.44s	_{p=1.000 n=6}
_{Total Time}	_{15.10s (± 0.31%)}	_{15.08s (± 0.56%)}	_~	_15.02s	_15.24s	_{p=0.259 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{481,616k (± 0.01%)}	_{481,634k (± 0.01%)}	_~	_481,550k	_481,665k	_{p=0.470 n=6}
_{Parse Time}	_{3.26s (± 0.66%)}	_{3.26s (± 0.25%)}	_~	_3.25s	_3.27s	_{p=0.934 n=6}
_{Bind Time}	_{0.95s (± 0.79%)}	_{0.95s (± 0.43%)}	_~	_0.95s	_0.96s	_{p=1.000 n=6}
_{Check Time}	_{17.97s (± 0.36%)}	_{17.98s (± 0.73%)}	_~	_17.79s	_18.14s	_{p=1.000 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.19s (± 0.31%)}	_{22.19s (± 0.59%)}	_~	_21.99s	_22.35s	_{p=1.000 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{561,785k (± 0.02%)}	_{561,107k (± 0.01%)}	_{-678k (- 0.12%)}	_561,051k	_561,258k	_{p=0.005 n=6}
_{Parse Time}	_{4.00s (± 0.26%)}	_{4.01s (± 0.29%)}	_~	_3.99s	_4.02s	_{p=0.456 n=6}
_{Bind Time}	_{1.73s (± 0.43%)}	_{1.75s (± 0.48%)}	_{+0.01s (+ 0.77%)}	_1.74s	_1.76s	_{p=0.020 n=6}
_{Check Time}	_{3.06s (± 0.45%)}	_{3.06s (± 0.43%)}	_~	_3.04s	_3.07s	_{p=0.808 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 5.53%)}	_~	_0.09s	_0.10s	_{p=0.174 n=6}
_{Total Time}	_{8.89s (± 0.33%)}	_{8.90s (± 0.18%)}	_~	_8.89s	_8.93s	_{p=0.467 n=6}
_{Angular - node (v14.21.3, x64)}
_{Memory used}	_{360,063k (± 0.02%)}	_{360,044k (± 0.01%)}	_~	_359,991k	_360,103k	_{p=0.575 n=6}
_{Parse Time}	_{3.68s (± 0.56%)}	_{3.68s (± 0.72%)}	_~	_3.65s	_3.72s	_{p=1.000 n=6}
_{Bind Time}	_{1.22s (± 0.62%)}	_{1.22s (± 0.68%)}	_~	_1.22s	_1.24s	_{p=0.209 n=6}
_{Check Time}	_{10.09s (± 0.44%)}	_{10.12s (± 0.53%)}	_~	_10.04s	_10.18s	_{p=0.294 n=6}
_{Emit Time}	_{8.40s (± 1.02%)}	_{8.39s (± 0.97%)}	_~	_8.29s	_8.51s	_{p=0.936 n=6}
_{Total Time}	_{23.38s (± 0.49%)}	_{23.41s (± 0.57%)}	_~	_23.23s	_23.58s	_{p=0.689 n=6}
_{Compiler-Unions - node (v14.21.3, x64)}
_{Memory used}	_{188,154k (± 0.01%)}	_{188,135k (± 0.01%)}	_~	_188,097k	_188,163k	_{p=0.173 n=6}
_{Parse Time}	_{1.63s (± 0.84%)}	_{1.62s (± 0.39%)}	_~	_1.61s	_1.63s	_{p=0.388 n=6}
_{Bind Time}	_{0.85s (± 0.89%)}	_{0.85s (± 0.65%)}	_~	_0.84s	_0.85s	_{p=0.476 n=6}
_{Check Time}	_{10.29s (± 0.15%)}	_{10.28s (± 0.45%)}	_~	_10.22s	_10.34s	_{p=0.565 n=6}
_{Emit Time}	_{3.14s (± 0.42%)}	_{3.15s (± 1.44%)}	_~	_3.10s	_3.23s	_{p=1.000 n=6}
_{Total Time}	_{15.90s (± 0.14%)}	_{15.89s (± 0.41%)}	_~	_15.80s	_15.96s	_{p=1.000 n=6}
_{Monaco - node (v14.21.3, x64)}
_{Memory used}	_{341,200k (± 0.00%)}	_{341,176k (± 0.00%)}	_{-24k (- 0.01%)}	_341,162k	_341,203k	_{p=0.030 n=6}
_{Parse Time}	_{2.80s (± 0.61%)}	_{2.81s (± 0.52%)}	_~	_2.80s	_2.84s	_{p=0.245 n=6}
_{Bind Time}	_{1.12s (± 0.75%)}	_{1.12s (± 1.04%)}	_~	_1.11s	_1.14s	_{p=0.652 n=6}
_{Check Time}	_{8.19s (± 0.22%)}	_{8.16s (± 0.36%)}	_~	_8.11s	_8.20s	_{p=0.052 n=6}
_{Emit Time}	_{4.69s (± 1.09%)}	_{4.70s (± 0.91%)}	_~	_4.63s	_4.75s	_{p=0.936 n=6}
_{Total Time}	_{16.80s (± 0.46%)}	_{16.79s (± 0.44%)}	_~	_16.70s	_16.88s	_{p=0.808 n=6}
_{TFS - node (v14.21.3, x64)}
_{Memory used}	_{295,305k (± 0.00%)}	_{295,307k (± 0.00%)}	_~	_295,302k	_295,314k	_{p=0.809 n=6}
_{Parse Time}	_{2.40s (± 0.61%)}	_{2.40s (± 0.57%)}	_~	_2.38s	_2.41s	_{p=0.734 n=6}
_{Bind Time}	_{1.07s (± 0.59%)}	_{1.07s (± 0.38%)}	_~	_1.06s	_1.07s	_{p=0.673 n=6}
_{Check Time}	_{7.64s (± 0.23%)}	_{7.66s (± 0.95%)}	_~	_7.57s	_7.78s	_{p=0.628 n=6}
_{Emit Time}	_{4.30s (± 1.19%)}	_{4.33s (± 0.74%)}	_~	_4.30s	_4.38s	_{p=0.199 n=6}
_{Total Time}	_{15.41s (± 0.42%)}	_{15.46s (± 0.62%)}	_~	_15.35s	_15.61s	_{p=0.378 n=6}
_{material-ui - node (v14.21.3, x64)}
_{Memory used}	_{477,091k (± 0.01%)}	_{477,112k (± 0.00%)}	_~	_477,091k	_477,130k	_{p=0.230 n=6}
_{Parse Time}	_{3.33s (± 0.30%)}	_{3.33s (± 0.41%)}	_~	_3.32s	_3.36s	_{p=0.591 n=6}
_{Bind Time}	_{1.01s (± 0.51%)}	_{1.01s (± 0.51%)}	_~	_1.00s	_1.01s	_{p=1.000 n=6}
_{Check Time}	_{18.89s (± 0.47%)}	_{18.89s (± 0.42%)}	_~	_18.78s	_19.00s	_{p=0.936 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{23.23s (± 0.39%)}	_{23.24s (± 0.35%)}	_~	_23.12s	_23.36s	_{p=0.810 n=6}
_{xstate - node (v14.21.3, x64)}
_{Memory used}	_{550,707k (± 0.00%)}	_{550,204k (± 0.00%)}	_{-503k (- 0.09%)}	_550,191k	_550,219k	_{p=0.005 n=6}
_{Parse Time}	_{4.24s (± 0.46%)}	_{4.23s (± 0.24%)}	_~	_4.21s	_4.24s	_{p=0.211 n=6}
_{Bind Time}	_{1.67s (± 1.05%)}	_{1.66s (± 1.23%)}	_~	_1.64s	_1.68s	_{p=0.415 n=6}
_{Check Time}	_{3.15s (± 0.56%)}	_{3.14s (± 0.56%)}	_~	_3.13s	_3.17s	_{p=1.000 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{9.15s (± 0.48%)}	_{9.13s (± 0.43%)}	_~	_9.08s	_9.19s	_{p=0.470 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.21.3, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.21.3, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.21.3, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.21.3, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.21.3, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.21.3, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.21.3, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₇₈₁	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..54781

_Metric	_main	₅₄₇₈₁	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,559ms (± 0.54%)}	_{2,558ms (± 0.37%)}	_~	_2,542ms	_2,569ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{5,346ms (± 0.72%)}	_{5,344ms (± 0.59%)}	_~	_5,305ms	_5,386ms	_{p=1.000 n=6}
_{Req 3 - references}	_{340ms (± 0.55%)}	_{340ms (± 0.78%)}	_~	_337ms	_343ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{288ms (± 0.42%)}	_{287ms (± 0.60%)}	_~	_284ms	_289ms	_{p=0.804 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{84ms (± 2.99%)}	_{83ms (± 7.07%)}	_~	_72ms	_89ms	_{p=1.000 n=6}
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,638ms (± 1.21%)}	_{2,650ms (± 1.01%)}	_~	_2,612ms	_2,677ms	_{p=0.470 n=6}
_{Req 2 - geterr}	_{4,112ms (± 0.42%)}	_{4,099ms (± 0.47%)}	_~	_4,073ms	_4,129ms	_{p=0.261 n=6}
_{Req 3 - references}	_{349ms (± 0.71%)}	_{347ms (± 0.54%)}	_~	_345ms	_350ms	_{p=0.222 n=6}
_{Req 4 - navto}	_{290ms (± 1.28%)}	_{287ms (± 0.48%)}	_~	_285ms	_288ms	_{p=0.106 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{64ms (± 3.34%)}	_{64ms (± 3.55%)}	_~	_62ms	_68ms	_{p=0.546 n=6}
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,116ms (± 0.50%)}	_{3,099ms (± 0.41%)}	_~	_3,079ms	_3,111ms	_{p=0.093 n=6}
_{Req 2 - geterr}	_{1,545ms (± 0.60%)}	_{1,593ms (± 0.38%)}	_{+48ms (+ 3.13%)}	_1,585ms	_1,602ms	_{p=0.005 n=6}
_{Req 3 - references}	_{115ms (± 1.42%)}	_{113ms (± 1.25%)}	_~	_111ms	_115ms	_{p=0.120 n=6}
_{Req 4 - navto}	_{369ms (± 0.27%)}	_{368ms (± 0.22%)}	_~	_367ms	_369ms	_{p=0.498 n=6}
_{Req 5 - completionInfo count}	_{2,870 (± 0.00%)}	_{2,870 (± 0.00%)}	_~	_2,870	_2,870	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{375ms (± 1.86%)}	_{377ms (± 1.64%)}	_~	_366ms	_382ms	_{p=0.935 n=6}
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,646ms (± 0.69%)}	_{2,640ms (± 0.91%)}	_~	_2,614ms	_2,672ms	_{p=0.689 n=6}
_{Req 2 - geterr}	_{6,040ms (± 0.81%)}	_{6,020ms (± 0.44%)}	_~	_5,997ms	_6,068ms	_{p=0.471 n=6}
_{Req 3 - references}	_{355ms (± 0.52%)}	_{353ms (± 0.54%)}	_~	_351ms	_356ms	_{p=0.190 n=6}
_{Req 4 - navto}	_{287ms (± 1.61%)}	_{288ms (± 2.11%)}	_~	_281ms	_295ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{92ms (± 0.88%)}	_{94ms (± 1.61%)}	_~	_92ms	_96ms	_{p=0.116 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,848ms (± 0.52%)}	_{2,836ms (± 0.42%)}	_~	_2,821ms	_2,856ms	_{p=0.173 n=6}
_{Req 2 - geterr}	_{4,674ms (± 0.33%)}	_{4,675ms (± 0.30%)}	_~	_4,660ms	_4,696ms	_{p=0.872 n=6}
_{Req 3 - references}	_{363ms (± 0.95%)}	_{364ms (± 0.60%)}	_~	_362ms	_368ms	_{p=0.676 n=6}
_{Req 4 - navto}	_{284ms (± 0.86%)}	_{281ms (± 1.10%)}	_~	_277ms	_284ms	_{p=0.142 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{67ms (± 1.12%)}	_{67ms (± 0.77%)}	_~	_67ms	_68ms	_{p=0.784 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,229ms (± 0.60%)}	_{3,224ms (± 0.38%)}	_~	_3,206ms	_3,242ms	_{p=0.630 n=6}
_{Req 2 - geterr}	_{1,714ms (± 0.37%)}	_{1,750ms (± 0.40%)}	_{+36ms (+ 2.08%)}	_1,741ms	_1,761ms	_{p=0.005 n=6}
_{Req 3 - references}	_{124ms (± 1.19%)}	_{125ms (± 7.11%)}	_~	_119ms	_143ms	_{p=0.361 n=6}
_{Req 4 - navto}	_{351ms (± 0.39%)}	_{354ms (± 0.52%)}	_{+3ms (+ 0.95%)}	_352ms	_357ms	_{p=0.007 n=6}
_{Req 5 - completionInfo count}	_{2,870 (± 0.00%)}	_{2,870 (± 0.00%)}	_~	_2,870	_2,870	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{416ms (± 1.06%)}	_{403ms (± 1.23%)}	_{🟩-13ms (- 3.05%)}	_393ms	_406ms	_{p=0.005 n=6}
_{Compiler-UnionsTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{2,782ms (± 0.68%)}	_{2,788ms (± 0.70%)}	_~	_2,769ms	_2,816ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{6,179ms (± 0.46%)}	_{6,164ms (± 0.41%)}	_~	_6,128ms	_6,194ms	_{p=0.378 n=6}
_{Req 3 - references}	_{362ms (± 1.16%)}	_{363ms (± 1.38%)}	_~	_358ms	_372ms	_{p=0.872 n=6}
_{Req 4 - navto}	_{292ms (± 0.71%)}	_{292ms (± 0.42%)}	_~	_290ms	_293ms	_{p=0.676 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{102ms (± 3.67%)}	_{102ms (± 3.80%)}	_~	_94ms	_104ms	_{p=0.546 n=6}
_{CompilerTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{2,988ms (± 0.54%)}	_{2,979ms (± 0.62%)}	_~	_2,955ms	_3,002ms	_{p=0.471 n=6}
_{Req 2 - geterr}	_{4,563ms (± 0.70%)}	_{4,522ms (± 0.39%)}	_{-41ms (- 0.90%)}	_4,495ms	_4,547ms	_{p=0.045 n=6}
_{Req 3 - references}	_{375ms (± 0.55%)}	_{378ms (± 0.60%)}	_~	_374ms	_381ms	_{p=0.059 n=6}
_{Req 4 - navto}	_{299ms (± 0.39%)}	_{298ms (± 0.42%)}	_~	_296ms	_299ms	_{p=0.278 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{76ms (± 1.53%)}	_{76ms (± 1.07%)}	_~	_75ms	_77ms	_{p=1.000 n=6}
_{xstateTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{3,464ms (± 0.84%)}	_{3,493ms (± 0.60%)}	_~	_3,460ms	_3,517ms	_{p=0.148 n=6}
_{Req 2 - geterr}	_{1,836ms (± 0.55%)}	_{1,845ms (± 0.67%)}	_~	_1,825ms	_1,861ms	_{p=0.228 n=6}
_{Req 3 - references}	_{147ms (± 5.98%)}	_{148ms (± 7.91%)}	_~	_137ms	_160ms	_{p=0.935 n=6}
_{Req 4 - navto}	_{397ms (± 0.37%)}	_{395ms (± 1.65%)}	_~	_386ms	_401ms	_{p=0.935 n=6}
_{Req 5 - completionInfo count}	_{2,870 (± 0.00%)}	_{2,870 (± 0.00%)}	_~	_2,870	_2,870	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{430ms (± 1.88%)}	_{439ms (± 1.11%)}	_~	_432ms	_446ms	_{p=0.077 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.21.3, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.21.3, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.21.3, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.21.3, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₇₈₁	₆
_Baseline	_main	₆

Startup

Comparison Report - main..54781

_Metric	_main	₅₄₇₈₁	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{142.87ms (± 0.22%)}	_{142.77ms (± 0.19%)}	_{-0.10ms (- 0.07%)}	_142.05ms	_145.58ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{223.56ms (± 0.50%)}	_{222.26ms (± 0.18%)}	_{-1.31ms (- 0.58%)}	_221.44ms	_229.80ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{225.74ms (± 0.41%)}	_{223.68ms (± 0.16%)}	_{-2.06ms (- 0.91%)}	_222.80ms	_228.32ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{207.20ms (± 0.37%)}	_{205.73ms (± 0.17%)}	_{-1.47ms (- 0.71%)}	_204.70ms	_208.78ms	_{p=0.000 n=600}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₇₈₁	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

DanielRosenwasser · 2023-06-26T19:03:28Z

@typescript-bot cherry-pick this to release-5.1

typescript-bot · 2023-06-26T19:03:30Z

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-5.1 on this PR at 8d94382. You can monitor the build here.

typescript-bot · 2023-06-26T19:09:27Z

Hey @DanielRosenwasser, I've opened #54786 for you.

Component commits: 8d94382 Do not mark indexed access object type comparisons as unreliable.

typescript-bot · 2023-06-26T19:32:30Z

Hey @DanielRosenwasser, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2023-06-26T20:02:01Z

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/54781/merge:

Everything looks good!

weswigham

Definitely will need to revert this revert eventually, but we absolutely need to make some things more efficient first to compensate.

Can we add a non-strict @types/lodash usage to the extended test suite (as that's what this fixes), since the DT run won't cover it? It's just a new folder in https://github.com/microsoft/typescript-error-deltas/tree/main/userTests right?

DanielRosenwasser · 2023-06-26T20:21:05Z

Can we add a non-strict @types/lodash usage to the extended test suite (as that's what this fixes), since the DT run won't cover it? It's just a new folder in https://github.com/microsoft/typescript-error-deltas/tree/main/userTests right?

I believe so, @jakebailey can help you there.

typescript-bot · 2023-06-26T21:13:52Z

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/54781/merge:

Everything looks good!

Do not mark indexed access object type comparisons as unreliable.

8d94382

DanielRosenwasser requested review from weswigham, andrewbranch, jakebailey and RyanCavanaugh June 26, 2023 17:15

typescript-bot assigned DanielRosenwasser Jun 26, 2023

typescript-bot added the Author: Team label Jun 26, 2023

typescript-bot assigned weswigham Jun 26, 2023

typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone labels Jun 26, 2023

DanielRosenwasser mentioned this pull request Jun 26, 2023

5.1 regression from 5.0: JavaScript heap out of memory (Type instantiation is excessively deep and possibly infinit) #54542

Closed

typescript-bot mentioned this pull request Jun 26, 2023

🤖 Pick PR #54781 (Do not mark indexed access object t...) into release-5.1 #54786

Closed

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Jun 26, 2023

Cherry-pick PR microsoft#54781 into release-5.1

83f9417

Component commits: 8d94382 Do not mark indexed access object type comparisons as unreliable.

weswigham approved these changes Jun 26, 2023

View reviewed changes

DanielRosenwasser merged commit f762de5 into main Jun 26, 2023
17 checks passed

DanielRosenwasser deleted the undo52106 branch June 26, 2023 20:21

RyanCavanaugh mentioned this pull request Oct 11, 2023

Incorrect variance inference when parameters of an interface with eventually different variances are bundled in an object type #56069

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not mark indexed access object type comparisons as unreliable. #54781

Do not mark indexed access object type comparisons as unreliable. #54781

DanielRosenwasser commented Jun 26, 2023 •

edited

DanielRosenwasser commented Jun 26, 2023

typescript-bot commented Jun 26, 2023 •

edited

typescript-bot commented Jun 26, 2023 •

edited

typescript-bot commented Jun 26, 2023 •

edited

typescript-bot commented Jun 26, 2023 •

edited

typescript-bot commented Jun 26, 2023 •

edited

typescript-bot commented Jun 26, 2023 •

edited

typescript-bot commented Jun 26, 2023 •

edited

typescript-bot commented Jun 26, 2023 •

edited

typescript-bot commented Jun 26, 2023 •

edited

jakebailey commented Jun 26, 2023

typescript-bot commented Jun 26, 2023

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

typescript-bot commented Jun 26, 2023

typescript-bot commented Jun 26, 2023

Compiler

TSServer

Startup

DanielRosenwasser commented Jun 26, 2023

typescript-bot commented Jun 26, 2023 •

edited

typescript-bot commented Jun 26, 2023

typescript-bot commented Jun 26, 2023

typescript-bot commented Jun 26, 2023

weswigham left a comment

DanielRosenwasser commented Jun 26, 2023

typescript-bot commented Jun 26, 2023

Do not mark indexed access object type comparisons as unreliable. #54781

Do not mark indexed access object type comparisons as unreliable. #54781

Conversation

DanielRosenwasser commented Jun 26, 2023 • edited

DanielRosenwasser commented Jun 26, 2023

typescript-bot commented Jun 26, 2023 • edited

typescript-bot commented Jun 26, 2023 • edited

typescript-bot commented Jun 26, 2023 • edited

typescript-bot commented Jun 26, 2023 • edited

typescript-bot commented Jun 26, 2023 • edited

typescript-bot commented Jun 26, 2023 • edited

typescript-bot commented Jun 26, 2023 • edited

typescript-bot commented Jun 26, 2023 • edited

typescript-bot commented Jun 26, 2023 • edited

jakebailey commented Jun 26, 2023

typescript-bot commented Jun 26, 2023

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

typescript-bot commented Jun 26, 2023

typescript-bot commented Jun 26, 2023

Compiler

TSServer

Startup

DanielRosenwasser commented Jun 26, 2023

typescript-bot commented Jun 26, 2023 • edited

typescript-bot commented Jun 26, 2023

typescript-bot commented Jun 26, 2023

typescript-bot commented Jun 26, 2023

weswigham left a comment

Choose a reason for hiding this comment

DanielRosenwasser commented Jun 26, 2023

typescript-bot commented Jun 26, 2023

DanielRosenwasser commented Jun 26, 2023 •

edited

typescript-bot commented Jun 26, 2023 •

edited

typescript-bot commented Jun 26, 2023 •

edited

typescript-bot commented Jun 26, 2023 •

edited

typescript-bot commented Jun 26, 2023 •

edited

typescript-bot commented Jun 26, 2023 •

edited

typescript-bot commented Jun 26, 2023 •

edited

typescript-bot commented Jun 26, 2023 •

edited

typescript-bot commented Jun 26, 2023 •

edited

typescript-bot commented Jun 26, 2023 •

edited

typescript-bot commented Jun 26, 2023 •

edited