Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze emptyArray, make emptyMap and emptySet immutable #55755

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 23 additions & 3 deletions src/compiler/core.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,31 @@ import {
} from "./_namespaces/ts";

/** @internal */
export const emptyArray: never[] = [] as never[];
export const emptyArray: never[] = Object.freeze([]) as never[];
/** @internal */
export const emptyMap: ReadonlyMap<never, never> = new Map<never, never>();
export const emptyMap: ReadonlyMap<never, never> = createReadonlyMap();
/** @internal */
export const emptySet: ReadonlySet<never> = new Set<never>();
export const emptySet: ReadonlySet<never> = createReadonlySet();

function createReadonlyMap<K, V>(): ReadonlyMap<K, V> {
const map: ReadonlyMap<K, V> = new Map();
Object.defineProperties(map, {
clear: { value: notImplemented },
delete: { value: notImplemented },
set: { value: notImplemented },
});
return Object.freeze(map);
}

function createReadonlySet<T>(): ReadonlySet<T> {
const set: ReadonlySet<T> = new Set();
Object.defineProperties(set, {
add: { value: notImplemented },
clear: { value: notImplemented },
delete: { value: notImplemented },
});
return Object.freeze(set);
}

/** @internal */
export function length(array: readonly any[] | undefined): number {
Expand Down
2 changes: 1 addition & 1 deletion src/compiler/utilities.ts
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,7 @@ import {
} from "./_namespaces/ts";

/** @internal */
export const resolvingEmptyArray: never[] = [];
export const resolvingEmptyArray: never[] = Object.freeze([]) as never[];

/** @internal */
export const externalHelpersModuleNameText = "tslib";
Expand Down
2 changes: 1 addition & 1 deletion src/server/utilitiesPublic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export enum LogLevel {
verbose,
}

export const emptyArray: SortedReadonlyArray<never> = createSortedArray<never>();
export const emptyArray: SortedReadonlyArray<never> = Object.freeze(createSortedArray<never>());

export interface Logger {
close(): void;
Expand Down