Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle fsWatch event with accesstime change on mac os #56403

Merged
merged 2 commits into from Nov 15, 2023
Merged

Handle fsWatch event with accesstime change on mac os #56403

merged 2 commits into from Nov 15, 2023

Conversation

sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Nov 15, 2023 •
edited

Send change event only if modified time has changed on mac os.
Fixes #52876, #51927

@sheetalkamat
Copy link
Member Author

@typescript-bot pack this

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 15, 2023
@sheetalkamat
Copy link
Member Author

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 15, 2023 •
edited

Heya @sheetalkamat, I've started to run the tarball bundle task on this PR at 4671cce. You can monitor the build here.

@sheetalkamat sheetalkamat mentioned this pull request Nov 15, 2023
Closed
@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 15, 2023 •
edited

Hey @sheetalkamat, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/158595/artifacts?artifactName=tgz&fileId=270C69279D28AEF93D4DDE7977504E51105F0019059428393EC2909809976A2202&fileName=/typescript-5.4.0-insiders.20231115.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.4.0-pr-56403-3".;

@jakebailey
Copy link
Member

Does Windows need this too? Similar is #52535.

@sheetalkamat
Copy link
Member Author

Not without concrete repro steps.. git diff on windows doesnt trigger refresh..

jakebailey
jakebailey approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I do kinda wonder if asking for the mtime touches atime, thus causing an event itself... But surely not given the user reported all was well.

@sheetalkamat sheetalkamat merged commit e40730f into main Nov 15, 2023
19 checks passed
@sheetalkamat sheetalkamat deleted the fsWatchWithTimestamp branch November 15, 2023 21:12
@sheetalkamat sheetalkamat mentioned this pull request Jan 9, 2024
Closed
This was referenced Mar 5, 2024
Closed
Open
sheetalkamat
sheetalkamat commented Mar 25, 2024
View reviewed changes
Copy link
Member Author

@sheetalkamat sheetalkamat left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing PR review comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

Assignees

@sheetalkamat sheetalkamat

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Watch mode: git diff on macOS triggers rebuild
3 participants
@sheetalkamat @typescript-bot @jakebailey