Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(57141): override keyword doesn't check symbol-key class members #57146

Merged
merged 5 commits into from
Jun 12, 2024
Merged

fix(57141): override keyword doesn't check symbol-key class members #57146

merged 5 commits into from
Jun 12, 2024

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #57141

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jan 23, 2024
@sandersn sandersn added this to Not started in PR Backlog Feb 1, 2024
@sandersn sandersn moved this from Not started to Waiting on reviewers in PR Backlog Feb 15, 2024
PR Backlog automation moved this from Waiting on reviewers to Waiting on author Mar 12, 2024
iisaduan
iisaduan requested changes Mar 12, 2024
View reviewed changes
Copy link
Member

@iisaduan iisaduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nodeModules.... baselines should be reverted since #57220 was merged after this PR was last updated. Pulling/merging main, and then updating baselines should revert them!

Otherwise, the PR looks good!

PR Backlog automation moved this from Waiting on author to Needs merge Mar 12, 2024
@iisaduan iisaduan merged commit 4ada270 into microsoft:main Jun 12, 2024
19 checks passed
@iisaduan iisaduan mentioned this pull request Jun 13, 2024
Merged
@RyanCavanaugh RyanCavanaugh mentioned this pull request Jun 24, 2024
Closed
@RyanCavanaugh RyanCavanaugh mentioned this pull request Jul 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iisaduan iisaduan iisaduan approved these changes

@rbuckton rbuckton Awaiting requested review from rbuckton

Assignees

@rbuckton rbuckton

Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Status: Done
PR Backlog
  
Needs merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

override keyword doesn't check symbol-key class members
4 participants
@a-tarasyuk @iisaduan @rbuckton @typescript-bot