Propagate object flags related to object and array literals onto `module.exports` types #57467

Andarist · 2024-02-21T18:45:05Z

…ule.exports` types

gabritto · 2024-04-05T17:43:54Z

typescript-bot · 2024-04-05T17:43:56Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-04-05T18:15:27Z

Hey @gabritto, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-04-05T18:16:38Z

@gabritto
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,527k (± 0.01%)}	_{295,528k (± 0.00%)}	_~	_295,522k	_295,544k	_{p=0.936 n=6}
_{Parse Time}	_{2.66s (± 0.24%)}	_{2.66s (± 0.15%)}	_~	_2.65s	_2.66s	_{p=0.673 n=6}
_{Bind Time}	_{0.83s (± 0.49%)}	_{0.83s (± 0.99%)}	_~	_0.82s	_0.84s	_{p=0.584 n=6}
_{Check Time}	_{8.21s (± 0.54%)}	_{8.21s (± 0.24%)}	_~	_8.18s	_8.24s	_{p=0.572 n=6}
_{Emit Time}	_{7.03s (± 0.23%)}	_{7.05s (± 0.30%)}	_~	_7.03s	_7.09s	_{p=0.167 n=6}
_{Total Time}	_{18.73s (± 0.20%)}	_{18.74s (± 0.14%)}	_~	_18.70s	_18.77s	_{p=0.333 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,105k (± 1.01%)}	_{192,467k (± 0.76%)}	_~	_191,830k	_195,443k	_{p=0.810 n=6}
_{Parse Time}	_{1.36s (± 1.04%)}	_{1.36s (± 0.80%)}	_~	_1.35s	_1.38s	_{p=1.000 n=6}
_{Bind Time}	_{0.72s (± 0.57%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=0.405 n=6}
_{Check Time}	_{9.52s (± 0.75%)}	_{9.44s (± 0.27%)}	_{-0.09s (- 0.89%)}	_9.40s	_9.48s	_{p=0.015 n=6}
_{Emit Time}	_{2.63s (± 0.54%)}	_{2.63s (± 0.42%)}	_~	_2.61s	_2.64s	_{p=1.000 n=6}
_{Total Time}	_{14.23s (± 0.48%)}	_{14.15s (± 0.26%)}	_{-0.08s (- 0.57%)}	_14.11s	_14.21s	_{p=0.030 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,368k (± 0.01%)}	_{347,391k (± 0.01%)}	_~	_347,358k	_347,424k	_{p=0.173 n=6}
_{Parse Time}	_{2.49s (± 0.30%)}	_{2.48s (± 0.84%)}	_~	_2.45s	_2.50s	_{p=0.741 n=6}
_{Bind Time}	_{0.92s (± 0.59%)}	_{0.93s (± 0.44%)}	_~	_0.92s	_0.93s	_{p=0.282 n=6}
_{Check Time}	_{7.01s (± 0.62%)}	_{7.01s (± 0.52%)}	_~	_6.96s	_7.05s	_{p=0.809 n=6}
_{Emit Time}	_{4.06s (± 0.30%)}	_{4.07s (± 0.49%)}	_~	_4.03s	_4.08s	_{p=0.343 n=6}
_{Total Time}	_{14.49s (± 0.27%)}	_{14.48s (± 0.38%)}	_~	_14.38s	_14.54s	_{p=0.571 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,714k (± 0.00%)}	_{302,711k (± 0.01%)}	_~	_302,686k	_302,745k	_{p=0.470 n=6}
_{Parse Time}	_{2.00s (± 0.98%)}	_{2.02s (± 0.51%)}	_~	_2.01s	_2.04s	_{p=0.050 n=6}
_{Bind Time}	_{1.00s (± 0.41%)}	_{1.01s (± 1.49%)}	_~	_0.99s	_1.03s	_{p=0.849 n=6}
_{Check Time}	_{6.31s (± 0.51%)}	_{6.32s (± 0.45%)}	_~	_6.28s	_6.36s	_{p=0.872 n=6}
_{Emit Time}	_{3.61s (± 0.41%)}	_{3.61s (± 0.46%)}	_~	_3.58s	_3.62s	_{p=1.000 n=6}
_{Total Time}	_{12.93s (± 0.32%)}	_{12.96s (± 0.21%)}	_~	_12.92s	_12.99s	_{p=0.255 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{509,882k (± 0.01%)}	_{509,893k (± 0.00%)}	_~	_509,869k	_509,911k	_{p=0.689 n=6}
_{Parse Time}	_{2.66s (± 0.51%)}	_{2.66s (± 0.19%)}	_~	_2.66s	_2.67s	_{p=0.386 n=6}
_{Bind Time}	_{0.98s (± 0.85%)}	_{0.99s (± 0.99%)}	_~	_0.98s	_1.00s	_{p=0.256 n=6}
_{Check Time}	_{17.26s (± 0.52%)}	_{17.25s (± 0.40%)}	_~	_17.13s	_17.32s	_{p=0.936 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.90s (± 0.42%)}	_{20.91s (± 0.33%)}	_~	_20.79s	_20.99s	_{p=0.810 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,744,093k (± 0.00%)}	_{1,744,071k (± 0.00%)}	_~	_1,744,040k	_1,744,088k	_{p=0.423 n=6}
_{Parse Time}	_{9.64s (± 0.36%)}	_{9.66s (± 0.62%)}	_~	_9.59s	_9.76s	_{p=0.571 n=6}
_{Bind Time}	_{3.46s (± 1.03%)}	_{3.49s (± 0.42%)}	_{+0.04s (+ 1.06%)}	_3.47s	_3.51s	_{p=0.042 n=6}
_{Check Time}	_{81.86s (± 0.58%)}	_{81.73s (± 0.52%)}	_~	_81.29s	_82.49s	_{p=0.689 n=6}
_{Emit Time}	_{0.20s (± 2.62%)}	_{0.19s (± 2.81%)}	_~	_0.19s	_0.20s	_{p=0.640 n=6}
_{Total Time}	_{95.14s (± 0.51%)}	_{95.07s (± 0.46%)}	_~	_94.59s	_95.82s	_{p=0.810 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,393,739k (± 0.01%)}	_{2,394,500k (± 0.02%)}	_{+761k (+ 0.03%)}	_2,393,631k	_2,395,061k	_{p=0.031 n=6}
_{Parse Time}	_{7.50s (± 1.00%)}	_{7.57s (± 0.76%)}	_~	_7.49s	_7.64s	_{p=0.128 n=6}
_{Bind Time}	_{2.76s (± 0.61%)}	_{2.78s (± 1.31%)}	_~	_2.74s	_2.84s	_{p=0.258 n=6}
_{Check Time}	_{49.10s (± 0.18%)}	_{48.94s (± 0.54%)}	_~	_48.57s	_49.19s	_{p=0.378 n=6}
_{Emit Time}	_{3.91s (± 1.07%)}	_{3.85s (± 1.42%)}	_~	_3.76s	_3.92s	_{p=0.077 n=6}
_{Total Time}	_{63.27s (± 0.18%)}	_{63.16s (± 0.38%)}	_~	_62.84s	_63.41s	_{p=0.575 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_{Memory used}	_0k	_0k	_~	_0k	_0k	_{p=NaN n=0}
_{Parse Time}	_0.00s	_0.00s	_~	_0.00s	_0.00s	_{p=NaN n=0}
_{Bind Time}	_0.00s	_0.00s	_~	_0.00s	_0.00s	_{p=NaN n=0}
_{Check Time}	_0.00s	_0.00s	_~	_0.00s	_0.00s	_{p=NaN n=0}
_{Emit Time}	_0.00s	_0.00s	_~	_0.00s	_0.00s	_{p=NaN n=0}
_{Total Time}	_0.00s	_0.00s	_~	_0.00s	_0.00s	_{p=NaN n=0}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{415,219k (± 0.01%)}	_{415,199k (± 0.01%)}	_~	_415,132k	_415,248k	_{p=0.471 n=6}
_{Parse Time}	_{4.21s (± 0.83%)}	_{4.24s (± 0.41%)}	_~	_4.22s	_4.27s	_{p=0.171 n=6}
_{Bind Time}	_{1.59s (± 0.53%)}	_{1.58s (± 1.35%)}	_~	_1.55s	_1.61s	_{p=0.732 n=6}
_{Check Time}	_{22.33s (± 0.26%)}	_{22.31s (± 0.24%)}	_~	_22.24s	_22.39s	_{p=0.630 n=6}
_{Emit Time}	_{1.65s (± 2.34%)}	_{1.65s (± 1.46%)}	_~	_1.64s	_1.70s	_{p=0.934 n=6}
_{Total Time}	_{29.78s (± 0.24%)}	_{29.79s (± 0.29%)}	_~	_29.69s	_29.90s	_{p=1.000 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,904,319k (± 0.00%)}	_{2,904,398k (± 0.00%)}	_~	_2,904,262k	_2,904,453k	_{p=0.173 n=6}
_{Parse Time}	_{12.95s (± 0.40%)}	_{12.93s (± 0.58%)}	_~	_12.81s	_13.04s	_{p=0.377 n=6}
_{Bind Time}	_{4.15s (± 0.78%)}	_{4.15s (± 0.30%)}	_~	_4.13s	_4.16s	_{p=0.682 n=6}
_{Check Time}	_{72.45s (± 0.37%)}	_{72.00s (± 0.54%)}	_~	_71.58s	_72.50s	_{p=0.066 n=6}
_{Emit Time}	_{22.06s (± 8.53%)}	_{20.11s (± 8.19%)}	_~	_19.37s	_23.48s	_{p=0.065 n=6}
_{Total Time}	_{111.61s (± 1.72%)}	_{109.19s (± 1.71%)}	_{-2.42s (- 2.17%)}	_108.17s	_112.96s	_{p=0.045 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{408,327k (± 0.01%)}	_{408,322k (± 0.01%)}	_~	_408,268k	_408,358k	_{p=1.000 n=6}
_{Parse Time}	_{3.24s (± 0.54%)}	_{3.25s (± 0.54%)}	_~	_3.22s	_3.27s	_{p=0.867 n=6}
_{Bind Time}	_{1.39s (± 1.27%)}	_{1.39s (± 1.06%)}	_~	_1.37s	_1.41s	_{p=0.803 n=6}
_{Check Time}	_{14.21s (± 0.23%)}	_{14.20s (± 0.37%)}	_~	_14.14s	_14.28s	_{p=0.872 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.84s (± 0.25%)}	_{18.84s (± 0.30%)}	_~	_18.78s	_18.93s	_{p=0.936 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,059k (± 0.01%)}	_{513,029k (± 0.02%)}	_~	_512,930k	_513,128k	_{p=0.575 n=6}
_{Parse Time}	_{3.29s (± 0.23%)}	_{3.29s (± 0.30%)}	_~	_3.27s	_3.30s	_{p=0.858 n=6}
_{Bind Time}	_{1.54s (± 0.76%)}	_{1.54s (± 0.41%)}	_~	_1.53s	_1.55s	_{p=1.000 n=6}
_{Check Time}	_{2.85s (± 0.48%)}	_{2.86s (± 0.29%)}	_~	_2.85s	_2.87s	_{p=0.170 n=6}
_{Emit Time}	_{0.07s (± 5.69%)}	_{0.07s (±11.12%)}	_~	_0.07s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{7.75s (± 0.27%)}	_{7.75s (± 0.11%)}	_~	_7.74s	_7.76s	_{p=0.416 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-04-05T18:18:08Z

@gabritto Here are the results of running the user tests comparing main and refs/pull/57467/merge:

Something interesting changed - please have a look.

Details

webpack

tsconfig.types.json

[NEW] error TS18048: 'cacheGroup.getName' is possibly 'undefined'.
- lib/optimize/SplitChunksPlugin.js#L1099
[NEW] error TS2345: Argument of type '(url: string, callback: (arg0: (Error | null) | undefined, arg1: ({ validUntil: number; etag?: string; entry: LockfileEntry; content: Buffer; fresh: boolean;} | { validUntil: number; etag?: string; location: string; fresh: boolean;}) | undefined) => void) => void' is not assignable to parameter of type '(arg0: string, arg1: (arg0?: Error | undefined, arg1?: { validUntil: number; etag?: string | undefined; entry: LockfileEntry; content: Buffer; fresh: boolean; } | { ...; } | undefined) => void) => void'.
- lib/schemes/HttpUriPlugin.js#L767
[NEW] error TS2345: Argument of type '(url: string, callback: (arg0: (Error | null) | undefined, arg1: { entry: LockfileEntry; content: Buffer;} | undefined) => void) => void' is not assignable to parameter of type '(arg0: string, arg1: (arg0?: Error | undefined, arg1?: { entry: LockfileEntry; content: Buffer; } | undefined) => void) => void'.
- lib/schemes/HttpUriPlugin.js#L799
[MISSING] error TS2345: Argument of type '(url: string, callback: (arg0: (Error | null) | undefined, arg1: ({ validUntil: number; etag?: string; entry: LockfileEntry; content: Buffer; fresh: boolean; } | { validUntil: number; etag?: string; location: string; fresh: boolean; }) | undefined) => void) => void' is not assignable to parameter of type '(arg0: string, arg1: (arg0?: Error | undefined, arg1?: { validUntil: number; etag?: string | undefined; entry: LockfileEntry; content: Buffer; fresh: boolean; } | { ...; } | undefined) => void) => void'.
- lib/schemes/HttpUriPlugin.js#L767
[MISSING] error TS2345: Argument of type '(url: string, callback: (arg0: (Error | null) | undefined, arg1: { entry: LockfileEntry; content: Buffer; } | undefined) => void) => void' is not assignable to parameter of type '(arg0: string, arg1: (arg0?: Error | undefined, arg1?: { entry: LockfileEntry; content: Buffer; } | undefined) => void) => void'.
- lib/schemes/HttpUriPlugin.js#L799

typescript-bot · 2024-04-05T19:55:25Z

@gabritto Here are the results of running the top 400 repos comparing main and refs/pull/57467/merge:

Something interesting changed - please have a look.

Details

Eugeny/tabby

11 of 29 projects failed to build with the old tsc and were ignored

tabby-web-demo/tsconfig.json

error TS2449: Class 'CheckboxComponent' used before its declaration.
- tabby-core/src/components/checkbox.component.ts#L15
error TS2449: Class 'ToggleComponent' used before its declaration.
- tabby-core/src/components/toggle.component.ts#L16

tabby-web/tsconfig.json

error TS2449: Class 'CheckboxComponent' used before its declaration.
- tabby-core/src/components/checkbox.component.ts#L15
error TS2449: Class 'ToggleComponent' used before its declaration.
- tabby-core/src/components/toggle.component.ts#L16

tabby-terminal/tsconfig.json

error TS2449: Class 'CheckboxComponent' used before its declaration.
- tabby-core/src/components/checkbox.component.ts#L15
error TS2449: Class 'ToggleComponent' used before its declaration.
- tabby-core/src/components/toggle.component.ts#L16

tabby-telnet/tsconfig.json

error TS2449: Class 'CheckboxComponent' used before its declaration.
- tabby-core/src/components/checkbox.component.ts#L15
error TS2449: Class 'ToggleComponent' used before its declaration.
- tabby-core/src/components/toggle.component.ts#L16

tabby-ssh/tsconfig.json

error TS2449: Class 'CheckboxComponent' used before its declaration.
- tabby-core/src/components/checkbox.component.ts#L15
error TS2449: Class 'ToggleComponent' used before its declaration.
- tabby-core/src/components/toggle.component.ts#L16

tabby-settings/tsconfig.json

error TS2449: Class 'CheckboxComponent' used before its declaration.
- tabby-core/src/components/checkbox.component.ts#L15
error TS2449: Class 'ToggleComponent' used before its declaration.
- tabby-core/src/components/toggle.component.ts#L16

tabby-serial/tsconfig.json

error TS2449: Class 'CheckboxComponent' used before its declaration.
- tabby-core/src/components/checkbox.component.ts#L15
error TS2449: Class 'ToggleComponent' used before its declaration.
- tabby-core/src/components/toggle.component.ts#L16

tabby-plugin-manager/tsconfig.json

error TS2449: Class 'CheckboxComponent' used before its declaration.
- tabby-core/src/components/checkbox.component.ts#L15
error TS2449: Class 'ToggleComponent' used before its declaration.
- tabby-core/src/components/toggle.component.ts#L16

tabby-local/tsconfig.json

error TS2449: Class 'CheckboxComponent' used before its declaration.
- tabby-core/src/components/checkbox.component.ts#L15
error TS2449: Class 'ToggleComponent' used before its declaration.
- tabby-core/src/components/toggle.component.ts#L16

tabby-linkifier/tsconfig.json

error TS2449: Class 'CheckboxComponent' used before its declaration.
- tabby-core/src/components/checkbox.component.ts#L15
error TS2449: Class 'ToggleComponent' used before its declaration.
- tabby-core/src/components/toggle.component.ts#L16

tabby-electron/tsconfig.json

error TS2449: Class 'CheckboxComponent' used before its declaration.
- tabby-core/src/components/checkbox.component.ts#L15
error TS2449: Class 'ToggleComponent' used before its declaration.
- tabby-core/src/components/toggle.component.ts#L16

tabby-core/tsconfig.typings.json

error TS2449: Class 'CheckboxComponent' used before its declaration.
- tabby-core/src/components/checkbox.component.ts#L15
error TS2449: Class 'ToggleComponent' used before its declaration.
- tabby-core/src/components/toggle.component.ts#L16

tabby-core/tsconfig.json

error TS2449: Class 'CheckboxComponent' used before its declaration.
- tabby-core/src/components/checkbox.component.ts#L15
error TS2449: Class 'ToggleComponent' used before its declaration.
- tabby-core/src/components/toggle.component.ts#L16

tabby-community-color-schemes/tsconfig.json

error TS2449: Class 'CheckboxComponent' used before its declaration.
- tabby-core/src/components/checkbox.component.ts#L15
error TS2449: Class 'ToggleComponent' used before its declaration.
- tabby-core/src/components/toggle.component.ts#L16

gabritto

(1) I don't exactly understand how the code change is related to the observed behavior in the repro, if you could provide an explanation that would be very helpful.
(2) There were test changes that I also don't know how they relate to the code change, so would be nice to get an explanation for those too (even if they're bugs). Thanks!

…ject-flags-propagation # Conflicts: # tests/baselines/reference/typedefCrossModule2.types

Andarist · 2024-04-07T06:35:39Z

IIRC those flags affect isPerformingExcessPropertyChecks. The adjusted code is in getInitializerTypeFromAssignmentDeclaration - this call happens in getWidenedTypeForAssignmentDeclaration and is followed by getWidenedType. To do the widening we need getObjectFlags(type) & ObjectFlags.RequiresWidening and that's what was wrong - the type was never widened so later on (in another module! where the affected type was included as part of something else) isPerformingExcessPropertyChecks was true where it should be false
the in-repo change looks like being related to type inference for object literals. It looks like a correct change to me - it now benefits from this since we are correctly propagating those literal flags. As to the webpack's change from this comment - I'm not sure yet. I just synced with main, could we rerun those tests to get a confirmation that nothing wonky is happening with that report (I'm not sure how likely that is with the current infra)? If it comes back with this error again then I'll happily investigate this (cc @jakebailey )

gabritto · 2024-04-08T18:31:06Z

According to Jake, the extended tests use the latest main, so the not-synced PR shouldn't be a problem, but I can try running again.

gabritto · 2024-04-08T18:31:15Z

@typescript-bot test it

typescript-bot · 2024-04-08T18:31:18Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

jakebailey · 2024-04-08T18:33:23Z

My impression at the moment is that the CFA change introduced some non-determinism; that same error went away in that change and is now back again.

typescript-bot · 2024-04-08T19:04:16Z

Hey @gabritto, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-04-08T19:14:22Z

@gabritto
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,779k (± 0.01%)}	_{295,765k (± 0.00%)}	_~	_295,754k	_295,779k	_{p=0.173 n=6}
_{Parse Time}	_{2.66s (± 0.31%)}	_{2.66s (± 0.19%)}	_~	_2.65s	_2.66s	_{p=0.929 n=6}
_{Bind Time}	_{0.83s (± 1.48%)}	_{0.81s (± 0.00%)}	_{-0.02s (- 1.82%)}	_0.81s	_0.81s	_{p=0.027 n=6}
_{Check Time}	_{8.20s (± 0.28%)}	_{8.20s (± 0.36%)}	_~	_8.16s	_8.24s	_{p=0.808 n=6}
_{Emit Time}	_{7.04s (± 0.37%)}	_{7.07s (± 0.21%)}	_{+0.04s (+ 0.52%)}	_7.06s	_7.10s	_{p=0.035 n=6}
_{Total Time}	_{18.72s (± 0.28%)}	_{18.74s (± 0.11%)}	_~	_18.70s	_18.76s	_{p=0.519 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{194,048k (± 0.95%)}	_{192,245k (± 0.78%)}	_~	_191,585k	_195,319k	_{p=0.092 n=6}
_{Parse Time}	_{2.03s (± 1.80%)}	_{2.02s (± 1.29%)}	_~	_1.99s	_2.05s	_{p=0.626 n=6}
_{Bind Time}	_{1.06s (± 1.03%)}	_{1.06s (± 0.71%)}	_~	_1.05s	_1.07s	_{p=0.865 n=6}
_{Check Time}	_{13.86s (± 0.26%)}	_{13.83s (± 0.47%)}	_~	_13.71s	_13.90s	_{p=0.519 n=6}
_{Emit Time}	_{3.85s (± 0.54%)}	_{3.85s (± 0.60%)}	_~	_3.81s	_3.87s	_{p=0.805 n=6}
_{Total Time}	_{20.80s (± 0.24%)}	_{20.76s (± 0.27%)}	_~	_20.67s	_20.83s	_{p=0.295 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,687k (± 0.00%)}	_{347,704k (± 0.00%)}	_~	_347,692k	_347,716k	_{p=0.066 n=6}
_{Parse Time}	_{2.99s (± 0.47%)}	_{2.99s (± 0.41%)}	_~	_2.98s	_3.01s	_{p=0.615 n=6}
_{Bind Time}	_{1.07s (± 0.70%)}	_{1.07s (± 0.70%)}	_~	_1.06s	_1.08s	_{p=1.000 n=6}
_{Check Time}	_{8.18s (± 0.17%)}	_{8.20s (± 0.41%)}	_~	_8.14s	_8.22s	_{p=0.257 n=6}
_{Emit Time}	_{4.84s (± 0.38%)}	_{4.85s (± 0.50%)}	_~	_4.82s	_4.89s	_{p=1.000 n=6}
_{Total Time}	_{17.08s (± 0.25%)}	_{17.11s (± 0.18%)}	_~	_17.06s	_17.15s	_{p=0.226 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,546k (± 0.01%)}	_{302,550k (± 0.01%)}	_~	_302,521k	_302,583k	_{p=0.936 n=6}
_{Parse Time}	_{2.98s (± 0.62%)}	_{2.95s (± 0.54%)}	_{-0.03s (- 1.01%)}	_2.93s	_2.97s	_{p=0.023 n=6}
_{Bind Time}	_{1.44s (± 0.57%)}	_{1.43s (± 0.73%)}	_~	_1.42s	_1.45s	_{p=0.865 n=6}
_{Check Time}	_{9.18s (± 0.52%)}	_{9.17s (± 0.36%)}	_~	_9.11s	_9.21s	_{p=0.746 n=6}
_{Emit Time}	_{5.32s (± 0.54%)}	_{5.30s (± 0.86%)}	_~	_5.23s	_5.35s	_{p=0.687 n=6}
_{Total Time}	_{18.91s (± 0.33%)}	_{18.85s (± 0.31%)}	_~	_18.79s	_18.94s	_{p=0.149 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{510,604k (± 0.01%)}	_{510,578k (± 0.01%)}	_~	_510,542k	_510,616k	_{p=0.471 n=6}
_{Parse Time}	_{3.93s (± 0.30%)}	_{3.94s (± 0.31%)}	_~	_3.92s	_3.95s	_{p=0.306 n=6}
_{Bind Time}	_{1.44s (± 0.62%)}	_{1.45s (± 0.36%)}	_~	_1.44s	_1.45s	_{p=0.190 n=6}
_{Check Time}	_{25.27s (± 0.28%)}	_{25.18s (± 0.30%)}	_{-0.09s (- 0.34%)}	_25.06s	_25.27s	_{p=0.036 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{30.64s (± 0.22%)}	_{30.56s (± 0.26%)}	_~	_30.44s	_30.67s	_{p=0.127 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,743,874k (± 0.00%)}	_{1,743,906k (± 0.00%)}	_~	_1,743,873k	_1,743,956k	_{p=0.173 n=6}
_{Parse Time}	_{9.62s (± 0.17%)}	_{9.68s (± 0.66%)}	_{+0.06s (+ 0.66%)}	_9.62s	_9.79s	_{p=0.023 n=6}
_{Bind Time}	_{3.40s (± 0.82%)}	_{3.41s (± 0.74%)}	_~	_3.36s	_3.43s	_{p=0.684 n=6}
_{Check Time}	_{81.28s (± 0.43%)}	_{81.24s (± 0.43%)}	_~	_80.85s	_81.82s	_{p=0.748 n=6}
_{Emit Time}	_{0.19s (± 2.67%)}	_{0.19s (± 2.67%)}	_~	_0.19s	_0.20s	_{p=1.000 n=6}
_{Total Time}	_{94.49s (± 0.37%)}	_{94.52s (± 0.40%)}	_~	_94.03s	_95.13s	_{p=0.936 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,299,047k (± 0.03%)}	_{2,299,290k (± 0.04%)}	_~	_2,298,157k	_2,300,212k	_{p=0.689 n=6}
_{Parse Time}	_{6.03s (± 0.63%)}	_{6.03s (± 0.63%)}	_~	_5.99s	_6.09s	_{p=1.000 n=6}
_{Bind Time}	_{2.23s (± 1.39%)}	_{2.22s (± 0.66%)}	_~	_2.20s	_2.24s	_{p=0.745 n=6}
_{Check Time}	_{39.47s (± 0.30%)}	_{39.43s (± 0.39%)}	_~	_39.17s	_39.63s	_{p=0.689 n=6}
_{Emit Time}	_{3.15s (± 3.37%)}	_{3.11s (± 2.77%)}	_~	_3.01s	_3.20s	_{p=0.575 n=6}
_{Total Time}	_{50.88s (± 0.35%)}	_{50.81s (± 0.32%)}	_~	_50.56s	_51.03s	_{p=0.471 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_{Memory used}	_{2,372,557k (± 0.03%)}	_{2,373,103k (± 0.04%)}	_~	_2,371,928k	_2,374,728k	_{p=0.298 n=6}
_{Parse Time}	_{5.18s (± 0.79%)}	_{5.14s (± 1.12%)}	_~	_5.06s	_5.23s	_{p=0.173 n=6}
_{Bind Time}	_{1.69s (± 0.89%)}	_{1.70s (± 0.78%)}	_~	_1.68s	_1.72s	_{p=0.213 n=6}
_{Check Time}	_{33.91s (± 0.28%)}	_{33.95s (± 0.43%)}	_~	_33.82s	_34.15s	_{p=0.873 n=6}
_{Emit Time}	_{2.69s (± 2.05%)}	_{2.66s (± 2.32%)}	_~	_2.58s	_2.74s	_{p=0.378 n=6}
_{Total Time}	_{43.49s (± 0.24%)}	_{43.46s (± 0.26%)}	_~	_43.29s	_43.61s	_{p=0.748 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{418,118k (± 0.01%)}	_{418,095k (± 0.01%)}	_~	_418,061k	_418,142k	_{p=0.230 n=6}
_{Parse Time}	_{3.36s (± 0.72%)}	_{3.37s (± 0.80%)}	_~	_3.33s	_3.41s	_{p=0.374 n=6}
_{Bind Time}	_{1.30s (± 1.37%)}	_{1.28s (± 1.62%)}	_~	_1.25s	_1.31s	_{p=0.060 n=6}
_{Check Time}	_{17.83s (± 0.39%)}	_{17.78s (± 0.30%)}	_~	_17.72s	_17.86s	_{p=0.198 n=6}
_{Emit Time}	_{1.39s (± 0.87%)}	_{1.37s (± 1.50%)}	_~	_1.34s	_1.40s	_{p=0.216 n=6}
_{Total Time}	_{23.88s (± 0.35%)}	_{23.80s (± 0.26%)}	_~	_23.72s	_23.88s	_{p=0.127 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,903,999k (± 0.00%)}	_{2,904,024k (± 0.00%)}	_~	_2,903,970k	_2,904,080k	_{p=0.230 n=6}
_{Parse Time}	_{15.91s (± 0.36%)}	_{15.95s (± 0.22%)}	_~	_15.91s	_15.99s	_{p=0.145 n=6}
_{Bind Time}	_{4.88s (± 0.44%)}	_{4.91s (± 0.31%)}	_{+0.03s (+ 0.65%)}	_4.88s	_4.92s	_{p=0.023 n=6}
_{Check Time}	_{86.13s (± 0.14%)}	_{86.11s (± 0.46%)}	_~	_85.75s	_86.75s	_{p=0.630 n=6}
_{Emit Time}	_{23.77s (± 0.56%)}	_{23.62s (± 0.48%)}	_~	_23.47s	_23.74s	_{p=0.149 n=6}
_{Total Time}	_{130.69s (± 0.16%)}	_{130.59s (± 0.32%)}	_~	_130.05s	_131.12s	_{p=0.471 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{408,691k (± 0.01%)}	_{408,736k (± 0.03%)}	_~	_408,601k	_408,892k	_{p=0.810 n=6}
_{Parse Time}	_{4.78s (± 1.00%)}	_{4.81s (± 0.70%)}	_~	_4.79s	_4.87s	_{p=0.514 n=6}
_{Bind Time}	_{2.03s (± 0.86%)}	_{2.02s (± 0.60%)}	_~	_2.01s	_2.04s	_{p=0.620 n=6}
_{Check Time}	_{20.70s (± 0.35%)}	_{20.66s (± 0.40%)}	_~	_20.58s	_20.80s	_{p=0.520 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{27.50s (± 0.20%)}	_{27.49s (± 0.38%)}	_~	_27.40s	_27.68s	_{p=0.296 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{514,445k (± 0.01%)}	_{514,519k (± 0.01%)}	_~	_514,487k	_514,561k	_{p=0.066 n=6}
_{Parse Time}	_{4.91s (± 0.33%)}	_{4.90s (± 0.71%)}	_~	_4.84s	_4.94s	_{p=0.868 n=6}
_{Bind Time}	_{2.31s (± 0.89%)}	_{2.30s (± 1.72%)}	_~	_2.26s	_2.36s	_{p=0.685 n=6}
_{Check Time}	_{4.24s (± 0.95%)}	_{4.26s (± 1.01%)}	_~	_4.19s	_4.30s	_{p=0.419 n=6}
_{Emit Time}	_{0.11s (± 4.55%)}	_{0.12s (± 4.42%)}	_~	_0.11s	_0.12s	_{p=0.311 n=6}
_{Total Time}	_{11.57s (± 0.37%)}	_{11.58s (± 0.49%)}	_~	_11.47s	_11.62s	_{p=0.520 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-04-08T19:14:50Z

@gabritto Here are the results of running the user tests comparing main and refs/pull/57467/merge:

Everything looks good!

typescript-bot · 2024-04-08T20:29:14Z

@gabritto Here are the results of running the top 400 repos comparing main and refs/pull/57467/merge:

Everything looks good!

Andarist · 2024-04-08T21:38:22Z

Something weird is happening with those tests but I think it's fair to say that it's not related to this PR 😉

jakebailey · 2024-04-16T18:42:41Z

This PR was out of date and broke main.

gabritto · 2024-04-16T18:46:10Z

This PR was out of date and broke main.

I'll fix it now

Propagate object flags related to object and array literals onto `mod…

851b28d

…ule.exports` types

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Feb 21, 2024

Andarist mentioned this pull request Feb 21, 2024

Untyped JS module is not assignable to type even though it satisfies it #57460

Closed

add a test case

ce26590

Andarist marked this pull request as ready for review February 21, 2024 23:04

sandersn added this to Not started in PR Backlog Mar 8, 2024

sandersn requested review from sandersn and gabritto March 8, 2024 23:02

typescript-bot removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 8, 2024

sandersn assigned gabritto Mar 8, 2024

typescript-bot added For Backlog Bug PRs that fix a backlog bug labels Mar 8, 2024

sandersn moved this from Not started to Waiting on reviewers in PR Backlog Mar 8, 2024

gabritto requested changes Apr 5, 2024

View reviewed changes

PR Backlog automation moved this from Waiting on reviewers to Waiting on author Apr 5, 2024

Merge remote-tracking branch 'origin/main' into fix/module-exports-ob…

451824a

…ject-flags-propagation # Conflicts: # tests/baselines/reference/typedefCrossModule2.types

Andarist requested a review from gabritto April 8, 2024 21:38

gabritto approved these changes Apr 16, 2024

View reviewed changes

PR Backlog automation moved this from Waiting on author to Needs merge Apr 16, 2024

gabritto merged commit fb1b26c into microsoft:main Apr 16, 2024
25 checks passed

PR Backlog automation moved this from Needs merge to Done Apr 16, 2024

Andarist deleted the fix/module-exports-object-flags-propagation branch April 16, 2024 19:21

Propagate object flags related to object and array literals onto module.exports types #57467

Propagate object flags related to object and array literals onto module.exports types #57467

Conversation

Andarist commented Feb 21, 2024

gabritto commented Apr 5, 2024

typescript-bot commented Apr 5, 2024 • edited Loading

typescript-bot commented Apr 5, 2024

typescript-bot commented Apr 5, 2024

tsc

typescript-bot commented Apr 5, 2024

typescript-bot commented Apr 5, 2024

gabritto left a comment

Choose a reason for hiding this comment

Andarist commented Apr 7, 2024 • edited Loading

gabritto commented Apr 8, 2024

gabritto commented Apr 8, 2024

typescript-bot commented Apr 8, 2024 • edited Loading

jakebailey commented Apr 8, 2024

typescript-bot commented Apr 8, 2024

typescript-bot commented Apr 8, 2024

tsc

typescript-bot commented Apr 8, 2024

typescript-bot commented Apr 8, 2024

Andarist commented Apr 8, 2024

jakebailey commented Apr 16, 2024

gabritto commented Apr 16, 2024

Propagate object flags related to object and array literals onto `module.exports` types #57467

Propagate object flags related to object and array literals onto `module.exports` types #57467

typescript-bot commented Apr 5, 2024 •

edited

Loading

Andarist commented Apr 7, 2024 •

edited

Loading

typescript-bot commented Apr 8, 2024 •

edited

Loading