Error on types named "undefined" #57575

jakebailey · 2024-02-28T17:03:16Z

This makes us error on types named undefined in the same way we do keyword types. Though undefined is not a keyword, it is a keyword in type space.

jakebailey · 2024-02-28T17:03:29Z

@typescript-bot test top400
@typescript-bot user test this
@typescript-bot run dt

typescript-bot · 2024-02-28T17:03:31Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 7e0ddf4. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-02-28T17:03:31Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 7e0ddf4. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-02-28T17:03:32Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 7e0ddf4. You can monitor the build here.

Update: The results are in!

dragomirtitian · 2024-02-28T17:20:41Z

Sorta curious how many people are affected.

(see #57573)

Hopefully nobody 😅

typescript-bot · 2024-02-28T17:21:56Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/57575/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L13 in packages/browsers/test/src/tsconfig.json

jakebailey · 2024-02-28T17:23:06Z

FWIW the way I wanted to implement this was "if you see an undefined Identifier in type space (besides a typeof), error", but couldn't figure out the best way to do that, so I just threw errors onto everything that introduced a name to type space instead...

typescript-bot · 2024-02-28T17:38:35Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2024-02-28T18:59:41Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/57575/merge:

Everything looks good!

jakebailey · 2024-02-28T19:26:59Z

Good, nobody!

jakebailey · 2024-02-28T22:34:44Z

Well, given #57573 is now effectively accepted, I guess I'll clean this up?

jakebailey · 2024-02-28T23:08:04Z

Apparently I'm dumb and didn't realize that we already issue this error:

==== undefinedTypeAssignment4.ts (6 errors) ====
    class undefined {
         ~~~~~~~~~~
!!! error TS2397: Declaration name conflicts with built-in global identifier 'undefined'.
          ~~~~~~~~~
!!! error TS2397: Declaration name conflicts with built-in global identifier 'undefined'.
    	foo: string;
    }
    interface undefined {

I just added a duplicate one. The actual problem are the other ones we're missing.

jakebailey · 2024-02-28T23:14:02Z

Yeah, I did not test what I thought I was.

jakebailey · 2024-02-28T23:26:24Z

Okay, I sorta tested the right thing. This check is duplicative, but I didn't ignore this in globals, so I did actually check the right thing, kinda.

jakebailey · 2024-02-29T00:00:38Z

@typescript-bot test top400
@typescript-bot user test this
@typescript-bot run dt

typescript-bot · 2024-02-29T00:00:40Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at b376d0b. You can monitor the build here.

Update: The results are in!

jakebailey · 2024-03-01T19:26:45Z

Okay, this should be ready. Removed the namespace stuff as discussed.

jakebailey · 2024-03-01T19:43:46Z

@typescript-bot test top400
@typescript-bot user test this
@typescript-bot run dt

@typescript-bot perf test this faster
@typescript-bot pack this

typescript-bot · 2024-03-01T19:43:50Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 7b80d7a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-03-01T19:43:50Z

Heya @jakebailey, I've started to run the faster perf test suite on this PR at 7b80d7a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-03-01T19:43:50Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 7b80d7a. You can monitor the build here.

typescript-bot · 2024-03-01T19:43:50Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 7b80d7a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-03-01T19:43:50Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 7b80d7a. You can monitor the build here.

jakebailey · 2024-03-01T19:44:45Z

src/compiler/checker.ts

@@ -2720,20 +2717,19 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
        }
    }

-    function addToSymbolTable(target: SymbolTable, source: SymbolTable, message: DiagnosticMessage) {


I opted to eliminate builtinGlobals while here; its only use is to complain about undefined, but now we're going to complain even less and the new code had to exclude type declarations anyway.

typescript-bot · 2024-03-01T19:45:48Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/160140/artifacts?artifactName=tgz&fileId=A08C03FF21AB9BAC355C636691B79EDA68D4896F6685371FEA3779F5838F653802&fileName=/typescript-5.5.0-insiders.20240301.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.5.0-pr-57575-41".;

typescript-bot · 2024-03-01T20:15:21Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2024-03-01T20:32:27Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,571k (± 0.01%)}	_{295,564k (± 0.01%)}	_~	_295,531k	_295,578k	_{p=0.471 n=6}
_{Parse Time}	_{2.66s (± 0.15%)}	_{2.66s (± 0.37%)}	_~	_2.65s	_2.67s	_{p=0.930 n=6}
_{Bind Time}	_{0.82s (± 0.50%)}	_{0.82s (± 0.63%)}	_~	_0.82s	_0.83s	_{p=0.595 n=6}
_{Check Time}	_{8.22s (± 0.45%)}	_{8.21s (± 0.24%)}	_~	_8.19s	_8.24s	_{p=0.334 n=6}
_{Emit Time}	_{7.11s (± 0.48%)}	_{7.11s (± 0.29%)}	_~	_7.09s	_7.15s	_{p=0.745 n=6}
_{Total Time}	_{18.83s (± 0.26%)}	_{18.81s (± 0.19%)}	_~	_18.78s	_18.88s	_{p=0.806 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,222k (± 1.00%)}	_{192,093k (± 0.73%)}	_~	_191,419k	_194,945k	_{p=0.471 n=6}
_{Parse Time}	_{1.36s (± 1.02%)}	_{1.36s (± 0.72%)}	_~	_1.35s	_1.38s	_{p=0.203 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.36s (± 0.73%)}	_{9.38s (± 0.67%)}	_~	_9.30s	_9.49s	_{p=0.688 n=6}
_{Emit Time}	_{2.60s (± 0.62%)}	_{2.61s (± 0.45%)}	_~	_2.59s	_2.62s	_{p=0.359 n=6}
_{Total Time}	_{14.05s (± 0.62%)}	_{14.07s (± 0.51%)}	_~	_13.98s	_14.19s	_{p=0.630 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,340k (± 0.00%)}	_{347,335k (± 0.01%)}	_~	_347,296k	_347,371k	_{p=0.810 n=6}
_{Parse Time}	_{2.48s (± 0.66%)}	_{2.48s (± 0.40%)}	_~	_2.47s	_2.49s	_{p=0.557 n=6}
_{Bind Time}	_{0.93s (± 0.59%)}	_{0.92s (± 0.59%)}	_~	_0.92s	_0.93s	_{p=1.000 n=6}
_{Check Time}	_{6.94s (± 0.44%)}	_{6.93s (± 0.27%)}	_~	_6.90s	_6.95s	_{p=0.467 n=6}
_{Emit Time}	_{4.07s (± 0.31%)}	_{4.08s (± 0.31%)}	_~	_4.06s	_4.09s	_{p=0.211 n=6}
_{Total Time}	_{14.41s (± 0.32%)}	_{14.42s (± 0.16%)}	_~	_14.39s	_14.45s	_{p=0.872 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,757k (± 0.00%)}	_{302,766k (± 0.01%)}	_~	_302,739k	_302,784k	_{p=0.149 n=6}
_{Parse Time}	_{2.01s (± 0.63%)}	_{2.01s (± 0.52%)}	_~	_2.00s	_2.03s	_{p=0.615 n=6}
_{Bind Time}	_{1.00s (± 0.55%)}	_{1.01s (± 1.73%)}	_{+0.02s (+ 2.01%)}	_1.00s	_1.05s	_{p=0.007 n=6}
_{Check Time}	_{6.35s (± 0.22%)}	_{6.35s (± 0.44%)}	_~	_6.32s	_6.39s	_{p=1.000 n=6}
_{Emit Time}	_{3.60s (± 0.60%)}	_{3.61s (± 0.54%)}	_~	_3.57s	_3.62s	_{p=0.418 n=6}
_{Total Time}	_{12.95s (± 0.27%)}	_{12.99s (± 0.34%)}	_~	_12.93s	_13.03s	_{p=0.195 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{511,206k (± 0.01%)}	_{511,197k (± 0.00%)}	_~	_511,172k	_511,228k	_{p=0.575 n=6}
_{Parse Time}	_{2.65s (± 0.57%)}	_{2.65s (± 0.52%)}	_~	_2.63s	_2.67s	_{p=1.000 n=6}
_{Bind Time}	_{0.99s (± 0.76%)}	_{0.98s (± 0.83%)}	_~	_0.97s	_0.99s	_{p=0.120 n=6}
_{Check Time}	_{17.28s (± 0.32%)}	_{17.27s (± 0.45%)}	_~	_17.19s	_17.39s	_{p=0.808 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.92s (± 0.31%)}	_{20.91s (± 0.40%)}	_~	_20.79s	_21.02s	_{p=0.872 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{2,295,511k (± 0.00%)}	_{2,295,510k (± 0.00%)}	_~	_2,295,480k	_2,295,548k	_{p=1.000 n=6}
_{Parse Time}	_{11.97s (± 0.97%)}	_{11.97s (± 0.64%)}	_~	_11.88s	_12.09s	_{p=0.810 n=6}
_{Bind Time}	_{2.65s (± 0.15%)}	_{2.65s (± 0.21%)}	_~	_2.64s	_2.65s	_{p=0.282 n=6}
_{Check Time}	_{101.58s (± 0.56%)}	_{101.33s (± 0.69%)}	_~	_100.38s	_102.40s	_{p=0.471 n=6}
_{Emit Time}	_{0.32s (± 0.00%)}	_{0.32s (± 1.27%)}	_~	_0.32s	_0.33s	_{p=0.405 n=6}
_{Total Time}	_{116.51s (± 0.46%)}	_{116.27s (± 0.56%)}	_~	_115.43s	_117.29s	_{p=0.575 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,395,105k (± 0.01%)}	_{2,394,710k (± 0.02%)}	_~	_2,394,186k	_2,395,572k	_{p=0.173 n=6}
_{Parse Time}	_{5.05s (± 0.81%)}	_{5.04s (± 0.32%)}	_~	_5.01s	_5.05s	_{p=0.936 n=6}
_{Bind Time}	_{1.88s (± 0.48%)}	_{1.89s (± 0.97%)}	_~	_1.87s	_1.92s	_{p=0.284 n=6}
_{Check Time}	_{33.36s (± 0.27%)}	_{33.55s (± 0.32%)}	_{+0.19s (+ 0.57%)}	_33.44s	_33.70s	_{p=0.013 n=6}
_{Emit Time}	_{2.69s (± 1.12%)}	_{2.69s (± 1.30%)}	_~	_2.63s	_2.73s	_{p=0.575 n=6}
_{Total Time}	_{43.01s (± 0.15%)}	_{43.18s (± 0.22%)}	_{+0.17s (+ 0.40%)}	_43.03s	_43.29s	_{p=0.020 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{414,367k (± 0.01%)}	_{414,366k (± 0.01%)}	_~	_414,332k	_414,448k	_{p=0.810 n=6}
_{Parse Time}	_{2.80s (± 0.89%)}	_{2.78s (± 1.75%)}	_~	_2.71s	_2.85s	_{p=0.746 n=6}
_{Bind Time}	_{1.06s (± 0.38%)}	_{1.09s (± 5.32%)}	_{+0.03s (+ 2.83%)}	_1.06s	_1.21s	_{p=0.033 n=6}
_{Check Time}	_{15.11s (± 0.44%)}	_{15.12s (± 0.46%)}	_~	_15.01s	_15.21s	_{p=0.810 n=6}
_{Emit Time}	_{1.11s (± 0.68%)}	_{1.11s (± 1.39%)}	_~	_1.09s	_1.12s	_{p=0.796 n=6}
_{Total Time}	_{20.08s (± 0.38%)}	_{20.10s (± 0.54%)}	_~	_19.96s	_20.25s	_{p=0.689 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,854,203k (± 0.00%)}	_{2,854,196k (± 0.00%)}	_~	_2,854,165k	_2,854,239k	_{p=0.936 n=6}
_{Parse Time}	_{10.78s (± 0.32%)}	_{10.74s (± 0.26%)}	_~	_10.70s	_10.78s	_{p=0.107 n=6}
_{Bind Time}	_{3.42s (± 0.22%)}	_{3.43s (± 0.22%)}	_~	_3.42s	_3.44s	_{p=0.062 n=6}
_{Check Time}	_{60.79s (± 0.49%)}	_{60.82s (± 0.47%)}	_~	_60.53s	_61.29s	_{p=0.810 n=6}
_{Emit Time}	_{16.24s (± 0.68%)}	_{16.20s (± 0.66%)}	_~	_16.04s	_16.32s	_{p=0.471 n=6}
_{Total Time}	_{91.23s (± 0.40%)}	_{91.20s (± 0.37%)}	_~	_90.82s	_91.74s	_{p=0.936 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{396,845k (± 0.03%)}	_{396,841k (± 0.01%)}	_~	_396,782k	_396,891k	_{p=0.810 n=6}
_{Parse Time}	_{3.13s (± 0.89%)}	_{3.14s (± 0.62%)}	_~	_3.11s	_3.16s	_{p=0.685 n=6}
_{Bind Time}	_{1.37s (± 1.07%)}	_{1.38s (± 0.76%)}	_~	_1.37s	_1.40s	_{p=0.073 n=6}
_{Check Time}	_{13.98s (± 0.15%)}	_{13.97s (± 0.29%)}	_~	_13.92s	_14.04s	_{p=0.332 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.48s (± 0.25%)}	_{18.49s (± 0.21%)}	_~	_18.42s	_18.54s	_{p=0.872 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,147k (± 0.00%)}	_{513,186k (± 0.01%)}	_~	_513,095k	_513,295k	_{p=0.298 n=6}
_{Parse Time}	_{3.27s (± 0.30%)}	_{3.27s (± 0.25%)}	_~	_3.26s	_3.28s	_{p=0.862 n=6}
_{Bind Time}	_{1.54s (± 0.49%)}	_{1.54s (± 0.54%)}	_~	_1.52s	_1.54s	_{p=0.652 n=6}
_{Check Time}	_{2.86s (± 0.51%)}	_{2.87s (± 0.48%)}	_~	_2.85s	_2.89s	_{p=0.255 n=6}
_{Emit Time}	_{0.08s (± 4.99%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=0.405 n=6}
_{Total Time}	_{7.75s (± 0.15%)}	_{7.76s (± 0.15%)}	_~	_7.75s	_7.78s	_{p=0.217 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-03-01T21:36:00Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/57575/merge:

Everything looks good!

jakebailey · 2024-03-02T01:02:29Z

Abusing this PR to try out a cherry-pick with the new bot.

@typescript-bot cherry-pick this to release-5.4

typescript-bot · 2024-03-02T01:02:32Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`cherry-pick this to release-5.4`	✅ Started	✅ Results

typescript-bot · 2024-03-02T01:04:47Z

Hey, @jakebailey! I've created #57610 for you.

src/compiler/checker.ts

typescript-bot assigned jakebailey Feb 28, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Feb 28, 2024

jakebailey added 2 commits February 28, 2024 15:29

Add test

358ab6e

New error

9fed7d1

jakebailey force-pushed the ban-undefined branch from 7e0ddf4 to 9fed7d1 Compare February 28, 2024 23:48

jakebailey added 2 commits February 28, 2024 15:48

Oops

328be7b

Oops

6206462

This comment was marked as outdated.

Sign in to view

Error like other keywords, though undefined is not a keyword

b376d0b

jakebailey changed the title ~~Error on new type-ish names named undefined~~ Error on types named "undefined" like type keywords Feb 29, 2024

Revert namespace

886a41e

jakebailey marked this pull request as ready for review March 1, 2024 19:26

Eliminate builtinGlobals

7b80d7a

jakebailey commented Mar 1, 2024

View reviewed changes

DanielRosenwasser mentioned this pull request Mar 1, 2024

Design Meeting Notes, 3/1/2024 #57599

Closed

typescript-bot mentioned this pull request Mar 2, 2024

🤖 Pick PR #57575 (Error on types named "undefined") into release-5.4 #57610

Closed

sandersn added this to Not started in PR Backlog Mar 8, 2024

jakebailey moved this from Not started to Waiting on reviewers in PR Backlog Mar 8, 2024

weswigham approved these changes Mar 9, 2024

View reviewed changes

PR Backlog automation moved this from Waiting on reviewers to Needs merge Mar 9, 2024

jakebailey added the Breaking Change Would introduce errors in existing code label Mar 11, 2024

jakebailey commented Mar 11, 2024

View reviewed changes

src/compiler/checker.ts Show resolved Hide resolved

Small comment tweak to reflect final state

49fa5c2

jakebailey merged commit e24d886 into microsoft:main Mar 11, 2024
19 checks passed

PR Backlog automation moved this from Needs merge to Done Mar 11, 2024

jakebailey deleted the ban-undefined branch March 11, 2024 16:41

Error on types named "undefined" #57575

Error on types named "undefined" #57575

Conversation

jakebailey commented Feb 28, 2024 • edited Loading

jakebailey commented Feb 28, 2024

typescript-bot commented Feb 28, 2024 • edited Loading

typescript-bot commented Feb 28, 2024 • edited Loading

typescript-bot commented Feb 28, 2024 • edited Loading

dragomirtitian commented Feb 28, 2024

typescript-bot commented Feb 28, 2024

puppeteer

packages/browsers/test/src/tsconfig.json

jakebailey commented Feb 28, 2024

typescript-bot commented Feb 28, 2024

typescript-bot commented Feb 28, 2024

jakebailey commented Feb 28, 2024

jakebailey commented Feb 28, 2024

jakebailey commented Feb 28, 2024

jakebailey commented Feb 28, 2024

jakebailey commented Feb 28, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

jakebailey commented Feb 29, 2024

typescript-bot commented Feb 29, 2024 • edited Loading

jakebailey commented Mar 1, 2024

jakebailey commented Mar 1, 2024

typescript-bot commented Mar 1, 2024 • edited Loading

typescript-bot commented Mar 1, 2024 • edited Loading

typescript-bot commented Mar 1, 2024 • edited Loading

typescript-bot commented Mar 1, 2024 • edited Loading

typescript-bot commented Mar 1, 2024 • edited Loading

jakebailey Mar 1, 2024

Choose a reason for hiding this comment

typescript-bot commented Mar 1, 2024 • edited Loading

typescript-bot commented Mar 1, 2024

typescript-bot commented Mar 1, 2024

tsc

typescript-bot commented Mar 1, 2024

jakebailey commented Mar 2, 2024

typescript-bot commented Mar 2, 2024 • edited Loading

typescript-bot commented Mar 2, 2024

jakebailey commented Feb 28, 2024 •

edited

Loading

typescript-bot commented Feb 28, 2024 •

edited

Loading

typescript-bot commented Feb 28, 2024 •

edited

Loading

typescript-bot commented Feb 28, 2024 •

edited

Loading

typescript-bot commented Feb 29, 2024 •

edited

Loading

typescript-bot commented Mar 1, 2024 •

edited

Loading

typescript-bot commented Mar 1, 2024 •

edited

Loading

typescript-bot commented Mar 1, 2024 •

edited

Loading

typescript-bot commented Mar 1, 2024 •

edited

Loading

typescript-bot commented Mar 1, 2024 •

edited

Loading

typescript-bot commented Mar 1, 2024 •

edited

Loading

typescript-bot commented Mar 2, 2024 •

edited

Loading