Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Show preserved triple slash references in diagnostics for top200 analysis #57656

Conversation

andrewbranch
Copy link
Member

Counterpart of #57569

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 6, 2024
@andrewbranch
Copy link
Member Author

@typescript-bot test top200

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 6, 2024

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top200 ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

@andrewbranch Here are the results of running the top-repos suite comparing main and refs/pull/57656/merge:

Something interesting changed - please have a look.

Details

FuelLabs/fuels-ts

12 of 49 projects failed to build with the old tsc and were ignored

packages/abi-typegen/tsconfig.dts.json

packages/abi-typegen/tsconfig.json

packages/fuels/tsconfig.dts.json

@jakebailey
Copy link
Member

@typescript-bot test top400
@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 6, 2024

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started 👀 Results
user test this ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/57656/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/57656/merge:

Something interesting changed - please have a look.

Details

FuelLabs/fuels-ts

12 of 49 projects failed to build with the old tsc and were ignored

packages/abi-typegen/tsconfig.dts.json

packages/abi-typegen/tsconfig.json

packages/fuels/tsconfig.dts.json

jupyterlab/jupyterlab

48 of 59 projects failed to build with the old tsc and were ignored

packages/services/examples/browser/tsconfig.json

packages/services/examples/typescript-browser-with-output/tsconfig.json

packages/ui-components/examples/simple-windowed-list/tsconfig.json

galata/extension/tsconfig.json

galata/tsconfig.json

@jakebailey
Copy link
Member

The fuels-ts one emits a directive into the published package which doesn't actually exist. https://unpkg.com/browse/@fuel-ts/abi-typegen@0.76.0/dist/index.d.ts

@jakebailey
Copy link
Member

The jupyterlab one doesn't seem intentional, in that the package only dev deps on jest and there's a comment that says it's there for another reason. (I think normally such a reference would be elided if it were actually used elsewhere?)

In any case, these results are very good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants