Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for tsc --watch to stub out actual time #57936

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Conversation

sheetalkamat
Copy link
Member

We already changed this in tsserver but missed for tsc --watch where time is printed.
Any change that affects how modified times are done needs to update lots of baseline just because time changes without this change .

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 25, 2024
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we'll definitely have to be careful merging newer PRs

@sheetalkamat sheetalkamat merged commit a1c4732 into main Mar 25, 2024
25 checks passed
@sheetalkamat sheetalkamat deleted the watchTestsTimeStamp branch March 25, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants