Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(58151): JSDoc tags get lost when inheriting from a grandparent class #58183

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #58151

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Apr 13, 2024
@jakebailey
Copy link
Member

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 15, 2024

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
pack this ✅ Started ✅ Results

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 15, 2024

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/161230/artifacts?artifactName=tgz&fileId=E602DA071C02569BF78191AEDB3CA2DE2558216509C655DD6B7E3557DED530E202&fileName=/typescript-5.5.0-insiders.20240415.tgz"
    }
}

and then running npm install.


There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.5.0-pr-58183-2".;

Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to work, and makes sense to me.

@jakebailey jakebailey merged commit 4b01686 into microsoft:main Apr 15, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSDoc tags get lost when inheriting from a grandparent class
3 participants