Fixed intersections of primitive unions with exactOptionalPropertyTypes when mixing undefinedType with missingType

[Andarist]

fixes #58174

[jakebailey]

@typescript-bot test it

[typescript-bot]

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
test top400	✅ Started	✅ Results
user test this	✅ Started	✅ Results
run dt	✅ Started	✅ Results
perf test this faster	✅ Started	👀 Results

[typescript-bot]

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

[typescript-bot]

@jakebailey Here are the results of running the user tests comparing main and refs/pull/58186/merge:

Everything looks good!

[typescript-bot]

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

Metric	baseline	pr	Delta	Best	Worst	p-value
Angular - node (v18.15.0, x64)
Memory used	296,991k (± 0.00%)	296,992k (± 0.00%)	~	296,979k	297,020k	p=0.872 n=6
Parse Time	2.69s (± 0.30%)	2.71s (± 0.69%)	~	2.68s	2.73s	p=0.084 n=6
Bind Time	0.82s (± 0.50%)	0.82s (± 0.50%)	~	0.81s	0.82s	p=1.000 n=6
Check Time	8.31s (± 0.50%)	8.36s (± 0.23%)	+0.05s (+ 0.58%)	8.34s	8.39s	p=0.036 n=6
Emit Time	7.06s (± 0.53%)	7.05s (± 0.46%)	~	7.01s	7.10s	p=1.000 n=6
Total Time	18.88s (± 0.26%)	18.94s (± 0.27%)	~	18.86s	19.01s	p=0.054 n=6
Compiler-Unions - node (v18.15.0, x64)
Memory used	192,947k (± 0.96%)	192,408k (± 0.76%)	~	191,767k	195,398k	p=0.375 n=6
Parse Time	1.35s (± 0.81%)	1.36s (± 0.55%)	~	1.35s	1.37s	p=0.195 n=6
Bind Time	0.72s (± 0.00%)	0.72s (± 0.00%)	~	0.72s	0.72s	p=1.000 n=6
Check Time	9.53s (± 0.38%)	9.56s (± 0.24%)	~	9.53s	9.59s	p=0.089 n=6
Emit Time	2.63s (± 0.44%)	2.63s (± 0.42%)	~	2.61s	2.64s	p=0.557 n=6
Total Time	14.22s (± 0.32%)	14.27s (± 0.18%)	~	14.24s	14.30s	p=0.077 n=6
Monaco - node (v18.15.0, x64)
Memory used	348,858k (± 0.00%)	348,847k (± 0.00%)	~	348,842k	348,858k	p=0.225 n=6
Parse Time	2.54s (± 0.41%)	2.55s (± 0.48%)	~	2.53s	2.56s	p=0.868 n=6
Bind Time	0.89s (± 0.46%)	0.89s (± 0.58%)	~	0.88s	0.89s	p=0.114 n=6
Check Time	7.07s (± 0.52%)	7.04s (± 0.51%)	~	7.00s	7.09s	p=0.332 n=6
Emit Time	4.07s (± 0.34%)	4.06s (± 0.16%)	~	4.05s	4.07s	p=0.388 n=6
Total Time	14.57s (± 0.27%)	14.54s (± 0.23%)	~	14.51s	14.58s	p=0.169 n=6
TFS - node (v18.15.0, x64)
Memory used	302,955k (± 0.01%)	302,958k (± 0.00%)	~	302,941k	302,963k	p=0.872 n=6
Parse Time	2.97s (± 1.10%)	2.99s (± 1.26%)	~	2.96s	3.06s	p=0.572 n=6
Bind Time	1.44s (± 0.44%)	1.44s (± 0.36%)	~	1.44s	1.45s	p=0.386 n=6
Check Time	9.36s (± 0.41%)	9.39s (± 0.41%)	~	9.34s	9.44s	p=0.170 n=6
Emit Time	5.29s (± 0.52%)	5.30s (± 0.69%)	~	5.24s	5.34s	p=0.570 n=6
Total Time	19.06s (± 0.23%)	19.13s (± 0.38%)	~	19.06s	19.25s	p=0.106 n=6
material-ui - node (v18.15.0, x64)
Memory used	511,618k (± 0.01%)	511,607k (± 0.00%)	~	511,586k	511,620k	p=0.630 n=6
Parse Time	2.71s (± 0.62%)	2.70s (± 0.80%)	~	2.68s	2.74s	p=0.413 n=6
Bind Time	0.99s (± 1.18%)	0.99s (± 0.64%)	~	0.98s	1.00s	p=1.000 n=6
Check Time	17.29s (± 0.42%)	17.21s (± 0.29%)	~	17.15s	17.27s	p=0.078 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	20.99s (± 0.41%)	20.91s (± 0.16%)	~	20.86s	20.94s	p=0.108 n=6
mui-docs - node (v18.15.0, x64)
Memory used	1,748,685k (± 0.00%)	1,748,702k (± 0.00%)	~	1,748,660k	1,748,742k	p=0.575 n=6
Parse Time	9.99s (± 0.45%)	9.98s (± 0.89%)	~	9.90s	10.15s	p=0.334 n=6
Bind Time	3.36s (± 0.65%)	3.35s (± 0.58%)	~	3.33s	3.38s	p=0.466 n=6
Check Time	82.16s (± 0.57%)	82.03s (± 0.29%)	~	81.68s	82.36s	p=0.689 n=6
Emit Time	0.20s (± 6.32%)	0.20s (± 5.47%)	~	0.19s	0.22s	p=0.932 n=6
Total Time	95.70s (± 0.45%)	95.56s (± 0.24%)	~	95.33s	95.92s	p=0.810 n=6
self-build-src - node (v18.15.0, x64)
Memory used	2,306,473k (± 0.03%)	2,306,876k (± 0.04%)	~	2,306,189k	2,308,759k	p=1.000 n=6
Parse Time	7.39s (± 1.04%)	7.42s (± 0.39%)	~	7.38s	7.45s	p=0.572 n=6
Bind Time	2.73s (± 0.63%)	2.73s (± 0.97%)	~	2.69s	2.76s	p=0.936 n=6
Check Time	49.47s (± 0.47%)	49.15s (± 0.55%)	~	48.74s	49.51s	p=0.066 n=6
Emit Time	3.95s (± 0.91%)	3.94s (± 2.57%)	~	3.84s	4.12s	p=0.471 n=6
Total Time	63.54s (± 0.33%)	63.24s (± 0.45%)	-0.30s (- 0.48%)	62.71s	63.53s	p=0.045 n=6
self-build-src-public-api - node (v18.15.0, x64)
Memory used	2,381,804k (± 0.02%)	2,381,218k (± 0.04%)	~	2,380,513k	2,383,089k	p=0.128 n=6
Parse Time	6.17s (± 1.13%)	6.15s (± 0.98%)	~	6.08s	6.22s	p=0.471 n=6
Bind Time	2.06s (± 0.83%)	2.06s (± 1.47%)	~	2.04s	2.12s	p=0.462 n=6
Check Time	40.13s (± 0.26%)	40.12s (± 0.35%)	~	39.91s	40.31s	p=1.000 n=6
Emit Time	3.18s (± 2.63%)	3.21s (± 1.61%)	~	3.11s	3.25s	p=0.423 n=6
Total Time	51.55s (± 0.34%)	51.54s (± 0.23%)	~	51.38s	51.70s	p=1.000 n=6
self-compiler - node (v18.15.0, x64)
Memory used	419,126k (± 0.02%)	419,140k (± 0.03%)	~	419,079k	419,367k	p=1.000 n=6
Parse Time	4.16s (± 2.12%)	4.18s (± 2.24%)	~	3.99s	4.23s	p=0.106 n=6
Bind Time	1.63s (± 2.82%)	1.61s (± 3.40%)	~	1.56s	1.71s	p=0.295 n=6
Check Time	22.27s (± 0.29%)	22.25s (± 0.38%)	~	22.18s	22.41s	p=0.629 n=6
Emit Time	1.71s (± 0.95%)	1.71s (± 2.74%)	~	1.65s	1.78s	p=0.627 n=6
Total Time	29.77s (± 0.26%)	29.74s (± 0.40%)	~	29.62s	29.96s	p=0.574 n=6
vscode - node (v18.15.0, x64)
Memory used	2,913,559k (± 0.00%)	2,913,569k (± 0.00%)	~	2,913,446k	2,913,661k	p=0.689 n=6
Parse Time	16.47s (± 0.28%)	16.46s (± 0.45%)	~	16.39s	16.56s	p=0.748 n=6
Bind Time	4.94s (± 1.85%)	5.05s (± 2.37%)	~	4.89s	5.15s	p=0.195 n=6
Check Time	87.71s (± 0.23%)	87.75s (± 0.27%)	~	87.47s	88.04s	p=0.810 n=6
Emit Time	23.61s (± 0.61%)	23.75s (± 0.43%)	+0.14s (+ 0.60%)	23.66s	23.90s	p=0.045 n=6
Total Time	132.73s (± 0.12%)	133.01s (± 0.18%)	~	132.67s	133.25s	p=0.093 n=6
webpack - node (v18.15.0, x64)
Memory used	409,383k (± 0.01%)	409,387k (± 0.01%)	~	409,337k	409,443k	p=1.000 n=6
Parse Time	3.93s (± 0.59%)	3.90s (± 0.82%)	~	3.86s	3.95s	p=0.125 n=6
Bind Time	1.66s (± 0.25%)	1.64s (± 0.54%)	-0.02s (- 1.30%)	1.63s	1.65s	p=0.003 n=6
Check Time	16.93s (± 0.26%)	16.96s (± 0.31%)	~	16.88s	17.00s	p=0.222 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	22.52s (± 0.21%)	22.50s (± 0.24%)	~	22.42s	22.56s	p=0.748 n=6
xstate - node (v18.15.0, x64)
Memory used	671,929k (± 0.01%)	671,956k (± 0.01%)	~	671,881k	672,114k	p=0.630 n=6
Parse Time	4.12s (± 0.48%)	4.18s (± 3.75%)	~	4.09s	4.50s	p=0.868 n=6
Bind Time	1.88s (± 1.15%)	1.87s (± 0.92%)	~	1.85s	1.89s	p=0.807 n=6
Check Time	3.44s (± 0.60%)	3.45s (± 0.12%)	~	3.45s	3.46s	p=0.114 n=6
Emit Time	0.03s (±14.39%)	0.03s (± 0.00%)	~	0.03s	0.03s	p=0.405 n=6
Total Time	9.48s (± 0.31%)	9.54s (± 1.69%)	~	9.44s	9.86s	p=0.936 n=6

System info unknown

Hosts

• node (v18.15.0, x64)

Scenarios

• Angular - node (v18.15.0, x64)
• Compiler-Unions - node (v18.15.0, x64)
• Monaco - node (v18.15.0, x64)
• TFS - node (v18.15.0, x64)
• material-ui - node (v18.15.0, x64)
• mui-docs - node (v18.15.0, x64)
• self-build-src - node (v18.15.0, x64)
• self-build-src-public-api - node (v18.15.0, x64)
• self-compiler - node (v18.15.0, x64)
• vscode - node (v18.15.0, x64)
• webpack - node (v18.15.0, x64)
• xstate - node (v18.15.0, x64)

Benchmark	Name	Iterations
Current	pr	6
Baseline	baseline	6

Developer Information:

Download Benchmarks

[typescript-bot]

@jakebailey Here are the results of running the top 400 repos comparing main and refs/pull/58186/merge:

Everything looks good!