Error on references to literal enum members in conditions #58264

weswigham · 2024-04-20T00:57:25Z

So when you write

enum NodeKind {
    FunctionDeclaration = 0,
    VariableDeclaration = 1,
    ExpressionStatement = 2,
}

function kindToString(kind: NodeKind) {
    Debug.assert(!isExpressionStatementKind(kind));
    return NodeKind.FunctionDeclaration ? "func" : "var";
}

we inform you in advance that you've failed to actually write kind ===.

weswigham · 2024-04-20T01:07:20Z

@typescript-bot test it

typescript-bot · 2024-04-20T01:07:27Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-04-20T01:30:01Z

Hey @weswigham, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-04-20T01:36:03Z

@weswigham Here are the results of running the user tests comparing main and refs/pull/58264/merge:

Everything looks good!

typescript-bot · 2024-04-20T01:51:41Z

@weswigham
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{297,484k (± 0.01%)}	_{297,458k (± 0.01%)}	_~	_297,443k	_297,484k	_{p=0.066 n=6}
_{Parse Time}	_{3.29s (± 0.23%)}	_{3.29s (± 0.52%)}	_~	_3.27s	_3.31s	_{p=0.869 n=6}
_{Bind Time}	_{0.97s (± 0.53%)}	_{0.97s (± 0.42%)}	_~	_0.97s	_0.98s	_{p=0.595 n=6}
_{Check Time}	_{9.81s (± 0.33%)}	_{9.84s (± 0.33%)}	_~	_9.80s	_9.87s	_{p=0.162 n=6}
_{Emit Time}	_{8.45s (± 0.32%)}	_{8.47s (± 0.17%)}	_~	_8.45s	_8.49s	_{p=0.191 n=6}
_{Total Time}	_{22.52s (± 0.17%)}	_{22.58s (± 0.20%)}	_~	_22.53s	_22.64s	_{p=0.089 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,959k (± 1.02%)}	_{192,729k (± 0.76%)}	_~	_192,029k	_195,730k	_{p=0.230 n=6}
_{Parse Time}	_{2.03s (± 0.97%)}	_{2.02s (± 1.58%)}	_~	_1.99s	_2.07s	_{p=0.520 n=6}
_{Bind Time}	_{1.07s (± 1.09%)}	_{1.07s (± 0.84%)}	_~	_1.06s	_1.08s	_{p=0.672 n=6}
_{Check Time}	_{14.07s (± 0.51%)}	_{14.06s (± 0.77%)}	_~	_13.91s	_14.16s	_{p=0.809 n=6}
_{Emit Time}	_{3.87s (± 0.77%)}	_{3.89s (± 0.53%)}	_~	_3.85s	_3.91s	_{p=0.418 n=6}
_{Total Time}	_{21.05s (± 0.35%)}	_{21.04s (± 0.38%)}	_~	_20.94s	_21.13s	_{p=0.936 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,753,238k (± 0.00%)}	_{1,753,261k (± 0.00%)}	_~	_1,753,222k	_1,753,298k	_{p=0.230 n=6}
_{Parse Time}	_{6.94s (± 0.30%)}	_{6.93s (± 0.22%)}	_~	_6.92s	_6.96s	_{p=0.511 n=6}
_{Bind Time}	_{2.31s (± 0.18%)}	_{2.31s (± 0.36%)}	_~	_2.30s	_2.32s	_{p=0.097 n=6}
_{Check Time}	_{56.76s (± 0.56%)}	_{56.75s (± 0.30%)}	_~	_56.56s	_56.96s	_{p=0.873 n=6}
_{Emit Time}	_{0.14s (± 2.88%)}	_{0.14s (± 2.88%)}	_~	_0.14s	_0.15s	_{p=1.000 n=6}
_{Total Time}	_{66.15s (± 0.50%)}	_{66.13s (± 0.23%)}	_~	_65.97s	_66.34s	_{p=1.000 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,322,214k (± 0.04%)}	_{2,322,572k (± 0.04%)}	_~	_2,321,760k	_2,324,125k	_{p=0.810 n=6}
_{Parse Time}	_{7.56s (± 0.81%)}	_{7.58s (± 0.40%)}	_~	_7.55s	_7.63s	_{p=0.630 n=6}
_{Bind Time}	_{2.73s (± 0.72%)}	_{2.73s (± 0.82%)}	_~	_2.71s	_2.77s	_{p=0.808 n=6}
_{Check Time}	_{49.46s (± 0.76%)}	_{49.26s (± 0.49%)}	_~	_48.98s	_49.53s	_{p=0.575 n=6}
_{Emit Time}	_{4.08s (± 1.79%)}	_{4.02s (± 4.91%)}	_~	_3.80s	_4.38s	_{p=0.298 n=6}
_{Total Time}	_{63.84s (± 0.59%)}	_{63.58s (± 0.45%)}	_~	_63.14s	_63.85s	_{p=0.378 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_{Memory used}	_{2,396,448k (± 0.04%)}	_{2,396,351k (± 0.03%)}	_~	_2,395,423k	_2,397,135k	_{p=0.810 n=6}
_{Parse Time}	_{7.82s (± 0.69%)}	_{7.78s (± 0.84%)}	_~	_7.67s	_7.87s	_{p=0.423 n=6}
_{Bind Time}	_{2.46s (± 1.01%)}	_{2.46s (± 0.97%)}	_~	_2.44s	_2.49s	_{p=0.870 n=6}
_{Check Time}	_{50.15s (± 0.72%)}	_{50.08s (± 0.39%)}	_~	_49.87s	_50.42s	_{p=0.936 n=6}
_{Emit Time}	_{4.04s (± 2.79%)}	_{4.07s (± 5.41%)}	_~	_3.84s	_4.35s	_{p=1.000 n=6}
_{Total Time}	_{64.47s (± 0.45%)}	_{64.39s (± 0.51%)}	_~	_63.98s	_64.81s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{423,932k (± 0.01%)}	_{423,924k (± 0.01%)}	_~	_423,881k	_423,973k	_{p=0.873 n=6}
_{Parse Time}	_{2.90s (± 1.05%)}	_{2.91s (± 0.71%)}	_~	_2.87s	_2.93s	_{p=0.935 n=6}
_{Bind Time}	_{1.09s (± 1.16%)}	_{1.09s (± 0.37%)}	_~	_1.08s	_1.09s	_{p=0.753 n=6}
_{Check Time}	_{15.42s (± 0.38%)}	_{15.41s (± 0.29%)}	_~	_15.33s	_15.45s	_{p=1.000 n=6}
_{Emit Time}	_{1.18s (± 1.13%)}	_{1.17s (± 0.64%)}	_~	_1.16s	_1.18s	_{p=0.155 n=6}
_{Total Time}	_{20.59s (± 0.28%)}	_{20.57s (± 0.28%)}	_~	_20.49s	_20.65s	_{p=0.687 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_{Memory used}	_{369,286k (± 0.01%)}	_{369,273k (± 0.01%)}	_~	_369,250k	_369,318k	_{p=0.936 n=6}
_{Parse Time}	_{3.65s (± 0.75%)}	_{3.67s (± 0.75%)}	_~	_3.63s	_3.71s	_{p=0.366 n=6}
_{Bind Time}	_{1.92s (± 2.19%)}	_{1.93s (± 1.12%)}	_~	_1.90s	_1.96s	_{p=1.000 n=6}
_{Check Time}	_{19.46s (± 0.30%)}	_{19.44s (± 0.42%)}	_~	_19.30s	_19.54s	_{p=0.809 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{25.03s (± 0.40%)}	_{25.03s (± 0.47%)}	_~	_24.86s	_25.19s	_{p=0.872 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,920,809k (± 0.00%)}	_{2,920,823k (± 0.00%)}	_~	_2,920,785k	_2,920,849k	_{p=0.423 n=6}
_{Parse Time}	_{16.64s (± 0.33%)}	_{16.60s (± 0.23%)}	_~	_16.56s	_16.66s	_{p=0.195 n=6}
_{Bind Time}	_{4.96s (± 0.55%)}	_{4.95s (± 1.00%)}	_~	_4.90s	_5.02s	_{p=0.872 n=6}
_{Check Time}	_{88.06s (± 0.11%)}	_{87.89s (± 0.42%)}	_~	_87.49s	_88.55s	_{p=0.173 n=6}
_{Emit Time}	_{24.55s (± 7.26%)}	_{23.71s (± 0.50%)}	_~	_23.60s	_23.93s	_{p=0.065 n=6}
_{Total Time}	_{134.20s (± 1.32%)}	_{133.16s (± 0.27%)}	_~	_132.68s	_133.65s	_{p=0.093 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{409,945k (± 0.01%)}	_{409,910k (± 0.02%)}	_~	_409,817k	_410,030k	_{p=0.298 n=6}
_{Parse Time}	_{4.89s (± 0.50%)}	_{4.89s (± 0.93%)}	_~	_4.84s	_4.97s	_{p=0.618 n=6}
_{Bind Time}	_{2.02s (± 1.20%)}	_{2.02s (± 0.85%)}	_~	_2.00s	_2.04s	_{p=0.871 n=6}
_{Check Time}	_{21.06s (± 0.37%)}	_{21.13s (± 0.36%)}	_~	_21.05s	_21.26s	_{p=0.296 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{27.97s (± 0.30%)}	_{28.04s (± 0.31%)}	_~	_27.95s	_28.20s	_{p=0.419 n=6}
_{xstate-main - node (v18.15.0, x64)}
_{Memory used}	_{459,428k (± 0.02%)}	_{459,427k (± 0.01%)}	_~	_459,383k	_459,486k	_{p=0.471 n=6}
_{Parse Time}	_{4.02s (± 0.30%)}	_{4.00s (± 0.40%)}	_~	_3.98s	_4.02s	_{p=0.121 n=6}
_{Bind Time}	_{1.47s (± 0.70%)}	_{1.47s (± 1.33%)}	_~	_1.45s	_1.50s	_{p=0.935 n=6}
_{Check Time}	_{22.42s (± 0.48%)}	_{22.32s (± 0.64%)}	_~	_22.15s	_22.51s	_{p=0.298 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{27.90s (± 0.38%)}	_{27.80s (± 0.56%)}	_~	_27.59s	_27.98s	_{p=0.261 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-04-20T02:44:59Z

@weswigham Here are the results of running the top 400 repos comparing main and refs/pull/58264/merge:

Everything looks good!

fatcerberus · 2024-04-21T20:16:18Z

Is this a common mistake? I don't think I've ever done this. I think I'd rather this be a more general check of "you're testing the value of a (pseudo-)constant, did you mean to do that?" which feels way more useful than trying to detect that I wrote if (y) instead of if (x === y)

RyanCavanaugh · 2024-04-22T15:11:50Z

I think I'd rather this be a more general check of "you're testing the value of a (pseudo-)constant, did you mean to do that?

I think we basically already have that in some cases but not all, e.g.

function foo() { }
if (foo) {
}

where your program has no plausible way of varying on foo

gabritto · 2024-04-22T17:57:49Z

@typescript-bot pack this

typescript-bot · 2024-04-22T17:57:53Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started	✅ Results

typescript-bot · 2024-04-22T18:02:46Z

Hey @gabritto, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/161409/artifacts?artifactName=tgz&fileId=6DEC9CAB3714C4E9D09BADA60D30625831D6CED0CF6BE9ACC45D0C7B100BE6B602&fileName=/typescript-5.5.0-insiders.20240422.tgz"
    }
}

and then running npm install.

jakebailey · 2024-04-22T19:22:26Z

@typescript-bot pack this

typescript-bot · 2024-04-22T19:22:28Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started	✅ Results

typescript-bot · 2024-04-22T19:27:19Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/161410/artifacts?artifactName=tgz&fileId=6DEC9CAB3714C4E9D09BADA60D30625831D6CED0CF6BE9ACC45D0C7B100BE6B602&fileName=/typescript-5.5.0-insiders.20240422.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.5.0-pr-58264-13".;

Error on references to literal enum members in conditions

82d1de9

weswigham requested review from DanielRosenwasser and gabritto April 20, 2024 00:57

typescript-bot assigned weswigham Apr 20, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 20, 2024

gabritto approved these changes Apr 22, 2024

View reviewed changes

weswigham merged commit e6ba82b into microsoft:main Apr 24, 2024
25 checks passed

weswigham deleted the always-enum-error branch April 24, 2024 17:33

DanielRosenwasser mentioned this pull request May 2, 2024

Design Meeting Notes, 4/23/2024 #58415

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Error on references to literal enum members in conditions #58264

Error on references to literal enum members in conditions #58264

weswigham commented Apr 20, 2024

weswigham commented Apr 20, 2024

typescript-bot commented Apr 20, 2024 •

edited

typescript-bot commented Apr 20, 2024

typescript-bot commented Apr 20, 2024

typescript-bot commented Apr 20, 2024

tsc

typescript-bot commented Apr 20, 2024

fatcerberus commented Apr 21, 2024 •

edited

RyanCavanaugh commented Apr 22, 2024

gabritto commented Apr 22, 2024

typescript-bot commented Apr 22, 2024 •

edited

typescript-bot commented Apr 22, 2024

jakebailey commented Apr 22, 2024

typescript-bot commented Apr 22, 2024 •

edited

typescript-bot commented Apr 22, 2024 •

edited

Error on references to literal enum members in conditions #58264

Error on references to literal enum members in conditions #58264

Conversation

weswigham commented Apr 20, 2024

weswigham commented Apr 20, 2024

typescript-bot commented Apr 20, 2024 • edited

typescript-bot commented Apr 20, 2024

typescript-bot commented Apr 20, 2024

typescript-bot commented Apr 20, 2024

tsc

typescript-bot commented Apr 20, 2024

fatcerberus commented Apr 21, 2024 • edited

RyanCavanaugh commented Apr 22, 2024

gabritto commented Apr 22, 2024

typescript-bot commented Apr 22, 2024 • edited

typescript-bot commented Apr 22, 2024

jakebailey commented Apr 22, 2024

typescript-bot commented Apr 22, 2024 • edited

typescript-bot commented Apr 22, 2024 • edited

typescript-bot commented Apr 20, 2024 •

edited

fatcerberus commented Apr 21, 2024 •

edited

typescript-bot commented Apr 22, 2024 •

edited

typescript-bot commented Apr 22, 2024 •

edited

typescript-bot commented Apr 22, 2024 •

edited