Report unreachable on enums #58380

jakebailey · 2024-04-30T23:42:54Z

Fixes #58379. I think...

jakebailey · 2024-04-30T23:43:06Z

@typescript-bot test it
@typescript-bot pack this

typescript-bot · 2024-04-30T23:43:09Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results
`pack this`	✅ Started	✅ Results

typescript-bot · 2024-04-30T23:47:42Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/161578/artifacts?artifactName=tgz&fileId=D3F40B62AD78B59BAB96414F0AECB3FB65A5F0751FF60600BA61828C96046C3F02&fileName=/typescript-5.5.0-insiders.20240430.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.5.0-pr-58380-2".;

typescript-bot · 2024-05-01T00:06:12Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-05-01T00:06:35Z

@jakebailey Here are the results of running the user tests comparing main and refs/pull/58380/merge:

Everything looks good!

jakebailey · 2024-05-01T00:10:41Z

Even this is not enough: https://www.typescriptlang.org/play/?ts=5.5.0-pr-58380-2#code/GYVwdgxgLglg9mABAIwDYEMAWAKAlIgbwFgAoASHQDFwI8BuU0siBAZzlQFMA6VOAc2wAhdACduAQVwNyLMOy68B2NFm4AHUXHXSmchTz6CwnAO6JKcOHlx62HQ8pEAvbgDd0qEJ10lG5UU4oEFEwGSZQSFgERCoaPEImZntFI2ExSV8yZPkHJUFVTA0tHRls-Ty0k3NLa1xbchyDfPTXDy8fMoBffyaoFAxMRABeQkRNbQAuRABGACYAZgAWRC7w8k4wEABbRBFRMYlV3ogMVlYLKzGADxHZxZWev3IwdG3OVnV0CE499Gcxpxruo4KJ+vp+u1vHd5stjiQukA

typescript-bot · 2024-05-01T00:18:04Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,154	_62,154	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,273	_50,273	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,817k (± 0.80%)}	_{192,187k (± 0.02%)}	_~	_192,131k	_192,229k	_{p=0.936 n=6}
_{Parse Time}	_{1.29s (± 1.58%)}	_{1.29s (± 1.03%)}	_~	_1.27s	_1.31s	_{p=0.934 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.53s (± 0.21%)}	_{9.53s (± 0.40%)}	_~	_9.50s	_9.60s	_{p=0.462 n=6}
_{Emit Time}	_{2.64s (± 0.24%)}	_{2.64s (± 0.44%)}	_~	_2.62s	_2.65s	_{p=1.000 n=6}
_{Total Time}	_{14.18s (± 0.17%)}	_{14.17s (± 0.31%)}	_~	_14.12s	_14.24s	_{p=0.627 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,322	_945,322	_~	_~	_~	_{p=1.000 n=6}
_Types	_408,088	_408,088	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,797k (± 0.00%)}	_{1,222,816k (± 0.00%)}	_~	_1,222,772k	_1,222,860k	_{p=0.575 n=6}
_{Parse Time}	_{6.77s (± 0.30%)}	_{6.78s (± 0.34%)}	_~	_6.74s	_6.81s	_{p=0.560 n=6}
_{Bind Time}	_{1.87s (± 0.71%)}	_{1.88s (± 0.65%)}	_~	_1.86s	_1.89s	_{p=0.652 n=6}
_{Check Time}	_{31.32s (± 0.36%)}	_{31.27s (± 0.20%)}	_~	_31.19s	_31.36s	_{p=0.520 n=6}
_{Emit Time}	_{14.64s (± 0.90%)}	_{14.66s (± 0.88%)}	_~	_14.41s	_14.78s	_{p=1.000 n=6}
_{Total Time}	_{54.59s (± 0.20%)}	_{54.58s (± 0.20%)}	_~	_54.37s	_54.68s	_{p=0.936 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,956,164	_1,956,164	_~	_~	_~	_{p=1.000 n=6}
_Types	_676,919	_676,919	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,757,740k (± 0.00%)}	_{1,757,749k (± 0.00%)}	_~	_1,757,714k	_1,757,783k	_{p=0.689 n=6}
_{Parse Time}	_{6.71s (± 0.29%)}	_{6.71s (± 0.30%)}	_~	_6.69s	_6.74s	_{p=0.806 n=6}
_{Bind Time}	_{2.31s (± 0.52%)}	_{2.30s (± 0.71%)}	_~	_2.28s	_2.32s	_{p=0.265 n=6}
_{Check Time}	_{56.11s (± 0.43%)}	_{56.01s (± 0.52%)}	_~	_55.51s	_56.32s	_{p=0.630 n=6}
_{Emit Time}	_{0.13s (± 3.10%)}	_{0.13s (± 3.10%)}	_~	_0.13s	_0.14s	_{p=1.000 n=6}
_{Total Time}	_{65.26s (± 0.38%)}	_{65.16s (± 0.46%)}	_~	_64.64s	_65.46s	_{p=0.630 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,217,124	_1,217,124	_~	_~	_~	_{p=1.000 n=6}
_Types	_258,216	_258,217	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,327,099k (± 0.03%)}	_{2,327,118k (± 0.03%)}	_~	_2,326,301k	_2,328,071k	_{p=1.000 n=6}
_{Parse Time}	_{4.99s (± 0.83%)}	_{4.92s (± 1.02%)}	_~	_4.85s	_5.00s	_{p=0.064 n=6}
_{Bind Time}	_{1.86s (± 0.81%)}	_{1.88s (± 1.42%)}	_~	_1.85s	_1.92s	_{p=0.402 n=6}
_{Check Time}	_{33.44s (± 0.26%)}	_{33.35s (± 0.41%)}	_~	_33.13s	_33.55s	_{p=0.297 n=6}
_{Emit Time}	_{2.59s (± 1.91%)}	_{2.58s (± 1.82%)}	_~	_2.52s	_2.63s	_{p=0.810 n=6}
_{Total Time}	_{42.90s (± 0.36%)}	_{42.74s (± 0.35%)}	_~	_42.46s	_42.87s	_{p=0.199 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,217,124	_1,217,124	_~	_~	_~	_{p=1.000 n=6}
_Types	_258,216	_258,217	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,401,607k (± 0.02%)}	_{2,401,581k (± 0.01%)}	_~	_2,400,983k	_2,401,876k	_{p=1.000 n=6}
_{Parse Time}	_{6.14s (± 0.42%)}	_{6.16s (± 0.60%)}	_~	_6.13s	_6.21s	_{p=0.470 n=6}
_{Bind Time}	_{2.04s (± 1.23%)}	_{2.02s (± 1.93%)}	_~	_1.97s	_2.07s	_{p=0.572 n=6}
_{Check Time}	_{40.00s (± 0.20%)}	_{40.07s (± 0.19%)}	_~	_39.95s	_40.19s	_{p=0.378 n=6}
_{Emit Time}	_{3.14s (± 0.94%)}	_{3.15s (± 0.95%)}	_~	_3.12s	_3.19s	_{p=1.000 n=6}
_{Total Time}	_{51.32s (± 0.18%)}	_{51.41s (± 0.19%)}	_~	_51.24s	_51.50s	_{p=0.093 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,229	_256,229	_~	_~	_~	_{p=1.000 n=6}
_Types	_103,713	_103,714	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{424,282k (± 0.01%)}	_{424,282k (± 0.01%)}	_~	_424,258k	_424,327k	_{p=0.936 n=6}
_{Parse Time}	_{3.35s (± 0.49%)}	_{3.34s (± 0.65%)}	_~	_3.31s	_3.37s	_{p=0.465 n=6}
_{Bind Time}	_{1.30s (± 0.58%)}	_{1.30s (± 0.31%)}	_~	_1.30s	_1.31s	_{p=0.389 n=6}
_{Check Time}	_{17.69s (± 0.38%)}	_{17.69s (± 0.32%)}	_~	_17.63s	_17.80s	_{p=0.570 n=6}
_{Emit Time}	_{1.36s (± 1.18%)}	_{1.36s (± 1.91%)}	_~	_1.31s	_1.39s	_{p=0.934 n=6}
_{Total Time}	_{23.69s (± 0.29%)}	_{23.69s (± 0.34%)}	_~	_23.62s	_23.84s	_{p=0.470 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,824	_224,824	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,390	_93,390	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,300k (± 0.00%)}	_{369,296k (± 0.01%)}	_~	_369,252k	_369,339k	_{p=0.936 n=6}
_{Parse Time}	_{3.51s (± 0.63%)}	_{3.53s (± 1.01%)}	_~	_3.47s	_3.58s	_{p=0.223 n=6}
_{Bind Time}	_{1.94s (± 1.10%)}	_{1.95s (± 1.35%)}	_~	_1.92s	_1.98s	_{p=0.807 n=6}
_{Check Time}	_{19.35s (± 0.28%)}	_{19.34s (± 0.20%)}	_~	_19.31s	_19.39s	_{p=0.746 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.79s (± 0.23%)}	_{24.82s (± 0.18%)}	_~	_24.78s	_24.89s	_{p=0.573 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₄	₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,799,582	_2,799,582	_~	_~	_~	_{p=1.000 n=6}
_Types	_950,968	_950,968	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,928,376k (± 0.01%)}	_{2,928,361k (± 0.01%)}	_~	_2,927,844k	_2,928,483k	_{p=0.748 n=6}
_{Parse Time}	_{13.30s (± 0.26%)}	_{13.33s (± 0.44%)}	_~	_13.27s	_13.42s	_{p=0.421 n=6}
_{Bind Time}	_{4.20s (± 2.39%)}	_{4.26s (± 1.99%)}	_~	_4.09s	_4.31s	_{p=0.372 n=6}
_{Check Time}	_{72.81s (± 0.22%)}	_{72.92s (± 0.52%)}	_~	_72.53s	_73.57s	_{p=1.000 n=6}
_{Emit Time}	_{20.08s (± 4.32%)}	_{19.95s (± 3.66%)}	_~	_19.44s	_21.42s	_{p=0.688 n=6}
_{Total Time}	_{110.40s (± 0.89%)}	_{110.46s (± 0.74%)}	_~	_109.54s	_111.91s	_{p=1.000 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_265,858	_265,858	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,442	_108,442	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{410,415k (± 0.01%)}	_{410,457k (± 0.02%)}	_~	_410,367k	_410,558k	_{p=0.336 n=6}
_{Parse Time}	_{4.75s (± 0.42%)}	_{4.78s (± 0.51%)}	_~	_4.75s	_4.81s	_{p=0.124 n=6}
_{Bind Time}	_{2.05s (± 0.51%)}	_{2.04s (± 0.80%)}	_~	_2.02s	_2.06s	_{p=0.250 n=6}
_{Check Time}	_{20.92s (± 0.46%)}	_{20.96s (± 0.29%)}	_~	_20.89s	_21.04s	_{p=0.378 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.73s (± 0.37%)}	_{27.78s (± 0.22%)}	_~	_27.70s	_27.87s	_{p=0.469 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_524,146	_524,146	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,732	_178,732	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,182k (± 0.02%)}	_{462,239k (± 0.02%)}	_~	_462,086k	_462,334k	_{p=0.378 n=6}
_{Parse Time}	_{3.90s (± 0.44%)}	_{3.89s (± 0.66%)}	_~	_3.86s	_3.92s	_{p=0.517 n=6}
_{Bind Time}	_{1.46s (± 1.41%)}	_{1.47s (± 1.65%)}	_~	_1.45s	_1.51s	_{p=1.000 n=6}
_{Check Time}	_{22.52s (± 0.56%)}	_{22.46s (± 0.77%)}	_~	_22.21s	_22.75s	_{p=0.261 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.88s (± 0.42%)}	_{27.81s (± 0.57%)}	_~	_27.64s	_28.11s	_{p=0.297 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-05-01T01:41:36Z

@jakebailey Here are the results of running the top 400 repos comparing main and refs/pull/58380/merge:

Everything looks good!

DanielRosenwasser · 2024-05-01T18:44:19Z

src/compiler/binder.ts

@@ -3785,6 +3785,7 @@ function createBinder(): (file: SourceFile, options: CompilerOptions) => void {
                (isStatementButNotDeclaration(node) && node.kind !== SyntaxKind.EmptyStatement) ||
                // report error on class declarations
                node.kind === SyntaxKind.ClassDeclaration ||
+                (node.kind === SyntaxKind.EnumDeclaration && (!isEnumConst(node as EnumDeclaration) || shouldPreserveConstEnums(options))) ||


Suggested change

(node.kind === SyntaxKind.EnumDeclaration && (!isEnumConst(node as EnumDeclaration) || shouldPreserveConstEnums(options))) ||

// report errors on enums with preserved emit

(node.kind === SyntaxKind.EnumDeclaration && (!isEnumConst(node as EnumDeclaration) || shouldPreserveConstEnums(options))) ||

DanielRosenwasser

Not a great error span but it's fine.

jakebailey · 2024-05-01T19:12:32Z

Yeah, this isn't quite done; classes get a better message here.

jakebailey added 2 commits April 30, 2024 16:33

Add test

87da460

Report unreachable on enums

6f32cd6

typescript-bot assigned jakebailey Apr 30, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 30, 2024

other test

e1fcb73

jakebailey marked this pull request as draft May 1, 2024 00:10

DanielRosenwasser reviewed May 1, 2024

View reviewed changes

DanielRosenwasser approved these changes May 1, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Report unreachable on enums #58380

Report unreachable on enums #58380

jakebailey commented Apr 30, 2024

jakebailey commented Apr 30, 2024

typescript-bot commented Apr 30, 2024 •

edited

typescript-bot commented Apr 30, 2024 •

edited

typescript-bot commented May 1, 2024

typescript-bot commented May 1, 2024

jakebailey commented May 1, 2024

typescript-bot commented May 1, 2024

tsc

typescript-bot commented May 1, 2024

DanielRosenwasser May 1, 2024

DanielRosenwasser left a comment

jakebailey commented May 1, 2024

Report unreachable on enums #58380

Are you sure you want to change the base?

Report unreachable on enums #58380

Conversation

jakebailey commented Apr 30, 2024

jakebailey commented Apr 30, 2024

typescript-bot commented Apr 30, 2024 • edited

typescript-bot commented Apr 30, 2024 • edited

typescript-bot commented May 1, 2024

typescript-bot commented May 1, 2024

jakebailey commented May 1, 2024

typescript-bot commented May 1, 2024

tsc

typescript-bot commented May 1, 2024

DanielRosenwasser May 1, 2024

Choose a reason for hiding this comment

DanielRosenwasser left a comment

Choose a reason for hiding this comment

jakebailey commented May 1, 2024

typescript-bot commented Apr 30, 2024 •

edited

typescript-bot commented Apr 30, 2024 •

edited